Hi betacentauri, I have reviewed your patches, everything looks good, here is few points in the patches that I'd disagree:
1. you have increased the scope of some variables, that is so much c era, in c++ you declare them right before they're used, I wont go in to polemics why it is better too have the smallest possible scope for a variable.
and in c++ the following is preferred:
int i = value; or int i(value);
over:
int i;
i = value;
2. This is a matter of reference, but I still think one liner if statement looks better and it gives you more code on one screen page
3. You have changed some of the log messages in void eHttpStream::thread(), in my opinion your messages are useless, I have spent hours looking at the logs trying to figure out what is going on in that code, I changed them for a reason. For example how do you distinguish a connection failure from too many redirects? And what is the mining of "Thread end connection", do you think this will tell you the right think when looking in the logs?
Edited by zakalibit, 10 November 2013 - 11:29.