1748 replies to this topic

[athoik]

Great! Thanks for applying backported patches for it913x.

 

Also commit the changes for vuplus (vuplus 3.1.1: Add support for more DVB-T usb sticks) post #392

 

When this done i will prepare also patch for siano (for all boxes minus xp )

[Erik Slagter]

Also commit the changes for vuplus (vuplus 3.1.1: Add support for more DVB-T usb sticks) post #392

Next thing on my list now the hbbtv for vuplus is finally as it should be.

[Erik Slagter]

Tested and committed!

 

Are there still patches left that I forgot?

[athoik]

There are also patches from vu dvbmediasink (in order to play vmw + vma via ffmpeg) http://openpli.org/f...e-5#entry394163

 

Also patches for siano based stick (xp doen't need this patch, also this patch obsoletes fix-dvb-siano-sms-order.patch) http://openpli.org/f...-2#entry396227. Do you wan't me to create patch for OE?

 

PS. Thanks Erik for testing and comming community patches back to OpenPLi.

Edited by athoik, 16 January 2014 - 20:38.

[littlesat]

Erik, I suggest we should consider to commit the mediasink patch voor de vu's... It was made for pli.

[Erik Slagter]

There are also patches from vu dvbmediasink (in order to play vmw + vma via ffmpeg) http://openpli.org/f...e-5#entry394163

Somehow I completely missed this thread!

 

I have applied it and I'm now doing a test build.

 

There are two little "problems" with the patch:

- git complains about whitespace, this is unavoidable sometimes, I must check that

- there is a chunk that I don't understand in this context:

diff --git a/meta-openpli/recipes-bsp/vuplus/gst-plugin-vuplus-dvbmediasink/fix_dvbvideosink_dm8000_padtemplate.patch b/meta-openpli/recipes-bsp/vuplus/gst-plugin-vuplus-dvbmed
new file mode 100644
index 0000000..9d5f8ba
--- /dev/null
+++ b/meta-openpli/recipes-bsp/vuplus/gst-plugin-vuplus-dvbmediasink/fix_dvbvideosink_dm8000_padtemplate.patch
@@ -0,0 +1,15 @@
+diff --git a/src/gstdvbvideosink.c b/src/gstdvbvideosink.c
+index fcd8fed..b3ce35f 100644
+--- a/src/gstdvbvideosink.c
++++ b/src/gstdvbvideosink.c
+@@ -316,8 +316,8 @@ gst_dvbvideosink_base_init (gpointer klass)
+               GST_INFO ("model is DM7020HD... set bcm7405 caps");
+           } else if ( !strncasecmp(string, "DM8000", 6) ) {
+               hwtype = DM8000;
+-              hwtemplate = &sink_factory_bcm7400;
+-              GST_INFO ("model is DM8000... set bcm7400 caps");
++              hwtemplate = &sink_factory_bcm7405;
++              GST_INFO ("model is DM8000... set bcm7405 caps");
+           } else if ( !strncasecmp(string, "DM800", 5) ) {
+               hwtype = DM800;
+               hwtemplate = &sink_factory_bcm7401; 

1) what does a dm8000 do in a vuplus patch

2) why should a dm8000 advertise as bcm7405???

 

I'd rather have this one out, at least from this commit, are you ok? I can arrange for it.

 

Also patches for siano based stick (xp doen't need this patch, also this patch obsoletes fix-dvb-siano-sms-order.patch) http://openpli.org/f...-2#entry396227. Do you wan't me to create patch for OE?

Yes please, everything with "sticks" I don't have a clue about, so it better be good

 

PS. Thanks Erik for testing and comming community patches back to OpenPLi.

No you thanks, for so much useful contribution! Also most of the time easily applyable patches, no everybody masters that art

[Erik Slagter]

Erik, I suggest we should consider to commit the mediasink patch voor de vu's... It was made for pli.

On it's way... I missed it somehow. It only affects vuplus receivers so little chance of messing up other brands' receivers, that's always good.

[Erik Slagter]

vuplus wma patch commited, without the dm8000 part.

[littlesat]

Sometimes vu need checks on dmm boxes in the software. Be aware of that...

[Erik Slagter]

Did you see the patch? Highly unprobable in this case imho.

[littlesat]

So the dm8000 part was included?

[Erik Slagter]

Nope, see the commit.

 

If it breaks (however unlikely) we can always add it later.

[athoik]

 there is a chunk that I don't understand in this context:

diff --git a/meta-openpli/recipes-bsp/vuplus/gst-plugin-vuplus-dvbmediasink/fix_dvbvideosink_dm8000_padtemplate.patch b/meta-openpli/recipes-bsp/vuplus/gst-plugin-vuplus-dvbmed
new file mode 100644
index 0000000..9d5f8ba
--- /dev/null
+++ b/meta-openpli/recipes-bsp/vuplus/gst-plugin-vuplus-dvbmediasink/fix_dvbvideosink_dm8000_padtemplate.patch
@@ -0,0 +1,15 @@
+diff --git a/src/gstdvbvideosink.c b/src/gstdvbvideosink.c
+index fcd8fed..b3ce35f 100644
+--- a/src/gstdvbvideosink.c
++++ b/src/gstdvbvideosink.c
+@@ -316,8 +316,8 @@ gst_dvbvideosink_base_init (gpointer klass)
+               GST_INFO ("model is DM7020HD... set bcm7405 caps");
+           } else if ( !strncasecmp(string, "DM8000", 6) ) {
+               hwtype = DM8000;
+-              hwtemplate = &sink_factory_bcm7400;
+-              GST_INFO ("model is DM8000... set bcm7400 caps");
++              hwtemplate = &sink_factory_bcm7405;
++              GST_INFO ("model is DM8000... set bcm7405 caps");
+           } else if ( !strncasecmp(string, "DM800", 5) ) {
+               hwtype = DM800;
+               hwtemplate = &sink_factory_bcm7401; 

1) what does a dm8000 do in a vuplus patch

2) why should a dm8000 advertise as bcm7405???

 

I'd rather have this one out, at least from this commit, are you ok? I can arrange for it.

 

Hello,

 

This patch is copied from code.vuplus.com ( http://code.vuplus.c...1db09f5bb2ad8a9). If someone post the output of /proc/stb/info/model for every vubox its easy to give an accureate answer. My impression is that vuboxes advertized as DM8000 in /proc/stb/info/model, so you need use full caps (sink_factory_bcm7405).

 

In the meanwhile, vu commited another patch "Set-only-by-hardware-supported-audio-mpeg-4-profile.patch". It might be good to submit that one too.

[macnuts]

I support athoik.

"DM8000 part" is required in my opinion.

VU+duo2 (and solo2 most probably) reports itself as dm8000 and sink_factory_bcm7405 is used then (more capabilities).

[Erik Slagter]

Oh great Thanks guys, I will include it.

[tension]

root@vuduo:~# cat /proc/stb/info/model
dm8000
 

Yes, you pay for vuduo,  you get dm8000.

[Erik Slagter]

root@vuduo:~# cat /proc/stb/info/model
dm8000

Yes, you pay for vuduo,  you get dm8000.

I wouldn't mind!

[Erik Slagter]

Okay fixed now.

 

Any other patches, requests, etc?

[Erik Slagter]

There are also patches from vu dvbmediasink (in order to play vmw + vma via ffmpeg) http://openpli.org/f...e-5#entry394163

 

Is this what you mean? This removes the file patch file fix_dvbaudiosink_remove_wma.patch! Is that intentional? It it's okay, I will run a testbuild and apply it.

commit 4a5759268ad1f3ff837f5e4f704e7945f92dbeb1
Author: Erik Slagter <erik@openpli.org>
Date:   Fri Jan 17 18:44:54 2014 +0100

    vuplus mediasink: include wma patches from vuplus by athoik.

diff --git a/meta-openpli/recipes-bsp/vuplus/Set-only-by-hardware-supported-audio-mpeg-4-profile.patch b/meta-openpli/recipes-bsp/vuplus/Set-only-by-hardware-supported-audio-mpeg-4-profile.patch
new file mode 100644
index 0000000..a8a65e2
--- /dev/null
+++ b/meta-openpli/recipes-bsp/vuplus/Set-only-by-hardware-supported-audio-mpeg-4-profile.patch
@@ -0,0 +1,27 @@
+From 7ef6975f50de5430bca938ad51d00f19e51a2be1 Mon Sep 17 00:00:00 2001
+From: Athanasios Oikonomou <athoik@gmail.com>
+Date: Thu, 4 Jul 2013 20:12:04 +0300
+Subject: [PATCH 1/1] Set only by hardware supported audio mpeg 4 profile
+
+Only mpeg 4 lc profile is supported by the hardware. Other profiles
+will be decoded by software. Based on betacentauri patches.
+---
+ src/gstdvbaudiosink.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/gstdvbaudiosink.c b/src/gstdvbaudiosink.c
+index 93cb587..2b5fe73 100644
+--- a/src/gstdvbaudiosink.c
++++ b/src/gstdvbaudiosink.c
+@@ -196,7 +196,7 @@ GST_STATIC_PAD_TEMPLATE (
+ X_RAW_INT(24,24)
+ X_RAW_INT(32,24)
+ X_RAW_INT(32,32)
+- "audio/mpeg; "
++ "audio/mpeg, profile = (string) lc; "
+ "audio/x-ac3; "
+ "audio/x-private1-ac3; "
+ "audio/x-dts; "
+-- 
+1.7.9.5
+
diff --git a/meta-openpli/recipes-bsp/vuplus/gst-plugin-vuplus-dvbmediasink/fix_dvbaudiosink_remove_wma.patch b/meta-openpli/recipes-bsp/vuplus/gst-plugin-vuplus-dvbmediasink/fix_dvbaudiosink_remove_wma.patch
deleted file mode 100644
index 8277e8d..0000000
--- a/meta-openpli/recipes-bsp/vuplus/gst-plugin-vuplus-dvbmediasink/fix_dvbaudiosink_remove_wma.patch
+++ /dev/null
@@ -1,28 +0,0 @@
-diff --git a/src/gstdvbaudiosink.c b/src/gstdvbaudiosink.c
-index 15f020f..9b18544 100644
---- a/src/gstdvbaudiosink.c
-+++ b/src/gstdvbaudiosink.c
-@@ -201,8 +201,7 @@ GST_STATIC_PAD_TEMPLATE (
-  "audio/x-private1-ac3; "
-  "audio/x-dts; "
-  "audio/x-private1-dts; "
-- "audio/x-private1-lpcm; "
-- "audio/x-wma")
-+ "audio/x-private1-lpcm")
- );
- 
- static GstStaticPadTemplate sink_factory_broadcom =
-@@ -306,12 +305,7 @@ gst_dvbaudiosink_get_caps (GstBaseSink *basesink)
- // gchar *strcaps;
-  GstCaps *caps;
- 
-- if (hwtype == DM8000 && hwtemplate == &sink_factory_broadcom_dts) {
-- caps = gst_caps_copy(&hwtemplate->static_caps.caps);
-- gst_caps_remove_structure(caps, 11); // remove WMA!!
-- }
-- else
-- caps = gst_static_caps_get(&hwtemplate->static_caps);
-+ caps = gst_static_caps_get(&hwtemplate->static_caps);
- 
- // strcaps = gst_caps_to_string(caps);
- // GST_INFO_OBJECT (self, "dynamic caps for model %d '%s'", hwtype, gst_caps_to_string(caps));
diff --git a/meta-openpli/recipes-bsp/vuplus/gst-plugin-vuplus-dvbmediasink_0.10.bb b/meta-openpli/recipes-bsp/vuplus/gst-plugin-vuplus-dvbmediasink_0.10.bb
index 7680342..4642cfc 100644
--- a/meta-openpli/recipes-bsp/vuplus/gst-plugin-vuplus-dvbmediasink_0.10.bb
+++ b/meta-openpli/recipes-bsp/vuplus/gst-plugin-vuplus-dvbmediasink_0.10.bb
@@ -15,7 +15,7 @@ SRC_URI += " \
  file://fix_dvbaudiosink_async_opt.patch;patch=1;pnum=1 \
  file://fix_dvbvideosink_dm8000_padtemplate.patch;patch=1;pnum=1 \
  file://fix_dvbaudiosink_support_ddp.patch \
- file://fix_dvbaudiosink_remove_wma.patch \
+ file://Set-only-by-hardware-supported-audio-mpeg-4-profile.patch \
 "

 FILES_${PN} = "${libdir}/gstreamer-0.10/*.so"

 

Edited by Erik Slagter, 17 January 2014 - 18:50.

[athoik]

There are also patches from vu dvbmediasink (in order to play vmw + vma via ffmpeg) http://openpli.org/f...e-5#entry394163

 

Is this what you mean? This removes the file patch file fix_dvbaudiosink_remove_wma.patch! Is that intentional? It it's okay, I will run a testbuild and apply it.

commit 4a5759268ad1f3ff837f5e4f704e7945f92dbeb1
Author: Erik Slagter <erik@openpli.org>
Date:   Fri Jan 17 18:44:54 2014 +0100

    vuplus mediasink: include wma patches from vuplus by athoik.

diff --git a/meta-openpli/recipes-bsp/vuplus/Set-only-by-hardware-supported-audio-mpeg-4-profile.patch b/meta-openpli/recipes-bsp/vuplus/Set-only-by-hardware-supported-audio-mpeg-4-profile.patch
new file mode 100644
index 0000000..a8a65e2
--- /dev/null
+++ b/meta-openpli/recipes-bsp/vuplus/Set-only-by-hardware-supported-audio-mpeg-4-profile.patch
@@ -0,0 +1,27 @@
+From 7ef6975f50de5430bca938ad51d00f19e51a2be1 Mon Sep 17 00:00:00 2001
+From: Athanasios Oikonomou <athoik@gmail.com>
+Date: Thu, 4 Jul 2013 20:12:04 +0300
+Subject: [PATCH 1/1] Set only by hardware supported audio mpeg 4 profile
+
+Only mpeg 4 lc profile is supported by the hardware. Other profiles
+will be decoded by software. Based on betacentauri patches.
+---
+ src/gstdvbaudiosink.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/gstdvbaudiosink.c b/src/gstdvbaudiosink.c
+index 93cb587..2b5fe73 100644
+--- a/src/gstdvbaudiosink.c
++++ b/src/gstdvbaudiosink.c
+@@ -196,7 +196,7 @@ GST_STATIC_PAD_TEMPLATE (
+ X_RAW_INT(24,24)
+ X_RAW_INT(32,24)
+ X_RAW_INT(32,32)
+- "audio/mpeg; "
++ "audio/mpeg, profile = (string) lc; "
+ "audio/x-ac3; "
+ "audio/x-private1-ac3; "
+ "audio/x-dts; "
+-- 
+1.7.9.5
+
diff --git a/meta-openpli/recipes-bsp/vuplus/gst-plugin-vuplus-dvbmediasink/fix_dvbaudiosink_remove_wma.patch b/meta-openpli/recipes-bsp/vuplus/gst-plugin-vuplus-dvbmediasink/fix_dvbaudiosink_remove_wma.patch
deleted file mode 100644
index 8277e8d..0000000
--- a/meta-openpli/recipes-bsp/vuplus/gst-plugin-vuplus-dvbmediasink/fix_dvbaudiosink_remove_wma.patch
+++ /dev/null
@@ -1,28 +0,0 @@
-diff --git a/src/gstdvbaudiosink.c b/src/gstdvbaudiosink.c
-index 15f020f..9b18544 100644
---- a/src/gstdvbaudiosink.c
-+++ b/src/gstdvbaudiosink.c
-@@ -201,8 +201,7 @@ GST_STATIC_PAD_TEMPLATE (
-  "audio/x-private1-ac3; "
-  "audio/x-dts; "
-  "audio/x-private1-dts; "
-- "audio/x-private1-lpcm; "
-- "audio/x-wma")
-+ "audio/x-private1-lpcm")
- );
- 
- static GstStaticPadTemplate sink_factory_broadcom =
-@@ -306,12 +305,7 @@ gst_dvbaudiosink_get_caps (GstBaseSink *basesink)
- // gchar *strcaps;
-  GstCaps *caps;
- 
-- if (hwtype == DM8000 && hwtemplate == &sink_factory_broadcom_dts) {
-- caps = gst_caps_copy(&hwtemplate->static_caps.caps);
-- gst_caps_remove_structure(caps, 11); // remove WMA!!
-- }
-- else
-- caps = gst_static_caps_get(&hwtemplate->static_caps);
-+ caps = gst_static_caps_get(&hwtemplate->static_caps);
- 
- // strcaps = gst_caps_to_string(caps);
- // GST_INFO_OBJECT (self, "dynamic caps for model %d '%s'", hwtype, gst_caps_to_string(caps));
diff --git a/meta-openpli/recipes-bsp/vuplus/gst-plugin-vuplus-dvbmediasink_0.10.bb b/meta-openpli/recipes-bsp/vuplus/gst-plugin-vuplus-dvbmediasink_0.10.bb
index 7680342..4642cfc 100644
--- a/meta-openpli/recipes-bsp/vuplus/gst-plugin-vuplus-dvbmediasink_0.10.bb
+++ b/meta-openpli/recipes-bsp/vuplus/gst-plugin-vuplus-dvbmediasink_0.10.bb
@@ -15,7 +15,7 @@ SRC_URI += " \
  file://fix_dvbaudiosink_async_opt.patch;patch=1;pnum=1 \
  file://fix_dvbvideosink_dm8000_padtemplate.patch;patch=1;pnum=1 \
  file://fix_dvbaudiosink_support_ddp.patch \
- file://fix_dvbaudiosink_remove_wma.patch \
+ file://Set-only-by-hardware-supported-audio-mpeg-4-profile.patch \
 "

 FILES_${PN} = "${libdir}/gstreamer-0.10/*.so"

 

 

Ony add Set-only-by-hardware-supported-audio-mpeg-4-profile.patch without removing fix_dvbaudiosink_remove_wma.patch.

 

fix_dvbaudiosink_remove_wma.patch was never released public (it was included in black hole and we had to figure out the code) , but it is requred in order to play wma via ffmpeg.

Edited by athoik, 17 January 2014 - 19:34.