Jump to content


Photo

merge requests for PLi's git


  • Please log in to reply
1748 replies to this topic

Re: merge requests for PLi's git #1001 Persian Prince

  • Senior Member
  • 1,982 posts

+247
Excellent

Posted 13 January 2017 - 17:48

https://github.com/O...nigma2/pull/603

 

Without mts :(


Open Vision sources: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1002 littlesat

  • PLi® Core member
  • 57,233 posts

+701
Excellent

Posted 13 January 2017 - 18:26

Done

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1003 Taapat

  • PLi® Core member
  • 2,345 posts

+121
Excellent

Posted 13 January 2017 - 18:30

@littlesat or do you check what you merge?

Please remove also m2ts: https://github.com/O...cem2ts.cpp#L347

Edited by Taapat, 13 January 2017 - 18:36.


Re: merge requests for PLi's git #1004 Persian Prince

  • Senior Member
  • 1,982 posts

+247
Excellent

Posted 13 January 2017 - 18:40

Sorry that was my mistake :(

I did remove mts but I forgot m2ts.

Fixed with a new merge : https://github.com/O...nigma2/pull/605

:)


Open Vision sources: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1005 Persian Prince

  • Senior Member
  • 1,982 posts

+247
Excellent

Posted 13 January 2017 - 18:53

https://github.com/O...nigma2/pull/606

 

:)


Open Vision sources: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1006 WanWizard

  • PLi® Core member
  • 70,563 posts

+1,816
Excellent

Posted 13 January 2017 - 22:18

Also already merged by Littlesat.


Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Ultimate (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)

Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.

Many answers to your question can be found in our new and improved wiki.


Re: merge requests for PLi's git #1007 Persian Prince

  • Senior Member
  • 1,982 posts

+247
Excellent

Posted 6 February 2017 - 15:44

https://github.com/O...nigma2/pull/631

 

:)


Open Vision sources: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1008 littlesat

  • PLi® Core member
  • 57,233 posts

+701
Excellent

Posted 6 February 2017 - 15:56

Thanks...

But currently we are in a phase of restructuring the builds etc.... so we will 'delay' the commits by approx one week so we ensure we have images during this process without 'interference' of possible 'bad' / incorrect commits....

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1009 Persian Prince

  • Senior Member
  • 1,982 posts

+247
Excellent

Posted 7 February 2017 - 09:47

https://github.com/O...nigma2/pull/631 Updated with the new "enigma2.pot" file and updated po files :)

 

You can merge this because it's about audio/video formats and language updates nothing more.


Open Vision sources: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1010 Taapat

  • PLi® Core member
  • 2,345 posts

+121
Excellent

Posted 7 February 2017 - 12:21

https://github.com/O...nigma2/pull/631 Updated with the new "enigma2.pot" file and updated po files :)

 

Please not merge this!
 
How do you generated these language files?
I have not checked the other language files but you've damaged my lv.po which I generated automatically.
 
You've introducte a line break.
Created unused in enigma translation strings.
Remove used  in enigma translation strings.
Translation is no longer in alphabetical order.
 
Did you check what you offer?

Edited by Taapat, 7 February 2017 - 12:31.


Re: merge requests for PLi's git #1011 Persian Prince

  • Senior Member
  • 1,982 posts

+247
Excellent

Posted 7 February 2017 - 12:59

I'm using Poedit 1.8.7.1

Would you please check these 2 files ?


Open Vision sources: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1012 Taapat

  • PLi® Core member
  • 2,345 posts

+121
Excellent

Posted 7 February 2017 - 14:37

I check in the evening when I'll be home on my Linux computer.
GitHub web does not show so many changes.
 
And you used Poedit 1.8.7.1 to generate a pot file from enigma py and xml files?
Or simply rename one of the po files?


Re: merge requests for PLi's git #1013 Dimitrij

  • PLi® Core member
  • 10,336 posts

+352
Excellent

Posted 7 February 2017 - 14:46

Please do not change the Russian translation, I have too many years spent on it.
To start all over again.


Edited by Dimitrij, 7 February 2017 - 14:47.

GigaBlue UHD Quad 4K /Lunix3-4K/Duo 4K


Re: merge requests for PLi's git #1014 Taapat

  • PLi® Core member
  • 2,345 posts

+121
Excellent

Posted 7 February 2017 - 17:21

@Persian Prince and what exactly do I need to check?

Here is the diff file between my current lv.po, which I have just generated from the enigma and yours.
Also my pot file.
 
Why do you want to change all translation files?
Anyone can generate a pot file from the enigma source codes and merge it with a language file which it wants to update before doing it.
Why you need forced change all language files if they not updated?
And you are doing this wrong.

Attached Files



Re: merge requests for PLi's git #1015 athoik

  • PLi® Core member
  • 8,458 posts

+327
Excellent

Posted 7 February 2017 - 17:27

I think we need a guide how to correctly generate a pot file with all strings.

Better to do this for PLi 5 tough...
Wavefield T90: 0.8W - 1.9E - 4.8E - 13E - 16E - 19.2E - 23.5E - 26E - 33E - 39E - 42E - 45E on EMP Centauri DiseqC 16/1
Unamed: 13E Quattro - 9E Quattro on IKUSI MS-0916

Re: merge requests for PLi's git #1016 Persian Prince

  • Senior Member
  • 1,982 posts

+247
Excellent

Posted 7 February 2017 - 18:11

Everyone just calm down :)
I did close the merge and I'll send a new one regarding audio/video changes only for now.
But we need to have a correct "enigma2.pot" and athoik is right we need a guide too.
All po files should be updated time to time with a correct enigma2.pot so translators could see new strings and remember a translator could be anyone but you can't expect pot creation from everyone ;) You are developers and translators also but Are all translators also developers too ? so try to make things more simple.
As you can see in PLi's git lots of po files don't have the new strings and some of them contain old strings so it means we're not doing good in this part.
Is this important for PLi ? I really don't know the answer but I'm just trying to find a good solution and share it not ruin your translations my friends.

Open Vision sources: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1017 Taapat

  • PLi® Core member
  • 2,345 posts

+121
Excellent

Posted 7 February 2017 - 18:40

Ok, I agree that maybe need to add to the pot file which can be regularly updated.
But I think that the language file updates should be left to those people who are doing it.
I assume that each has its own habits and break them automatically making all po file update would not be correct.


Re: merge requests for PLi's git #1018 mirakels

  • Forum Moderator
    PLi® Core member
  • 7,603 posts

+62
Good

Posted 7 February 2017 - 19:38

Why do we need a enigma2.pot?

Normally the enigma2.pot is generated automatically from the sources

 

For translations we have a specail thread: https://forums.openp...-post-them-here


Geen wonder... Had slechts een dm7000, maar wel ook een rotor. eigenlijk al een tijdje ook een dm600 en dm7025. Maar nu kijkend met een et9000 en vuduo

Re: merge requests for PLi's git #1019 Persian Prince

  • Senior Member
  • 1,982 posts

+247
Excellent

Posted 8 February 2017 - 09:00

https://github.com/O...nigma2/pull/638 Audio/Video changes :)

 

It's safe to merge.


Open Vision sources: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1020 Persian Prince

  • Senior Member
  • 1,982 posts

+247
Excellent

Posted 8 February 2017 - 10:38

I think we need to get rid of these things too : https://github.com/O.../dvbci.cpp#L817

 

And as far as I know it's possible to use po files for cpp files too.


Open Vision sources: https://github.com/OpenVisionE2



4 user(s) are reading this topic

0 members, 4 guests, 0 anonymous users