Jump to content


Photo

merge requests for PLi's git


  • Please log in to reply
1748 replies to this topic

Re: merge requests for PLi's git #1221 Persian Prince

  • Senior Member
  • 1,982 posts

+247
Excellent

Posted 8 July 2018 - 10:11

This would fix it: https://github.com/O...rvicemp3/pull/7

 

It's not just "Update PluginComponent.py" as it's the title, see the info under it: "Remove ancient ".pyc""


Open Vision sources: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1222 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 8 July 2018 - 10:15

Omg..... indeed pp avoid it! Sorry I did not notice it. And indeed pp can make better descriptions... ;) e.g Oe-a colleagues have tons of it and afterwards when something does not work it is extreme difficult to find the cullpit when the comment is just tweak, fix... etc...

Edited by littlesat, 8 July 2018 - 10:19.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1223 Persian Prince

  • Senior Member
  • 1,982 posts

+247
Excellent

Posted 8 July 2018 - 10:20

The fault is mine, sorry.

 

Regarding commit info, I follow github so few words in the title and the rest in extended description, isn't it right?


Open Vision sources: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1224 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 8 July 2018 - 10:22

And now I’m lost... but it looks like Erik wants te remove the previous merge... add a fix for the old white spaces and then make a new commit with the final ‘work’...

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1225 Erik Slagter

  • PLi® Core member
  • 46,951 posts

+541
Excellent

Posted 9 July 2018 - 20:04

I did a revert from github, but apparently it's made into a PR as well, instead of a proper revert. I am not sure what the status is now. Next friday I can investigate.


* Wavefrontier T90 with 28E/23E/19E/13E via SCR switches 2 x 2 x 6 user bands
I don't read PM -> if you have something to ask or to report, do it in the forum so others can benefit. I don't take freelance jobs.
Ik lees geen PM -> als je iets te vragen of te melden hebt, doe het op het forum, zodat anderen er ook wat aan hebben.


Re: merge requests for PLi's git #1226 WanWizard

  • PLi® Core member
  • 68,312 posts

+1,719
Excellent

Posted 9 July 2018 - 20:08

Github does everything via a PR.


Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Pro (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)

Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.

Many answers to your question can be found in our new and improved wiki.


Re: merge requests for PLi's git #1227 Erik Slagter

  • PLi® Core member
  • 46,951 posts

+541
Excellent

Posted 9 July 2018 - 20:12

Lesson learned. For low level corrective actions, use command line as usual.


* Wavefrontier T90 with 28E/23E/19E/13E via SCR switches 2 x 2 x 6 user bands
I don't read PM -> if you have something to ask or to report, do it in the forum so others can benefit. I don't take freelance jobs.
Ik lees geen PM -> als je iets te vragen of te melden hebt, doe het op het forum, zodat anderen er ook wat aan hebben.


Re: merge requests for PLi's git #1228 Persian Prince

  • Senior Member
  • 1,982 posts

+247
Excellent

Posted 25 July 2018 - 10:50

https://github.com/O...e-core/pull/507 :)


Open Vision sources: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1229 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 25 July 2018 - 11:16

Merged.... 


WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1230 Persian Prince

  • Senior Member
  • 1,982 posts

+247
Excellent

Posted 28 July 2018 - 08:42

https://github.com/O...igma2/pull/1658 :)

Attached Files


Edited by Persian Prince, 28 July 2018 - 08:46.

Open Vision sources: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1231 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 28 July 2018 - 12:59

Cannot be accepted... sorry..
There is an if box x then do y in the code
A three line read file... the wierdness openatv does anywhere... making things extra complicated...
There is a missing else that makes the code more readable...
When other boxes do not have a proc chipset just read that one else do what we did -or- tell zgemma to change the procs...

Edited by littlesat, 28 July 2018 - 13:03.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1232 Persian Prince

  • Senior Member
  • 1,982 posts

+247
Excellent

Posted 29 July 2018 - 08:29

https://github.com/O...igma2/pull/1659

 

I thinl it's better now :)


Open Vision sources: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1233 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 29 July 2018 - 08:43

And when you read chipset alternaly later when the previous stuff had no result... then you fix it for other (futer) boxes and you avoid a systeminfo.

Edited by littlesat, 29 July 2018 - 08:46.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1234 rantanplan

  • PLi® Contributor
  • 1,761 posts

+81
Good

Posted 31 July 2018 - 11:28

https://github.com/O...2f8845ffc0d400c

 

After building the image, there is a reboot loop with the Python problem.

Does not seem to hit every box, but maybe someone wants to and looks at it.



Re: merge requests for PLi's git #1235 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 31 July 2018 - 13:05

Can you post the crashlog here.... As far I can see the code you point to should not be related...


WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1236 rantanplan

  • PLi® Contributor
  • 1,761 posts

+81
Good

Posted 31 July 2018 - 18:06

I've written the commit.

Is not an 'official' but Homebuild Image.
However, it is a python error that could possibly hit other official buid as well.

That's why I asked for it.

Lines 285 and 287 in AvSwitch.py ​​are output as crash.



Re: merge requests for PLi's git #1237 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 31 July 2018 - 19:56

Repeat post crashlog... I don’t see what is wrong there...

Edited by littlesat, 31 July 2018 - 19:59.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1238 rantanplan

  • PLi® Contributor
  • 1,761 posts

+81
Good

Posted 31 July 2018 - 21:07

no crashlog, reboot loop

 

log with telnet


openpli homebuild spark7162

spark7162 login: root
root@spark7162:~# init 4
root@spark7162:~# enigma2
PYTHONPATH: /usr/lib/enigma2/python
DVB_API_VERSION 5 DVB_API_VERSION_MINOR 10
ENIGMA_DEBUG_LVL=3
[MAIN] executing main
Traceback (most recent call last):
  File "/usr/lib/enigma2/python/mytest.py", line 545, in <module>
    Components.AVSwitch.InitAVSwitch()
  File "/usr/lib/enigma2/python/Components/AVSwitch.py", line 287, in InitAVSwitch
    config.av.hdmi_audio_source.addNotifier(setHDMIAudioSource)
  File "/usr/lib/enigma2/python/Components/config.py", line 131, in addNotifier
    notifier(self)
  File "/usr/lib/enigma2/python/Components/AVSwitch.py", line 285, in setHDMIAudioSource
    open(SystemInfo["HDMIAudioSource"], "w").write(configElement.value)
TypeError: coercing to Unicode: need string or buffer, bool found
root@spark7162:~#

As I said, yes, is not an official image,
but maybe the mistake is so relevant.



Re: merge requests for PLi's git #1239 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 31 July 2018 - 21:22

I think this is more related to a mistake in the not official image...

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1240 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 31 July 2018 - 21:25

Uuuh you are right fileexists in systeminfo should be filecheck....

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W



1 user(s) are reading this topic

0 members, 1 guests, 0 anonymous users