Jump to content


Photo

merge requests for PLi's git


  • Please log in to reply
1362 replies to this topic

Re: merge requests for PLi's git #1341 littlesat

  • PLi® Core member
  • 49,554 posts

+533
Excellent

Posted 27 July 2019 - 18:18

First thing I can judged and I did merge it.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1342 Persian Prince

  • Senior Member
  • 1,702 posts

+232
Excellent

Posted 5 August 2019 - 13:08

https://github.com/O...e-core/pull/719 (Add FileCommander e2openplugins)


If you like my post click on green arrow :)

 

Open Vision image for your STB: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1343 littlesat

  • PLi® Core member
  • 49,554 posts

+533
Excellent

Posted 5 August 2019 - 13:25

Done...


WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1344 Persian Prince

  • Senior Member
  • 1,702 posts

+232
Excellent

Posted 5 August 2019 - 16:54

https://github.com/O...e-core/pull/720 (packagegroup-openplugins.bb: Add FileCommander)

 

https://github.com/O...e-core/pull/690 [Avoid PAK archive (application/x-pak)]

 

It's safe and if you check OE itself I sent them too and they merged them.

 

https://github.com/O...e-core/pull/687 (DLNAServer & ReadyMedia)

 

You need to squash merge this one, we're using this in Open Vision so tested.


If you like my post click on green arrow :)

 

Open Vision image for your STB: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1345 WanWizard

  • Forum Moderator
    PLi® Core member
  • 49,031 posts

+841
Excellent

Posted 5 August 2019 - 17:33

Done.


Currently in use: VU+Duo 4K (2xFBC S2), Amiko Viper T2C (T2), SAB Alpha Triple HD (S2+T2), Zgemma H3.T2C (T/C), Zgemma H6 (fallback), VU+Zero (fallback)

Many answers to your question can be found in our new and improved wiki.

note: I do not provide support via PM !

 


Re: merge requests for PLi's git #1346 Persian Prince

  • Senior Member
  • 1,702 posts

+232
Excellent

Posted 26 August 2019 - 10:06

https://github.com/O...e-core/pull/728 (Don't hardcode path)


If you like my post click on green arrow :)

 

Open Vision image for your STB: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1347 Persian Prince

  • Senior Member
  • 1,702 posts

+232
Excellent

Posted 2 September 2019 - 13:09

https://github.com/O...igma2/pull/2252


If you like my post click on green arrow :)

 

Open Vision image for your STB: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1348 Persian Prince

  • Senior Member
  • 1,702 posts

+232
Excellent

Posted 6 September 2019 - 01:03

JFI still there are some "os.system" in enigma2 instead of "Console.ePopen":

 

https://github.com/O...ter/main.py#L21

 

https://github.com/O...arddisk.py#L242

https://github.com/O...arddisk.py#L247

https://github.com/O...arddisk.py#L273

https://github.com/O...arddisk.py#L279

 

https://github.com/O...ageInfo.py#L370


If you like my post click on green arrow :)

 

Open Vision image for your STB: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1349 littlesat

  • PLi® Core member
  • 49,554 posts

+533
Excellent

Posted 6 September 2019 - 06:49

Terrible... should indeed be fixed... can you help?

Edited by littlesat, 6 September 2019 - 06:49.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1350 littlesat

  • PLi® Core member
  • 49,554 posts

+533
Excellent

Posted 6 September 2019 - 08:48

The first one is not running in E2....


WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1351 littlesat

  • PLi® Core member
  • 49,554 posts

+533
Excellent

Posted 6 September 2019 - 09:06

FYI

https://github.com/O...f582dcb72f05446


WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1352 Persian Prince

  • Senior Member
  • 1,702 posts

+232
Excellent

Posted 15 September 2019 - 15:03

https://github.com/O...igma2/pull/2274 [Harddisk.py: Replace missing os.system with Console().ePopen]

 

What about these kind of calls which are in enigma2-plugins:

os.system("cp /tmp/bouquet/"+item[1]+" /etc/enigma2/"+item[1])
os_system("cp '%s' '%s'" %(target[1],plugin_path+"/"+file))
os.system("echo "+ choice[1] +" > /tmp/.webselect | wget -O /tmp/index.html "+ radirl +""+ choice[1])
os.system("wget -O '"+ mcpath +"radio/"+ selection[1] +"' '"+ radirl +""+ gen[0] +""+ selection[1].replace(" ", "%20") +"'")
os.system("echo '"+ str(title) +"' > /tmp/.oldplaying | echo '"+ str(title) +"' > /tmp/.curplaying ")
os.system("echo '"+ str(title) +"' > /tmp/.curplaying")

What's the correct form?


Edited by Persian Prince, 15 September 2019 - 15:04.

If you like my post click on green arrow :)

 

Open Vision image for your STB: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1353 littlesat

  • PLi® Core member
  • 49,554 posts

+533
Excellent

Posted 15 September 2019 - 15:08

Replace them by Console.ePopen and then instead of building the command with + try using %s instead.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1354 Persian Prince

  • Senior Member
  • 1,702 posts

+232
Excellent

Posted 15 September 2019 - 15:13

Yeah I know that but isn't it just ugly to have so many hardcoded things like "/tmp/.oldplaying" or "/tmp/.curplaying" which we can define them once in the plugin.


If you like my post click on green arrow :)

 

Open Vision image for your STB: https://github.com/OpenVisionE2


Re: merge requests for PLi's git #1355 littlesat

  • PLi® Core member
  • 49,554 posts

+533
Excellent

Posted 15 September 2019 - 15:17

E.g.

 

-os.system("wget -O '"+ mcpath +"radio/"+ selection[1] +"' '"+ radirl +""+ gen[0] +""+ selection[1].replace(" ", "%20") +"'")
+Consile().ePopen("wget -O '$sradio/%s' '$s%s%s'" % (mcpath, selection[1], radirl, gen[0], selection[1].replace(" ", "%20") ))

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1356 littlesat

  • PLi® Core member
  • 49,554 posts

+533
Excellent

Posted 15 September 2019 - 15:19

os.system("echo '"+ str(title) +"' > /tmp/.curplaying")
 
->
 
Console().ePopen("echo '%s' >/tmp/.curplaying" % str(title))

Console().ePopen("echo '%s' >%s" % (str(title), self.TMP_CUR_PLAYING)) ??


Edited by littlesat, 15 September 2019 - 15:20.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1357 athoik

  • PLi® Core member
  • 7,924 posts

+295
Excellent

Posted 15 September 2019 - 19:35

ePopen/os.system to spawn a shell in order to echo something and redirect this to a file?

What happened to old good open(x).write(y)??

Finaly those os.system calls most probably are not sanitized, so a special command can be created to take over control of the box.



Just replacing os.system with ePopen is not making things way more efficient.

Also plugins relaying on blocking behavior of system call with fail once switch to ePopen.
Wavefield T90: 0.8W - 1.9E - 4.8E - 13E - 16E - 19.2E - 23.5E - 26E - 33E - 39E - 42E - 45E on EMP Centauri DiseqC 16/1
Unamed: 13E Quattro - 9E Quattro on IKUSI MS-0916

Re: merge requests for PLi's git #1358 littlesat

  • PLi® Core member
  • 49,554 posts

+533
Excellent

Posted 15 September 2019 - 19:39

...

Edited by littlesat, 15 September 2019 - 19:40.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1359 littlesat

  • PLi® Core member
  • 49,554 posts

+533
Excellent

Posted 15 September 2019 - 19:41

Also for copy you have funtions in the python library... looks like these plug-ins are badddddd
Also for wget you can use urllib ot twisted

Edited by littlesat, 15 September 2019 - 19:42.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: merge requests for PLi's git #1360 Dimitrij

  • PLi® Core member
  • 6,582 posts

+212
Excellent

Posted 16 September 2019 - 05:15

res = Console().ePopen(cmd)

 

 

please test

ePopen not answer

res = os.system(cmd)

 

return (res >> 8)


Lunix3-4K/VU+solo4k(thanks guys to gisclub.tv)





0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users