187 replies to this topic

[littlesat]

I'm not able to commit the patch (anymore...) it gives me a patch format detection failed message....

Edited by littlesat, 24 May 2013 - 20:52.

[Dimitrij]

patch

Maybe someone from the developers openPli support my patch?
In my opinion, it is very convenient .

Edited by Dima73, 22 August 2013 - 11:10.

[Dimitrij]

+

GME

[littlesat]

There are already so many picons... I suggest we could keep it as is... When it is recorded you get a watch - that's important.

But that is my meaning..... but I do not know how others do think about this?

 

 

+ if rec[2]:
+   return self.zap_clocks[rec[1]]
+ else:
+   return self.clocks[rec[1]]

 

+   return rec[2] and self.zap_clocks[rec[1]] or self.clocks[rec[1]]

Edited by littlesat, 22 August 2013 - 12:45.

[Dimitrij]

1)The total of these five icons only 2 450 bytes.

http://openpli.org/f...attach_id=52683

2)I believe that it is important for the user to see what this type of timer.
Moreover, that add such a possibility is not difficult.

 

P.S.Request to users of PLi to support me .

[littlesat]

Can you suggest the one liner solution

Sorry sometimes suggestions get "oversnowed" by "time"

Edited by littlesat, 22 August 2013 - 16:21.

[Dimitrij]

The problem is that I'm trying to do it for all users.
With me it works for about 4 months and I find it very convenient.

P.S.Sooner or later you'll realize it themselves .

[littlesat]

I did some more investigation... but the patch is not complete... we should have a complete .patch file with a complete commit. With what is delivered now we must add all stuff manually.

[littlesat]

And do we really need 5 different picons.... I suggest for the just play only one icon is required (and we can make it type 5).

[Dimitrij]

I did some more investigation... but the patch is not complete... we should have a complete .patch file with a complete commit. With what is delivered now we must add all stuff manually.

You are a professional in enigma2.
Please make the complete .patch
 I honestly do not know how to do it.

 

P.S.This is my personal request.

[littlesat]

How te deliver a good patch file can be found on the forum...

Just a question... Do you ever see the half time zap picons? Or only the full one?

How te deliver a good patch file can be found on the forum...

Just a question... Do you ever see the half time zap icon? Or only the full one? As i have the feeling we need only one additional icon

Edited by littlesat, 23 August 2013 - 17:07.

[Dimitrij]

Just a question... Do you ever see the half time zap icon? Or only the full one? As i have the feeling we need only one additional icon

Seen.
Time for timers are different.
It is necessary to consider all the options.
But if there is only one icon, and it will be good.

[littlesat]

Done... The only thing i'm scared of is it might break cool epg or so I currently realize.. But i suggest our own gmepg is almost as good.

Edited by littlesat, 23 August 2013 - 19:25.

[Dimitrij]

Done... The only thing i'm scared of is it might break cool epg or so I currently realize.. But i suggest our own gmepg is almost as good.

Thank you very much

[Dimitrij]

step 2...

 

-added duration in Single EPG(see screenshot Single_epg.jpg)

-added duration and days of the week in  Multi EPG(see screenshot Mutli_epg.jpg)

 

Needs some editing skins PLi-HD:

skin.xml

 

  <screen name="EPGSelectionMulti" title="EPG Selection" position="fill" flags="wfNoBorder">

<widget name="list" position="520,165" size="760,450" itemHeight="30" backgroundColor="background" transparent="1" scrollbarMode="showOnDemand" selectionPixmap="PLi-HD/buttons/sel.png" />

 

  <screen name="EPGSelection" position="fill" flags="wfNoBorder">

 <widget name="list" position="530,110" size="750,510" itemHeight="30" transparent="1"  scrollbarMode="showOnDemand"  selectionPixmap="PLi-HD/buttons/sel.png" />

[littlesat]

Is that duration really required when you already have the start and stop time? I suggest this gives too much info...

[Dimitrij]

Is that duration really required when you already have the start and stop time? I suggest this gives too much info...

A matter of taste.
In my opinion it's more convenient.

[ims]

1) Could be rebuilded icons for ZAP timer ? F.eg. full color for BOLD  "Z" and little smaler "Z" and not transparency color for "Z" and so big "Z" ? It is not known, what this icon tells

2) If there are added icons for ZAP, why arent icons for "ZAP and Record" too ?

 

Or modify old icons f.eg - Clock with:

Timer ... whole RED background, 

ZAP ... GREEN background

Zap+Record ... YELLOW background  (or horizonzaly - 1/2 green, 1/2 red.

[littlesat]

A matter of taste.
In my opinion it's more convenient.

That is why this should be configurable...and there is already too much configurable. I suggest durations is nice... but it gives you more info on already a screen with a lot of info... and the nicest EPG is already the GMEPG.

 

@IMS,

Do I see a patch coming from you...

Edited by littlesat, 25 August 2013 - 12:08.

[ims]

1) There is bug imho. When is created record timer with time before and time after event and onr zap timer, then for record timer are changed icons epgclock_pre/_post to zapclock_add. When is Zap timer erased, then are changed icons for Record timer back to true icons.

 

2) I think, _pre and _post picons ( for zapclock_, but for epgclock_ too) are swapped. Full collor in this divided icons = recording => it could be as it is on my.jpg and not as it is on orig.jpg

 

Here are example with orig. icons and with my alternative. First timer is REC timer ( there is bug 1), second is ZAP timer ( here is visible nonsence in colors)

 

Attached are icons for better visibility with testing.

Attached Files

•  orig.jpg   59.26KB   61 downloads
•  my.jpg   55.54KB   63 downloads
•  timer_zapclock_icons.tar.gz   1.24KB   3 downloads

Edited by ims, 25 August 2013 - 14:33.