187 replies to this topic

[littlesat]

Then I suggest to make the zap timer icons green... and use "gray-green" for the event that is not fully recorded...

And with the record it can be red... and zap+record could be yellow...

[ims]

here it is... for zap+rec are icons zaprecclock in yellow.

 

What the bugs ?

Attached Files

•  zap_rec_epg_clock.tar.gz   1.98KB   3 downloads

[Dimitrij]

Zap+Record ...  horizonzaly - 1/2 green, 1/2 red.

+1

[ims]

About bug.

 

when I create REC timer with some timer margins and I debug in Epglist.py rec[1], it is: 1, 2, 4. But after creating ZAP timer it is changed to 5 2 5 7.

Edited by ims, 25 August 2013 - 16:56.

[ims]

Create REC timer with later start and earlier stop. It is ok. Then on next item create standard REC timer => next bug: is hiden icon for previous created timer.

[ims]

it seems, there are missing "break" in RecordTimer.py in isInTimer() always, when is increased "type". And set type=0 before test for x.justplay. Thats all. Tomorrow I will put patch (for zap+rec too)

Edited by ims, 25 August 2013 - 22:04.

[littlesat]

Type= 0 is there...
But i"ll wait for an complete patch...

Edited by littlesat, 25 August 2013 - 23:02.

[ims]

Type= 0 is there...
 

yes, but there is loop for looking timers event.

 

Here is patch - fix bugs and added zap&record picons into epg/gmepg, modified icons too.

Red, Green, Yellow, as you wrote.

 

@Dima73 - on so small icon is ugly horizontaly green/red, when is 1/2 gray. Later we could create whole new icons...

Attached Files

•  0001-fixed-displaying-timers-icons-in-epg.patch.tar.gz   8.67KB   7 downloads

Edited by ims, 26 August 2013 - 08:48.

[littlesat]

I would recommend to change this a bit.. Please note that type = 0 is set higher in the code.... so that is not required here.

- if x.justplay:+ type = 0+ if x.justplay or x.always_zap: type = 5+ if x.always_zap:+ type = 10

if check: timer_end = x.end +if x.always_zap: +type = 10 if x.justplay: type = 5 if (timer_end - x.begin) <= 1: timer_end += 60

Edited by littlesat, 26 August 2013 - 10:52.

[ims]

no, it must be here set to 0 ( and must not be higher in the code ). There is looking type in loop and then next looking starting with previous type value.

Edited by ims, 26 August 2013 - 10:57.

[littlesat]

Few... Then another type = 0 should be removed....?

The i suggest we even better can go for a if , elsif, else construction...

Edited by littlesat, 26 August 2013 - 11:06.

[Dimitrij]

littlesat

First of all, thank you.

 

The second ...

Can not be stopped on the search icon, if there is now support for multi icons EpgList?

				if time_match:
					#if type in (2,7,12): # When full recording do not look further
					#	returnValue = (time_match, [type])
					#	break
					if returnValue:
						if type not in returnValue[1]:
							returnValue[1].append(type)
					else:
						returnValue = (time_match, [type])

[littlesat]

Sorry I do not understand?

 

indeed an event can have multiple clock icons now... and when an event is compeletely recorded I suggest we do not need multiple icons... But if you see a way that I overseen something then please notify me as this get's really complicated.

 

I just did another commit as I forget to modify the simultanious event list and Multi epg to adapt

Edited by littlesat, 28 August 2013 - 20:16.

[ims]

Dima73 talking about rem this lines => will be visible all icons. I think, it could be better.

Edited by ims, 28 August 2013 - 20:20.

[littlesat]

It still has some complication in the GMEPG I need to investigate.

And I thought when there is a full recording it looks more quit... Then it is not important anymore when a recording is half reported...

I tried to arrange that you only get those double icons as it is "really required".

Edited by littlesat, 28 August 2013 - 20:37.

[Dimitrij]

same service

event1 12.00-13.00

event2 13.00-14.00

timer--> event1 record start=12.00, end=13.20

timer--> event2 zap start=13.00, end=14.00

 

in EpgList only zap icon for event2...

Edited by Dima73, 29 August 2013 - 05:47.

[ims]

strange. Tried and works.

 

event 1:  13:55-14:45

event 2:  14:45-15:50

 

T1 rec: 13:55-15:10

T2 zap: 14:45-15:50

 

and there are RED for T1 and GREEN for T2.

Edited by ims, 29 August 2013 - 07:20.

[littlesat]

                if time_match:
                    #if type in (2,7,12): # When full recording do not look further
                    #    returnValue = (time_match, [type])
                    #    break
                    if returnValue:
                        if type not in returnValue[1]:
                            returnValue[1].append(type)
                    else:
                        returnValue = (time_match, [type])

I will look later into this one... but at least I want to avoid that when you have a full event recording that you also see end- and begin- clocks in the same color...

So in short a fix will come I need to think about about the best way to do this.

Edited by littlesat, 29 August 2013 - 09:35.

[Dimitrij]

strange. Tried and works.

 

event 1:  13:55-14:45

event 2:  14:45-15:50

 

T1 rec: 13:55-15:10

T2 zap: 14:45-15:50

 

and there are RED for T1 and GREEN for T2.

+

T2 zap: 14:45-15:50 -->Set end time=yes

[littlesat]

Te biggest question is should i go so far that i give two picons here when one is zapped and the previous is fully recorded?