53 replies to this topic

[betacentauri]

You cannot loose timeshift after jumping to live point if you are using the timeshift running check. Then you get a "Stop timeshift?" message box.

2-3 seconds should be enough for normal recordings. For a radio recording perhaps some seconds more.

[betacentauri]

The from dima73 provided source code is from my point of view to complex.

Isn't this enough?

 

diff --git a/lib/python/Screens/InfoBarGenerics.py b/lib/python/Screens/InfoBarGenerics.py
index 12602c8..3cbc6bf 100644
--- a/lib/python/Screens/InfoBarGenerics.py
+++ b/lib/python/Screens/InfoBarGenerics.py
@@ -1260,6 +1260,12 @@ class InfoBarSeek:
                                self.setSeekState(self.SEEK_STATE_PAUSE)
                        else:
                                self.setSeekState(self.SEEK_STATE_PLAY)
+
+               # don't seek past eof to prevent stopping playback of a still running recording
+               remaining = self.calcRemainingTime()
+               if remaining - 3000 < pts / 90 and pts > 0:
+                       pts = (remaining - 3000) * 90
+
                seekable.seekRelative(pts<0 and -1 or 1, abs(pts))
                if abs(pts) > 100 and config.usage.show_infobar_on_skip.value:
                        self.showAfterSeek()

It works for recordings and also for timeshift. In case of timeshift you cannot switch to live point via seeking any more. But it still works via stop button. That's ok for me.

 

Do we need to change __evEOF function? For what?

[betacentauri]

Here is the patch

Attached Files

•  0001-Prevent-seeking-past-eof-while-watching-a-running-re.patch.txt   1.19KB   2 downloads

[sirdir]

I'll try that tomorrow, thank you

 

getting a 'stop timeshift' message when you're just trying to jump over some advertisement is annoying, too ,) 

I think enigma2 has too many 'modal' message boxes anyway... (that prevent you from doing what you just wanted to do.. you have to wait until they go away or you have to exit them)

[littlesat]

Is it ok i wait for feedback?

[sirdir]

I'll need some more time than I thought - (this is embarrassing ,) ) - I tested OpenPLI some weeks ago on the solo2 of a friend and found this feature missing, but I bought a duo2 and just learned that there isn't an OpenPLI image for that receiver yet.

I can test it on a dreambox but that'll take some more time.

 

Sorry

 

Regards

Patrick

[dirocca]

I'll need some more time than I thought - (this is embarrassing ,) ) - I tested OpenPLI some weeks ago on the solo2 of a friend and found this feature missing, but I bought a duo2 and just learned that there isn't an OpenPLI image for that receiver yet.

I can test it on a dreambox but that'll take some more time.

 

Sorry

 

Regards

Patrick

for the duo2 you can use openATV it´s an openpli based image

 

grtz Philip

[sirdir]

I'll need some more time than I thought - (this is embarrassing ,) ) - I tested OpenPLI some weeks ago on the solo2 of a friend and found this feature missing, but I bought a duo2 and just learned that there isn't an OpenPLI image for that receiver yet.

I can test it on a dreambox but that'll take some more time.

 

Sorry

 

Regards

Patrick

for the duo2 you can use openATV it´s an openpli based image

 

grtz Philip

I'll have a look at that. Right now I'm flashing a 7020HD to be able to give a feedback

 

PS: Had a quick look, I only see an image for the duo...

Edited by sirdir, 15 July 2013 - 12:44.

[betacentauri]

There were some other guys (satkiekerd, robinson,...) who wanted to have that feature. Perhaps they can test too...

[sirdir]

Erm, so I need to set up a complete development enviroment to apply this patch? I thought there's a InfoBarGeneric.py in the image, but theres' only a pyo, so I need to patch in the git? 

Never compiled OpenPLI before, I'll see wether I manage to do that in a reasonable time.

[dirocca]

ge

 

 

I'll need some more time than I thought - (this is embarrassing ,) ) - I tested OpenPLI some weeks ago on the solo2 of a friend and found this feature missing, but I bought a duo2 and just learned that there isn't an OpenPLI image for that receiver yet.

I can test it on a dreambox but that'll take some more time.

 

Sorry

 

Regards

Patrick

for the duo2 you can use openATV it´s an openpli based image

 

grtz Philip

I'll have a look at that. Right now I'm flashing a 7020HD to be able to give a feedback

 

PS: Had a quick look, I only see an image for the duo...

off topic

regarding openatv don´t use todays image seems to be a problem(image is still new )

image off yesterday works perfectly

 

http://images.mynonp...0130714_usb.zip

 

 

grtz Philip

[sirdir]

Hm, won't be able to set that up right now, I get

 

git clone git://openpli.git.sourceforge.net/gitroot/openpli30/openpli-oe-core

Cloning into 'openpli-oe-core'...

 

fatal: The remote end hung up unexpectedly

 

… maybe somebody that has the build enviroment could upload the .pyo?

 

Regards

Patrick

[betacentauri]

Here's the correct command:

git clone git://git.code.sf.net/p/openpli/enigma2

 

But you only need to download latest InfoBarGenerics.py and you don't have to set up the build environment.

Here's the py:

http://sourceforge.n...s.py?format=raw

 

Here's a little howto (I don't know how much experiences you have):

1. Make a backup of the pyo file. E.g. cp /usr/lib/enigma2/python/Screens/InfoBarGenerics.pyo /hdd/

2. Apply changes to InfoBarGenrics.py

3. Copy InfoBarGenrics.py file to /usr/lib/enigma2/python/Screens/

4. Restart E2.

 

If you have problems delete InfoBarGenrics.py and copy backup back to the /usr/lib/enigma2/python/Screens/ directory.

[sirdir]

Here's the correct command:

git clone git://git.code.sf.net/p/openpli/enigma2

 

But you only need to download latest InfoBarGenerics.py and you don't have to set up the build environment.

Here's the py:

http://sourceforge.n...s.py?format=raw

 

Here's a little howto (I don't know how much experiences you have):

1. Make a backup of the pyo file. E.g. cp /usr/lib/enigma2/python/Screens/InfoBarGenerics.pyo /hdd/

2. Apply changes to InfoBarGenrics.py

3. Copy InfoBarGenrics.py file to /usr/lib/enigma2/python/Screens/

4. Restart E2.

 

If you have problems delete InfoBarGenrics.py and copy backup back to the /usr/lib/enigma2/python/Screens/ directory.

Maybe it's better if somebody has a look at it that is using OpenPLI on his main receiver already, but I tried the patch for some minutes and it looks quite OK.

I was able to 'fall out' of the Recording when wildly jumping around, but I guess that could even happen in OE2.0… I think it works good enough!

 

Thank's to everybody that participated in this

Will this go in the official feed eventually?

[sirdir]

off topic

regarding openatv don´t use todays image seems to be a problem(image is still new )

image off yesterday works perfectly

 

http://images.mynonp...0130714_usb.zip

 

 

grtz Philip

Is the InfoBarGenerics the same as in OpenPLI or do I need to get the source of the openatv version and patch that again?

[dirocca]

i think the source is the same as openpli

if i press stop in timeshift i get this:(sorry in dutch)

 screenshot.jpg   75.36KB   19 downloads

 

also PLI-HD skin:

 screenshot1.jpg   115.5KB   17 downloads

 

grtz Philip

 

 

[betacentauri]

The sources from openatv and openpli are similar but I think they are not equal.

You see the message box when you press the stop button? Do you use latest openpli image? There was a change that the stop button only switches to live point but does not stop timeshift. So that is strange.

[sirdir]

I did get that message in the (patched) OpenPli as well… And I thought that's OK

 

I tried openATV but it didn't work. First time I updated by error so I thought that's the problem but on the next try I had the same problem. Maybe the .py isn't compatible after all.

I'm going back to ITV for the time being and when there's an OpenPLI for the DUO2 I'll give that a try again

[dirocca]

The sources from openatv and openpli are similar but I think they are not equal.

You see the message box when you press the stop button? Do you use latest openpli image? There was a change that the stop button only switches to live point but does not stop timeshift. So that is strange.

my screenshots in post 36 are taken in openatv3.0 (vuduo2) with PLI-HD skin

 

grtz Philip

[dirocca]

I did get that message in the (patched) OpenPli as well… And I thought that's OK

 

I tried openATV but it didn't work. First time I updated by error so I thought that's the problem but on the next try I had the same problem. Maybe the .py isn't compatible after all.

I'm going back to ITV for the time being and when there's an OpenPLI for the DUO2 I'll give that a try again

use link in post 31 and flash with usb

works perfectly

 

grtz Philip