←  [EN] Third-Party Development

Forums

»

InputDeviceSetup

Dimitrij's Photo Dimitrij 23 Oct 2013

Skin 'skin_default'

See screenshot.


Edited by Dima73, 23 October 2013 - 18:41.
Quote

Dimitrij's Photo Dimitrij 24 Oct 2013

-		self["config"].l.setSeperation(400)
+		self["config"].l.setSeperation(600)

 

?????

InputDeviceSetup size 560
Quote

littlesat's Photo littlesat 24 Oct 2013

This was done for greek characters... probably we need to revert this... :D

 

http://sourceforge.n...f9580df547969b/

Quote

MCelliotG's Photo MCelliotG 24 Oct 2013

The problem was in HD skins in general, not the translations! There is not enough space and the progress bar was overlayed on the characters! Besides who uses the default skin anymore...

Quote

MCelliotG's Photo MCelliotG 24 Oct 2013

I think 560 would be cool unless the whole sd skin code in the plugin should be changed!

Quote

littlesat's Photo littlesat 24 Oct 2013

Do I see a patch coming on 560? i suggest the size is 560 so this is still too big.


Edited by littlesat, 24 October 2013 - 13:35.
Quote

athoik's Photo athoik 24 Oct 2013

This is not happening only on Greek languange, but on other languages too.

 

I see two possible solutions.

 

1. Use size 500 (might not be enouph in some case)

 

2. Change default skin size

 

What do you think?

Quote

littlesat's Photo littlesat 24 Oct 2013

I would suggest to change the translation so it will fit....
Quote

athoik's Photo athoik 24 Oct 2013

This is so "Procrustean"...

 

In Greek mythology, Procrustes (Προκρούστης) or "the stretcher [who hammers out the metal]", also known as Prokoptas or Damastes (Δαμαστής) "subduer", was a rogue smith and bandit from Attica who physically attacked people by stretching them or cutting off their legs, so as to force them to fit the size of an iron bed. In general, when something is Procrustean, different lengths or sizes or properties are fitted to an arbitrary standard.

http://en.wikipedia....wiki/Procrustes

Quote

Dimitrij's Photo Dimitrij 24 Oct 2013

self["config"].l.setSeperation(500)

Edited by Dima73, 24 October 2013 - 19:43.
Quote

athoik's Photo athoik 24 Oct 2013

Hopefully 500 is not causing problems to SD skins.


Attached File  0001-Change-InputDeviceSetup-Length-to-500.patch.txt   892bytes   4 downloads

Quote

MCelliotG's Photo MCelliotG 25 Oct 2013

I would suggest to change the translation so it will fit....

So should the French, Polish, Italian and any other translator whose language has big words, English is not the only language and when someone codes a plugin which limits the skinners from taking over (the configlist cannot be changed on custom skins, even if you set enough space, the distance between the text and the progress bar is fixed and set by the seperation value), they should this take into consideration! In some languages if you cut words off the meaning is completely changed!

Anyway the 500 value still overlaps but not that much, 560 would be ideal, but changing the default sd window size to 600 would be even better!

Quote

littlesat's Photo littlesat 25 Oct 2013

Sometimes you should translate smart...

Quote

mirakels's Photo mirakels 25 Oct 2013

Hardcoded values are always bad. Pushed a change so 20% of the space is used for the sliders and 80% for the description.

 

(see http://openpli.org/f...icesetup-lenght for first mentioning of the space issues).

Quote

littlesat's Photo littlesat 25 Oct 2013

This is indeed the best suggestion... But it needs code change...
Quote

mirakels's Photo mirakels 25 Oct 2013

This is indeed the best suggestion... But it needs code change...

???

Quote

littlesat's Photo littlesat 25 Oct 2013

I meant make it relative...
Quote

littlesat's Photo littlesat 25 Oct 2013

Sorry as I did not saw the code was already made...
Quote