104 replies to this topic

[betacentauri]

Hi together,

 

I'm working on a teletext improvement (most likely on Monday you get more informations ).

 

But I have a little problem:

In lib/components/tuxtxtapp.cpp I see this:

int eTuxtxtApp::startUi()
{
	if (fbClass::getInstance()->lock() >= 0)
	{
  ...

So I guess that the "e2" framebuffer should be locked and the teletext should get exclusive access to the framebuffer (the same for the LCD and the remote). So only the teletext should be displayed in the OSD nothing else.

But the teletext don't get exclusive access to framebuffer. E.g. for subtitles Littlesat has build a workaround in the plugin to hide the subtitles (http://sourceforge.n...lugin/plugin.py):

...
self.subtitle = infobar and infobar.selected_subtitle
if self.subtitle:
   infobar.enableSubtitle(None) 
...

Am I wrong with the exclusive access? Or is it a bug?

Edited by betacentauri, 23 November 2013 - 16:24.

[pieterg]

the subtitle rendering is probably missing a

m_dc->islocked()

check.
Each painter / dc operation is checking the lock, it seems.
That's how the issue should have been fixed I think.

[littlesat]

Good point pieterg.... I just did stop the subtitles and re-enable them again a few months ago due to the reported wide effectes when subs were running and tuxtxt was opened... I nether thought about this....

[betacentauri]

When teletext is enabled, you cannot use e.g. volume keys and you cannot mute. Also reassigning keys is difficult, because it has to be done in C code. I don't like that.
So I'am writing a patch to enable that. I have deleted the line
eRCInput::getInstance()->lock();
in tuxtxtapp.cpp so that the "e2" remote still works. Then I added a section to keymap.xml and added a ActionMap to tuxtxt plugin. The plugin then sends the keys to the tuxtxt C part.
That all works, but when I now press volume up/down I see artifacts on the screen. I guess that the volume bar is still displayed and causes the artifacts. The same applies to mute button or other not assigned buttons.
So I think that the isLocked check is missing somewhere...

I try to post the patches tomorrow.

Edited by betacentauri, 23 November 2013 - 23:08.

[theparasol]

Just a request since you are now working on teletext, a part my wife uses all day. She complains about the auto advancing of subpages (1/6 -> 2/6 -> 3/6 -> 4/6 -> 5/6 -> 6/6)

Is it possible to shut this auto advance off, its very annoying: you are reading and all of sudden: next page. shifting between pages with <- and -> is much more comfortable while reading!

 

Regarding to the artifacts: if teletext is on and my server is querying the box the spinners start to turn for quite some time. Those busy spinners are also causing artifacts. Perhaps an additional pointer where to look for cause of these artifacts. 

[littlesat]

The advanced subtitle is intended and part of teletext. Once you select a subtitle manually it will not advance anymore.

[Rob van der Does]

When teletext is enabled, you cannot use e.g. volume keys and you cannot mute.

So I'am writing a patch to enable that.

Does that mean that the Teletext-functions that were assigned to Volume Up/Down and mute no longer work?
Or are they going to be assigned to other buttons?

[betacentauri]

With the patch you can assign every teletext functionality to almost every button you like.
I guess volume up/down is currently screen mode switching and zoom. This still works with my patch.

[littlesat]

But it does both then... zoom and modeswitch + volume and mute.... and changing volume and mute destroys the teletext OSD.

Edited by littlesat, 24 November 2013 - 09:07.

[betacentauri]

Yes, but destroys is a little bit overstated. You see some artifacts on screen which disappear after a few seconds. So it isn't very bad but also not very nice.
Unfortunately I'm not really familiar with gdi part. I hope someone can help finding the problem.

[littlesat]

When using a button for tuxtxt you should arrange that in addition the volume/mute is changed as well....

[MiLo]

Another approach would be to get rid of the framebuffer lock, and have tuxtxt render into its own off-screen pixmap. Then blit that to the main screen whenever needed. The blit operation is hardware assisted, and won't noticably slow things down.

This would also allow teletext to be rendered 'anywhere' on screen.

[pieterg]

Agreed, that sounds like a more generic aproach.
One which also allows OSD-over-teletext, and more such effects.

[betacentauri]

Who has time for it

[pieterg]

It wouldn't actually require that any changes in the tuxtxt render routine.
'just' a flag which signals e2 that an updated frame is available.
However, the pan could be removed as well, saving 50% of the framebuffer memory, as updates are always applied on a back-buffer. Now that means rather big changes in the render routines...

[betacentauri]

If somebody wants to test, here are the files.

Warning: It's a little bit difficult to test. At best make a backup before test and afterwards flash back backup.

If you don't want to do it, you should know what you are doing!!! Make backup of enigma.pyo, keymap.xml, libtuxtxt.so.0.0.0, libtuxtxt32bpp.so.0.0.0, plugin.pyo and move the files back to original place after test (and delete the new py files).

 

Unzip the files and copy them to:

enigma.py to /usr/lib/enigma2/python/

keymap.xml to /usr/share/enigma2/

libtuxtxt.so.0.0.0 to /usr/lib/

libtuxtxt32bpp.so.0.0.0 to /usr/lib/

plugin.py to /usr/lib/enigma2/python/Plugins/Extensions/Tuxtxt/
 

Then start included enigma2 (not the installed one)!

 

Patches will follow in a few minutes.

Attached Files

•  teletext.zip   995.09KB   40 downloads

[betacentauri]

Here are the patches. One against tuxtxt git and one against enigma2 git.

 

Please don't commit it immediately! Other teams are using your tuxtxt git and if they are using the latest tuxtxt version without the e2 patch, teletext won't work! So please take a look at the patches and if they are fine, I'll inform some teams so that they have a change to apply the patch too.

 

Attached Files

•  enigma2_git_0001-Teletext-improvements.patch.txt   3.28KB   30 downloads
•  tuxtxt_git_0001-Teletext-improvements.patch.txt   7.16KB   23 downloads

[betacentauri]

Did somebody look at my patches? Are there any improvement proposals?

[littlesat]

Sorry it was not clear to me if there were still some changes in functionality and/or side effects with this commit...
You added a warning....

Edited by littlesat, 6 December 2013 - 18:52.

[betacentauri]

It can have side effects in images from other teams. That's why I wrote the warning.

If you(PLi team) say that you like the patch and will commit it, I'll inform the other teams. If you say, change this and that, I'll try to fix that first.