Jump to content


Photo

Teletext improvements


  • Please log in to reply
104 replies to this topic

Re: Teletext improvements #81 ims

  • PLi® Core member
  • 12,652 posts

+194
Excellent

Posted 3 March 2014 - 17:58

yes, only "const" was removed.

 

About  "Does the build env use different compilers for dreamboxes and e.g. et boxes?" -  yes, but guys want not it.

it is easy:

#ifdef DREAMBOX
	virtual int islocked() { return 0; }
#else
 	virtual int islocked() const { return 0; }
#endif

Edited by ims, 3 March 2014 - 18:00.

Kdo nic nedělá, nic nezkazí!

Re: Teletext improvements #82 littlesat

  • PLi® Core member
  • 53,313 posts

+621
Excellent

Posted 3 March 2014 - 19:25

Ims,

I suggest that you're wrong here...

As far i know the compilers are the same...

Put a teletekst oe other subtitle on... En goto teletekst... Or try to change the volume of you're box and you see why the const means...

As far I can see we trigger a driver bug... Something only DMM can solve... If they are willing... But they have inbetween their new much more fency closed source teletekst version... (As they cannot use tuxtxt witch cache as they are not gpl anymore)... Possibly the bug in the drivers isn't a real bug. It is required to let their teletekst run as it should be... Who knows???

Edited by littlesat, 3 March 2014 - 19:31.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Teletext improvements #83 betacentauri

  • PLi® Core member
  • 7,096 posts

+319
Excellent

Posted 3 March 2014 - 19:39

@ims: Did you read this post?
http://openpli.org/f...ndpost&p=391033
Now after revert of the commit, which method is called? gFBDC::islocked or the virtual islocked method in gDC (grc.h). And do you see artifacts when changing volume?
Xtrend ET-9200, ET-8000, ET-10000, OpenPliPC on Ubuntu 12.04

Re: Teletext improvements #84 ims

  • PLi® Core member
  • 12,652 posts

+194
Excellent

Posted 3 March 2014 - 19:47

Ims,

I suggest that you're wrong here...

As far i know the compilers are the same...

Put a teletekst oe other subtitle on... En goto teletekst... Or try to change the volume of you're box and you see why the const means...

 

may be ...

but what is wrong on txt subtitles ? Tried recorded movie cca 1year old and both subtitles - txt (via Audio-subtitle menu) and txt (page 888) works well.

About volume up/down, when is teletext active - little vertical lines.


Kdo nic nedělá, nic nezkazí!

Re: Teletext improvements #85 ims

  • PLi® Core member
  • 12,652 posts

+194
Excellent

Posted 3 March 2014 - 19:49

@ims: Did you read this post?
http://openpli.org/f...ndpost&p=391033
Now after revert of the commit, which method is called? gFBDC::islocked or the virtual islocked method in gDC (grc.h). And do you see artifacts when changing volume?

I never using volume up/down with teletext :)


Kdo nic nedělá, nic nezkazí!

Re: Teletext improvements #86 littlesat

  • PLi® Core member
  • 53,313 posts

+621
Excellent

Posted 3 March 2014 - 21:12

Then do it... Or enable subs... Without betacentauti's patch...

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Teletext improvements #87 ims

  • PLi® Core member
  • 12,652 posts

+194
Excellent

Posted 3 March 2014 - 21:48

Did you read my answer about txt subtitles ? I have not problems with it with/without this patche and never had problems with it before.


Kdo nic nedělá, nic nezkazí!

Re: Teletext improvements #88 ims

  • PLi® Core member
  • 12,652 posts

+194
Excellent

Posted 3 March 2014 - 23:02

may be, it is nonsence, but with betacentauti's patch I changed there in glcddc.h:

int islocked() { return lcd->islocked(); }
 

  to

int islocked() const { return lcd->islocked(); }
 

and I have no problem with OLED and TuxTXT now. Problems begin, when I trying very quickly turning on/off teletext. Then OLED changing at first colors of picon (only colors) and then more and more deforming picon and then crashs. But it is 100x better than before it.


Kdo nic nedělá, nic nezkazí!

Re: Teletext improvements #89 littlesat

  • PLi® Core member
  • 53,313 posts

+621
Excellent

Posted 3 March 2014 - 23:16

And when hou enable subtitlles and enable epg,.. The teletext on screen is corrupted.... As e2 cam still write to the osd... So it is fix osd during teletekst for all boxes or work a round the race/bug in dmm drivers for the frontdisplay.

Or someone would invent another way to work around. Did you found it?

Edited by littlesat, 3 March 2014 - 23:21.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Teletext improvements #90 ims

  • PLi® Core member
  • 12,652 posts

+194
Excellent

Posted 3 March 2014 - 23:33

And when hou enable subtitlles and enable epg,.. The teletext on screen is corrupted....

 

I do not understand ... you talking about subtitles on page 888 or ttf subtitles ? When are used 888, then is not possible using any EPG.

I am using txt ttf subtitles and open EPG and then I trying Teletext - all is ok.

Once again - it is with betacentauti's patch + change in glcddc.h

 

Without change in glcddc.h is OLED corrupted after 1-3 turning on/off teletext.


Edited by ims, 3 March 2014 - 23:36.

Kdo nic nedělá, nic nezkazí!

Re: Teletext improvements #91 betacentauri

  • PLi® Core member
  • 7,096 posts

+319
Excellent

Posted 3 March 2014 - 23:54

may be, it is nonsence, but with betacentauti's patch I changed there in glcddc.h:

int islocked() { return lcd->islocked(); }
to
int islocked() const { return lcd->islocked(); }
and I have no problem with OLED and TuxTXT now. Problems begin, when I trying very quickly turning on/off teletext. Then OLED changing at first colors of picon (only colors) and then more and more deforming picon and then crashs. But it is 100x better than before it.

Nice find! Yes, the const is missing there. Please provide a patch.
Turning teletext very quickly on/off is not normal use case ;) This might be really a driver bug...
Xtrend ET-9200, ET-8000, ET-10000, OpenPliPC on Ubuntu 12.04

Re: Teletext improvements #92 ims

  • PLi® Core member
  • 12,652 posts

+194
Excellent

Posted 4 March 2014 - 00:00

here it is

Attached Files


Kdo nic nedělá, nic nezkazí!

Re: Teletext improvements #93 littlesat

  • PLi® Core member
  • 53,313 posts

+621
Excellent

Posted 4 March 2014 - 09:00

I this both verified by ims and betacentauri?

And likely indeed a driver bug has been verified...

Edited by littlesat, 4 March 2014 - 09:01.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Teletext improvements #94 ims

  • PLi® Core member
  • 12,652 posts

+194
Excellent

Posted 4 March 2014 - 09:22

Because I cannot reproduce your problems with txt subtitles, I cannot tell you more than i have not problem with OLED now (when is not quickly switched txt).

ome time back i can see, that txt not always started.

 

BTW, int islocked {} is in fb.h, lcd.h, gfbdc.h and sdl.h too and in rc.h 


Kdo nic nedělá, nic nezkazí!

Re: Teletext improvements #95 littlesat

  • PLi® Core member
  • 53,313 posts

+621
Excellent

Posted 4 March 2014 - 09:36

For that issue you should start teletext (or DVB grapic subs) in E2 and then open tuxtxt...


WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Teletext improvements #96 ims

  • PLi® Core member
  • 12,652 posts

+194
Excellent

Posted 4 March 2014 - 09:57

but this problem I had never... as I wrote several times...


Kdo nic nedělá, nic nezkazí!

Re: Teletext improvements #97 littlesat

  • PLi® Core member
  • 53,313 posts

+621
Excellent

Posted 4 March 2014 - 11:45

But we did upgrade the drivers aswell...

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Teletext improvements #98 betacentauri

  • PLi® Core member
  • 7,096 posts

+319
Excellent

Posted 4 March 2014 - 12:28

BTW, int islocked {} is in fb.h, lcd.h, gfbdc.h and sdl.h too and in rc.h


isLocked is not always isLocked. We're speaking about the virtual gDC:isLocked and all procedures which implement/overwrite this virtual procedure.
E.g. the class fbClass has a isLocked function but the class is no child of gDC. Same for lcd.h.
Only sdl.h is a candidate as far as I can see. The parent is gMainDC and gMainDC inherits from gDC. But I don't know whether sdl.cpp is used somewhere.
Xtrend ET-9200, ET-8000, ET-10000, OpenPliPC on Ubuntu 12.04

Re: Teletext improvements #99 ims

  • PLi® Core member
  • 12,652 posts

+194
Excellent

Posted 4 March 2014 - 12:54

But we did upgrade the drivers aswell...

which drivers (boxes)?


Kdo nic nedělá, nic nezkazí!

Re: Teletext improvements #100 ims

  • PLi® Core member
  • 12,652 posts

+194
Excellent

Posted 4 March 2014 - 12:55

BTW, int islocked {} is in fb.h, lcd.h, gfbdc.h and sdl.h too and in rc.h


isLocked is not always isLocked. We're speaking about the virtual gDC:isLocked and all procedures which implement/overwrite this virtual procedure.
E.g. the class fbClass has a isLocked function but the class is no child of gDC. Same for lcd.h.
Only sdl.h is a candidate as far as I can see. The parent is gMainDC and gMainDC inherits from gDC. But I don't know whether sdl.cpp is used somewhere.

Yes, I know. But would not be better thinking about it (sdl.h), preventive ?


Kdo nic nedělá, nic nezkazí!


0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users