Jump to content


Photo

PiP Zap improvement

PiP Pip Zap

  • Please log in to reply
39 replies to this topic

#1 Pr2

  • PLi® Contributor
  • 3,807 posts

+161
Excellent

Posted 17 December 2013 - 09:56

Hi,

 

Take this setup, a STB with one tuner DVB-S2 and one tuner DVB-C.

 

While watching the DVB-S2 tuner on the main screen, I enable the PiP then enable the PiP zap feature. Then I zap to a DVB-C channel (everything is working fine). Wide screen is DVB-S2, small screen is DVB-C.

I am still in PiP-Zap and call back the channel selection, in the DVB-C channel list everything is greyed out except the channels on the same TP.

And if I zap to a greyed out channel it works, the box zap properly which is normal since the tuner is not really blocked on this particular specific TP since I plan to zap.

 

So according to me, when we are in PiP with Pip-Zap enabled we don't need to grey out channels of the tuner used for the small screen, since we call it to zap, so potentially all the channels are available for zapping on the tuner used for the PiP small picture, there is no reason to grey them out.

 

What do you think of this improvement (cosmetic I must admit since zapping is working anyway)?

 

Pr2


NO SUPPORT by PM, it is a forum make your question public so everybody can benefit from the question/answer.
If you think that my answer helps you, you can press the up arrow in bottom right of the answer.

Wanna help with OpenPLi Translation? Please read our Wiki Information for translators

Sat: Hotbird 13.0E, Astra 19.2E, Eutelsat5A 5.0W
VU+ Solo 4K: 2*DVB-S2 + 2*DVB-C/T/T2 (used in DVB-C) & Duo 4K: 2*DVB-S2X + DVB-C (FBC)
Edision OS Mio 4K: 1*DVB-S2X + 1*DVB-C/T/T2
 


Re: PiP Zap improvement #2 Dimitrij

  • PLi® Core member
  • 6,608 posts

+213
Excellent

Posted 17 December 2013 - 18:53

This is a problem not only DVB-C,on receiver in twin tuner DVB-S2 the same problem.


Lunix3-4K/VU+solo4k(thanks guys to gisclub.tv)


Re: PiP Zap improvement #3 Pr2

  • PLi® Contributor
  • 3,807 posts

+161
Excellent

Posted 17 December 2013 - 20:48

Hi,

 

Yes but it was easier to explain with two different DVB tuner type.  ;)

 

Pr2


NO SUPPORT by PM, it is a forum make your question public so everybody can benefit from the question/answer.
If you think that my answer helps you, you can press the up arrow in bottom right of the answer.

Wanna help with OpenPLi Translation? Please read our Wiki Information for translators

Sat: Hotbird 13.0E, Astra 19.2E, Eutelsat5A 5.0W
VU+ Solo 4K: 2*DVB-S2 + 2*DVB-C/T/T2 (used in DVB-C) & Duo 4K: 2*DVB-S2X + DVB-C (FBC)
Edision OS Mio 4K: 1*DVB-S2X + 1*DVB-C/T/T2
 


Re: PiP Zap improvement #4 Dimitrij

  • PLi® Core member
  • 6,608 posts

+213
Excellent

Posted 28 December 2013 - 21:19

Problem is found.

ChannelSelection.py --> def __evServiceStart/def __evServiceEnd

Intermediate option to check:

	def zap(self, enable_pipzap=False, preview_zap=False, checkParentalControl=True, ref=None):
		self.curRoot = self.startRoot
		nref = ref or self.getCurrentSelection()
		ref = self.session.nav.getCurrentlyPlayingServiceOrGroup()
		if enable_pipzap and self.dopipzap:
			ref = self.session.pip.getCurrentService()
			if ref is None or ref != nref:
				if not checkParentalControl or Components.ParentalControl.parentalControl.isServicePlayable(nref, boundFunction(self.zap, enable_pipzap=True, checkParentalControl=False)):
					if not self.session.pip.playService(nref):
						# XXX: Make sure we set an invalid ref
						self.session.pip.playService(None)
					else:
+						self.servicelist.setPlayableIgnoreService(self.session.pip.getCurrentService())
				else:
					self.setStartRoot(self.curRoot)
					self.setCurrentSelection(ref)
		elif ref is None or ref != nref:

Lunix3-4K/VU+solo4k(thanks guys to gisclub.tv)


Re: PiP Zap improvement #5 littlesat

  • PLi® Core member
  • 49,733 posts

+543
Excellent

Posted 29 December 2013 - 09:46

Dima,

Can you post here your latest channelselection.py and send me a pm.... So I can take a look at this tomorrow (today likely no time).

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: PiP Zap improvement #6 Dimitrij

  • PLi® Core member
  • 6,608 posts

+213
Excellent

Posted 29 December 2013 - 14:48

Dima,

Can you post here your latest channelselection.py and send me a pm.... So I can take a look at this tomorrow (today likely no time).

There is only one line added.
And this is not a complete solution.


Lunix3-4K/VU+solo4k(thanks guys to gisclub.tv)


Re: PiP Zap improvement #7 littlesat

  • PLi® Core member
  • 49,733 posts

+543
Excellent

Posted 29 December 2013 - 15:40

And the else?

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: PiP Zap improvement #8 Dimitrij

  • PLi® Core member
  • 6,608 posts

+213
Excellent

Posted 29 December 2013 - 16:25

And the else?

PM


Lunix3-4K/VU+solo4k(thanks guys to gisclub.tv)


Re: PiP Zap improvement #9 Dimitrij

  • PLi® Core member
  • 6,608 posts

+213
Excellent

Posted 5 January 2014 - 09:42

littlesat

open MoviePlayer -->run video -->press blue button and press "Move Picture in Picture"(pip not enabled)

Traceback (most recent call last):
  File "/usr/lib/enigma2/python/mytest.py", line 191, in processDelay
    callback(*retval)
  File "/usr/lib/enigma2/python/Screens/InfoBarGenerics.py", line 1800, in extensionCallback
  File "/usr/lib/enigma2/python/Screens/InfoBarGenerics.py", line 1937, in movePiP
AttributeError: Session instance has no attribute 'pip'

InfoBar.py

class MoviePlayer

--- a/InfoBar.py
+++ b/InfoBar.py
@@ -381,10 +381,17 @@
 			from Screens.PictureInPicture import PictureInPicture
 			self.session.pip = self.session.instantiateDialog(PictureInPicture)
 			self.session.pip.show()
-			self.session.pipshown = True
-			self.session.pip.playService(slist.getCurrentSelection())
-			self.session.pip.servicePath = slist.getCurrentServicePath()
+			if self.session.pip.playService(slist.getCurrentSelection()):
+				self.session.pipshown = True
+				self.session.pip.servicePath = slist.getCurrentServicePath()
+			else:
+				self.session.pipshown = False
+				del self.session.pip
 
+	def movePiP(self):
+		if self.session.pipshown:
+			InfoBarPiP.movePiP(self)
+
 	def swapPiP(self):
 		pass

 


Lunix3-4K/VU+solo4k(thanks guys to gisclub.tv)


Re: PiP Zap improvement #10 littlesat

  • PLi® Core member
  • 49,733 posts

+543
Excellent

Posted 5 January 2014 - 09:54

I do not see move pip when no pip is active....

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: PiP Zap improvement #11 Dimitrij

  • PLi® Core member
  • 6,608 posts

+213
Excellent

Posted 5 January 2014 - 09:57

I do not see move pip when no pip is active....

open MoviePlayer -->run video


Lunix3-4K/VU+solo4k(thanks guys to gisclub.tv)


Re: PiP Zap improvement #12 littlesat

  • PLi® Core member
  • 49,733 posts

+543
Excellent

Posted 5 January 2014 - 09:59

Ok... I understand... Now I need time...
To speedup commit time please post your inforbar.py here..
Please learn how how to make proper patch files for us soon... So your patches also become yours...
Thanks for all the effort to improve pip stuff and the other stuff you contributed to us! This is very appriciated!

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: PiP Zap improvement #13 Dimitrij

  • PLi® Core member
  • 6,608 posts

+213
Excellent

Posted 5 January 2014 - 10:10

Ok... I understand... Now I need time...
To speedup commit time please post your inforbar.py here..
Please learn how how to make proper patch files for us soon... So your patches also become yours...
Thanks for all the effort to improve pip stuff and the other stuff you contributed to us! This is very appriciated!


Lunix3-4K/VU+solo4k(thanks guys to gisclub.tv)


Re: PiP Zap improvement #14 Dimitrij

  • PLi® Core member
  • 6,608 posts

+213
Excellent

Posted 5 January 2014 - 10:51

+

Fix first enable togglePipzap in MoviePlayer


Lunix3-4K/VU+solo4k(thanks guys to gisclub.tv)


Re: PiP Zap improvement #15 littlesat

  • PLi® Core member
  • 49,733 posts

+543
Excellent

Posted 5 January 2014 - 10:54

Cool....

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: PiP Zap improvement #16 Dimitrij

  • PLi® Core member
  • 6,608 posts

+213
Excellent

Posted 5 January 2014 - 21:48

littlesat

1)

Traceback (most recent call last):
  File "/usr/lib/enigma2/python/mytest.py", line 191, in processDelay
    callback(*retval)
  File "/usr/lib/enigma2/python/Screens/InfoBarGenerics.py", line 1800, in extensionCallback
  File "/usr/lib/enigma2/python/Screens/InfoBarGenerics.py", line 1901, in togglePipzap
AttributeError: Session instance has no attribute 'pip'
--- a/lib/python/Screens/InfoBarGenerics.py
+++ b/lib/python/Screens/InfoBarGenerics.py
@@ -1897,9 +1897,10 @@
 		slist = self.servicelist
 		if slist and self.session.pipshown:
 			slist.togglePipzap()
-			currentServicePath = self.servicelist.getCurrentServicePath()
-			self.servicelist.setCurrentServicePath(self.session.pip.servicePath, doZap=False)
-			self.session.pip.servicePath = currentServicePath
+			if slist.dopipzap:
+				currentServicePath = self.servicelist.getCurrentServicePath()
+				self.servicelist.setCurrentServicePath(self.session.pip.servicePath, doZap=False)
+				self.session.pip.servicePath = currentServicePath
 
 	def showPiP(self):
 		if self.session.pipshown:

 

2)

What is this feature?

http://sourceforge.n...42d0ae38c0bdf5/


Lunix3-4K/VU+solo4k(thanks guys to gisclub.tv)


Re: PiP Zap improvement #17 littlesat

  • PLi® Core member
  • 49,733 posts

+543
Excellent

Posted 6 January 2014 - 00:47

1. Why
2. It is for et boxes.... They can also zap differently on scart instead of pip

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: PiP Zap improvement #18 Dimitrij

  • PLi® Core member
  • 6,608 posts

+213
Excellent

Posted 6 January 2014 - 06:17

1. Why
 

enable pip-->togglePipzap-->zap to service type 4097-->disable pip

Traceback (most recent call last):
  File "/usr/lib/enigma2/python/mytest.py", line 191, in processDelay
    callback(*retval)
  File "/usr/lib/enigma2/python/Screens/InfoBarGenerics.py", line 1800, in extensionCallback
  File "/usr/lib/enigma2/python/Screens/InfoBarGenerics.py", line 1901, in togglePipzap
AttributeError: Session instance has no attribute 'pip'

Lunix3-4K/VU+solo4k(thanks guys to gisclub.tv)


Re: PiP Zap improvement #19 littlesat

  • PLi® Core member
  • 49,733 posts

+543
Excellent

Posted 6 January 2014 - 08:04

Ok... Gstreamer stuff again...

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: PiP Zap improvement #20 Dimitrij

  • PLi® Core member
  • 6,608 posts

+213
Excellent

Posted 6 January 2014 - 19:12


2. It is for et boxes.... They can also zap differently on scart instead of pip

Enabling this feature results in a very negative effect.
The receiver is out of control, the remote buttons do not work.


Edited by Dima73, 6 January 2014 - 19:15.

Lunix3-4K/VU+solo4k(thanks guys to gisclub.tv)






Also tagged with one or more of these keywords: PiP, Pip Zap

1 user(s) are reading this topic

0 members, 1 guests, 0 anonymous users