73 replies to this topic

[littlesat]

Why that minus 2.... Why not using a second variable initialized as zero and when something is found change it by i... And why ii?

[eesatfan]

Why that minus 2.... Why not using a second variable initialized as zero and when something is found change it by i... And why ii?

Beacuse i wrote it in that way. If PLi® Core member not understood what is going on or does not like my coding style then please ignore ( delete ) all my posts in this topic. For me this topic is closed. Sorry

[littlesat]

I only suggesr to write that part of code better.... And I had some why questions...

 

i suggest the code below is better understandable.... and is following the better way regards tabs and {} stuff..

 

 

            int sub = 0;
            for (i=0; i < m_teletext_parser->max_id; i++)
            {
                if (!memcmp(m_teletext_parser->my_country_codes[i], lang.c_str(), 3))
                {
                    sub = i;
                    break;
                {
            }
            m_dvb_service->setCacheEntry(eDVBService::cSUBTITLE,((pid&0xFFFF)<<16)|((page&0xFF)<<8)|((sub&0x1F)<<3)|(magazine&0x7));
        }

Edited by littlesat, 7 February 2014 - 11:12.

[littlesat]

Not really required but possibly better readable..

 

+    if (m_L > 0)
+        nat_subset_2 = country_lookup[m_L];
+    else
+        nat_subset_2 = NationalOptionSubsetsLookup[Gtriplet*8+nat_opts];

[eesatfan]

Changes are commited.

Thanks

[zeros]

Very very big thank you!!!
This is the most important innovation in the last two years, in my opinion.

Thank you and all of our hardest-makers as well, and I very much hope that Littlesat do not mind, but it's really important the update and I am very glad that it is on one side now.
We opened a bottle of champagne at home! :-)

[littlesat]

You know how to find my green thumb up ...
I hope the campagne tasted well!

[urick]

The patch format is incorrect....

The idea looks good...

 

$ git am -s ../subtitle.patch

 

root@dm800se:~# $ git am -s ../subtitle.patch
-sh: $: not found

 

what do I do wrong?

[zeros]

Hi urick!

This patch is for software compilators. When you update the software with today's night update, it's already been added to the software updates. Just go to MENU- Setup- Software update

and update your package list.

Today it is inside and I confirm that all is working fine!

 

Littlesat, I want to add the +1 green thumb but I can not find a way.

 

I'll include the good news to the DMM forum also, maybe in one day the official software users can also have that correction but without the local help they certainly can not have.

[ims]

i think, DMM will take it from our repo without thanks, as usually

[WanWizard]

Littlesat, I want to add the +1 green thumb but I can not find a way.

 

3 more posts and you'll become a "senior member", and the button will appear...

[urick]

Hi urick!

This patch is for software compilators. When you update the software with today's night update, it's already been added to the software updates. Just go to MENU- Setup- Software update

and update your package list.

Today it is inside and I confirm that all is working fine!

 

Ok. thanks to All

[eesatfan]

i think, DMM will take it from our repo without thanks, as usually

I sent patch for older (last free from dmm) enigma2 to DMM allso.

[theparasol]

I sent patch for older (last free from dmm) enigma2 to DMM allso.

 

Dont expect they send you a medal for it in return... Please remember DMM is a commercial manufacturer who has null interest in the opensource community.

I rather give them the same kind of support they give to us!

[zeros]

We have also users who are using the original software and on their own interest this would be a good deed. The second thing is that it would be good to have big things in the same way as to prevent mismatches.
This theme is solved with that patch - http://www.dream-mul...&threadID=16576
but I can't post there because it is too old theme. It is also important V2 owners who can't use PLI software.

[eesatfan]

Dont expect they send you a medal for it in return... Please remember DMM is a commercial manufacturer who has null interest in the opensource community.

I rather give them the same kind of support they give to us!

 

I expect only that this wired situation with our subtitles is fixed allso on newer DMM hardware. As long time developer I understund why they closed own source. I dont say thats good, but at least I understund. Now in our interests is only get subtitles fixed.

Edited by eesatfan, 9 February 2014 - 08:34.

[zeros]

I would add one important Nota Bene

NB! Select subtitle language is cached for every channel together with pid and page and magazine number. eesatfan already said, however, it is important.

User-level settings that are kept in memory here: (Attached File)

People who use Henksat E2 Channelsettings etc. must understand that these settings may be overwritten by the settingslist. Will be briefly re-select a different language and then the desired language.

 

And NB2! You have to choose the language so that thing come into force.

According to our user SATEKS information

txt format Cyrillic (such as a TV text subtitles) communicates from 36°E Первый канал HD, Первый канал, ТВ Центр, Россия 1, Россия К , and possibly a few more channels. As a rule, so far digibox displays the Russian text in Latin letters. So far this patch changed our lives ;-)

 

Many thanks to eesatfan, err23 , littlesat, Taapat and to all beta testers.

And welcome to report if there is any other country who get his international characters corrected now. Known languages are estonians, latvians, lithuanians and russians.

Attached Files

•  Viasat Nature East.jpg   88.63KB   20 downloads

Edited by zeros, 9 February 2014 - 11:06.

[littlesat]

I never realised that this was such an important patch for users in your region....

Also thanks for eestafan that he tried with is to improve the quality of the code.

We are not able to test this as we cannot really read the differences...

Edited by littlesat, 9 February 2014 - 11:14.

[backspeed]

I am using openpli image from 1st of April 2015 and i have a problem with croatian ttx subtitle, because it doesn't recognize some croatian characters like č, š, ć, đ, ž. The problem is only with teletext subtitles. For example is channel Fine Living on 23.5E (DVB-S2 11914 H 29900) with croatian ttx subtitle on id 454.

Can somebody help me?

[zeros]

Hi backspeed,
If you read the post #57
if you tried that:
Briefly select a language other that you want, and then select your language (croatian) back again.
User settings are saved.
You have to do it through the time with all wanted Croat channels. I hope this helps!?