Jump to content


Photo

Latest changes to the infobar causing plugins not to work


  • Please log in to reply
29 replies to this topic

Re: Latest changes to the infobar causing plugins not to work #21 ian1095

  • Senior Member
  • 462 posts

+6
Neutral

Posted 27 January 2014 - 18:57

ah that explains it then,i guessed this was the problem and why i was unable to follow what you were saying.

 

thats 0.6r4

 

the version ive just uploaded and im using is 1.2

 

Ian.


Edited by ian1095, 27 January 2014 - 18:58.


Re: Latest changes to the infobar causing plugins not to work #22 littlesat

  • PLi® Core member
  • 56,968 posts

+696
Excellent

Posted 27 January 2014 - 21:26

Then someone needs to offer us a new adapted ipk of this 3rd party plugin...

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Latest changes to the infobar causing plugins not to work #23 ian1095

  • Senior Member
  • 462 posts

+6
Neutral

Posted 27 January 2014 - 21:45

here is an ipk

 

sorry i didnt know you wanted one,i just took the plugin straight out of my box for you to examine.

 

ive discovered that the line your referring to is line 1234 in this version,but i still cannot establish what you have now called the function in the infobar.py file.

 

once i know this its just a very simple edit to get this to work in pli once more.

 

of course the attached ipk doesnt have this edit,simply because i dont yet know how to do it.

 

if i knew i would have edited it then created a new ipk for everyone to use.

 

Ian.

Attached Files


Edited by ian1095, 27 January 2014 - 21:46.


Re: Latest changes to the infobar causing plugins not to work #24 ian1095

  • Senior Member
  • 462 posts

+6
Neutral

Posted 27 January 2014 - 21:51

as i stated earlier,i do have this working using the dirty hack of editing the keymap.xml file,but i would still rather do this properly and edit the plugin itself,then return the keymap.xml file back to how it should be.

 

Ian.



Re: Latest changes to the infobar causing plugins not to work #25 littlesat

  • PLi® Core member
  • 56,968 posts

+696
Excellent

Posted 27 January 2014 - 23:44

Are you able to fix this plugin?

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Latest changes to the infobar causing plugins not to work #26 ian1095

  • Senior Member
  • 462 posts

+6
Neutral

Posted 28 January 2014 - 09:12

no not as yet.

 

but i would say yes i could once i figure out what the new function is in the infobar.py

 

at the moment though i simply cannot figure out what to replace this line with.

 

MoviePlayer.originalOpenEventView = MoviePlayer.openEventView

 

Ian.



Re: Latest changes to the infobar causing plugins not to work #27 ian1095

  • Senior Member
  • 462 posts

+6
Neutral

Posted 28 January 2014 - 09:19

ive also been in touch with the author and he refuses to make a separate version just for pli because the original version runs on all other images.

 

he claims its the pli changes that have broken this,and its not the plugin itself thats at fault,which in essence,is actually true,and that its too much work to now split all future updates into two groups,one just for pli and the other for all other images.

 

so we can expect no help from that direction.

 

Ian.


Edited by ian1095, 28 January 2014 - 09:21.


Re: Latest changes to the infobar causing plugins not to work #28 ian1095

  • Senior Member
  • 462 posts

+6
Neutral

Posted 28 January 2014 - 09:27

i think the time allowed to edit posts needs increasing on this site.

 

i just wish to add that also because of this,fixing the plugin rather than sorting out the changes in the image that have caused this, means that all future updates from the author will have to be edited to run on pli as well.

 

not good news.

 

Ian.


Edited by ian1095, 28 January 2014 - 09:27.


Re: Latest changes to the infobar causing plugins not to work #29 ian1095

  • Senior Member
  • 462 posts

+6
Neutral

Posted 28 January 2014 - 21:07

thanks littlesat

 

ive just tested your latest infobar.py commit and it has fixed the issue.

 

so all is well again.

 

Ian.


Edited by ian1095, 28 January 2014 - 21:08.


Re: Latest changes to the infobar causing plugins not to work #30 littlesat

  • PLi® Core member
  • 56,968 posts

+696
Excellent

Posted 29 January 2014 - 00:54

Only with the renaming of that one function I'm not fully happy... But at least it is now compatibe with plugins that streal that specific function...
Please note any time hou made changes to enigma2 you have the risk to break plugins... In special the 3rd parties.. And in case they steal standard enigma2 functions...

Edited by littlesat, 29 January 2014 - 00:56.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W



20 user(s) are reading this topic

0 members, 20 guests, 0 anonymous users