37 replies to this topic

[littlesat]

Because in E2 once it has this name in the code.....

[Stan]

Can you replace it by SubRip? There's no point in keeping bad traditions... 

[littlesat]

Then I have need to change code that is a long time there like that... I suggest that makes no sense anymore....

Visual in the UI it could be changed of course

[Erik Slagter]

Can you replace it by SubRip? There's no point in keeping bad traditions... 

Because SubRip is also incorrect in this context.

 

This code (and configuration) is used for all text-based media subtitles. It can be srt, but it can also be 3gpp text (in mp4) and text subtitles in mkv. So text subtitles would be the correct name, but I guess it would confuse some people because it resembled "teletext subtitles" which is another story altogether. I agree "pango" is completely wrong. Apparently the e2 devs were planning to use pango, but in the end didn't.

[Stan]

@littlesat

 

If it's not too much asked, could you please change the tag colours, so that they can be distinguished also in dialogs? (which now are yellow and cyan).

 

I would suggest

<i> green (which fits best for the most used tag)

<b> magenta

<u> red

 

Thank you

Edited by Stan, 26 January 2015 - 17:01.

[littlesat]

For srt's this is a config now..... You can set alternative coloring mode again...

[Stan]

I am using the "alternative" colours in combination with "dialog colorisation".

 

Since the dialogs are coloured yellow and cyan, you cannot distinguish <i>,<b> tagged text in dialogs because of the same colour.

Edited by Stan, 26 January 2015 - 17:10.

[littlesat]

Isn't that logical....

You can consider to display italic italic etc......

Edited by littlesat, 26 January 2015 - 19:34.

[Erik Slagter]

Doesn't work, he has a point here. Enigma can't display PARTS of a title in italic or bold.

[littlesat]

It can do parts in color no font switch (yet)... But in srt I found only ome line that needs that in thousand subtitle lines....

[Erik Slagter]

I have some examples where it is used all of the time. It's not an excuse. If the user wants to have coloured titles instead of subfonts because otherwise he can't see where it's supposed to be bold/italic/underlined, let them have it.

[Stan]

@littlesat, I don't think it's too much trouble to change the colours of the subtitle tags. 

Since we have this wonderful feature, why not make the best out of it?

 

I have even prepared the RGB codes:

 

<i> green (0x00, 0xff, 0x00)
<b> magenta (0xff, 0x00, 0xff)
<u> light red (0xff, 0xaa, 0xaa)

Edited by Stan, 12 February 2015 - 15:53.

[Stan]

Sorry to bring this up again... but I'd really appreciate the colour change.

 

Regarding the coloured tags, there's also the problem with the wrong alignment. Eric implemented a work-around for coloured dialogs some time ago. Can this be made also for the tags?

[Erik Slagter]

Can you give an example (preferrably with an image)?

[Stan]

I cannot upload an example right now, but you can easily reproduce the fault.
It occurs when external subtitles are set to 'centered' or 'right' and re-wrap is off and the second subtitle line starts with a tag.

Or, more generally speaking, a 'newline' followed directly by a colour statement breaks the alignement.
I believe your workaroung consisted in inserting a whitespace before the color statement.

Edited by Stan, 8 March 2015 - 14:28.

[Stan]

Here's an example from a SubRip file.

61
00:03:33,240 --> 00:03:35,891
Okay?
<i>Okay. She's pretty pissed off.</i>

The second line starts with a tag. In this case the alignment of the displayed subtitle gets messed up.
(it should be centered)

 

 Subtitle_alignment_fault.jpg   85.97KB   3 downloads

Edited by Stan, 8 March 2015 - 21:05.

[Erik Slagter]

As I said, the root cause of the problem should be solved. It's going to take a lot of effort, it's complex code. I'm not going to do it...

[Stan]

I know, you mentioned that before...

 

The work-around that you implemented for the coloured dialogs would help though...

It would be great if you could apply it also for the tags.

 

BTW, here's the full SRT-file of the example posted before, the fault can be seen quite often.

 The Call (2013).srt.txt   71.76KB   1 downloads

Edited by Stan, 9 March 2015 - 16:46.