60 replies to this topic

[Taapat]

And one more thing, now we do not need in ServiceName self.mode staff: http://sourceforge.n...viceName.py#l16

self.mode = ""
  if ';' in type:
   type, self.mode = type.split(';')

[littlesat]

I already discovered that by myself...

[Taapat]

And one more thing  .

I think that we do not need to use the split(";") on TransponderInfo init.
If the converter remains as it is now, then using the "in self.type" we can get InRootOnly, NoRoot and detailed_satpos from self.type without split.
Using the split we just on every init unnecessarily spend time and resources.

[Taapat]

And I want to ask.
Is there a possibility that you could add def getProviderName from ServiceName2? https://github.com/O...ceName2.py#L126
I am using a provider in the channel list to display it picon. It is the last for how I use ServiceName2 in my skin.
Maybe that the code can be written better. I do not like the two loops for provider and service, but maybe I am wrong and this is the best that can be. And of course import from Screens.ChannelSelection should be used at the beginning of the file.

 

I would be very glad if you add it, and I could refuse ServiceName2.

Edited by Taapat, 20 March 2015 - 18:25.

[littlesat]

Sure that can be done...
The split is in a cosmetic way required... You can do no root and detailed sat position together.... At leasf the split defines a nice ; split ant the compares with in do check full strings...

[Taapat]

Yes of course, split defines a nice ; split, but without it would be a lot more flexible. That, without some kind of problems, allowing the user to make a mistakes in split symbols, or not use them at all.
But maybe I am wrong, and need strict order in specifying what need to do.

 

And what about the second question about provider in the service list?

Edited by Taapat, 21 March 2015 - 10:11.

[littlesat]

Af this place it doen not make problems... But for Some tags it may give issues.. The split is there for a structural reason...

[ims]

And I want to ask.
Is there a possibility that you could add def getProviderName from ServiceName2? https://github.com/O...ceName2.py#L126
I am using a provider in the channel list to display it picon. It is the last for how I use ServiceName2 in my skin.
Maybe that the code can be written better. I do not like the two loops for provider and service, but maybe I am wrong and this is the best that can be. And of course import from Screens.ChannelSelection should be used at the beginning of the file.

 

I would be very glad if you add it, and I could refuse ServiceName2.

 

add this into channel selection - it display picons

    <widget source="ServiceEvent" render="Picon" position="30,525" size="100,60" alphatest="blend" backgroundColor="secondBG" transparent="1" zPosition="1">
      <convert type="ServiceName">Reference</convert>
    </widget>

[Taapat]

@ims please read carefully. I'm talking about provider picon.

[littlesat]

Then give us a patch....

[Taapat]

Then give us a patch....

Attached Files

•  0001-ServiceName-add-provider-name-getting-from-reference.patch   2.74KB   21 downloads

[littlesat]

Why do we need to add such a complicated extra function....? I suggest that could be made less complicated....

Edited by littlesat, 21 March 2015 - 19:44.

[Taapat]

As I wrote above:

Maybe that the code can be written better. I do not like the two loops for provider and service, but maybe I am wrong and this is the best that can be.

 

If you have ideas for how to do less complicated, it would be very good.

Edited by Taapat, 21 March 2015 - 20:20.

[littlesat]

If I had time I already fixed it ... but I still do not understand why this is required... you can get the provider name?

[Taapat]

Yes, with the following code I can get the provider name in channel selection.

[littlesat]

But then this suggested patch is completely not required at all...

Edited by littlesat, 22 March 2015 - 00:02.

[Taapat]

Why is not required? In channel selection info comes from self.source.info and therefore with info.getInfoString(iServiceInformation.sProvider) can't get the provider name.

[ims]

@littlesat - Provider's Name is available for current played service only. But for all others services in channelselection list this info does not exist and must be parsed from "lamedb". Time expensive.

I am creating for my plugin list[(ref, provider)] from lamedb for getting this names on plugin's start...  then is for me faster to get provider's names in plugin... But it is plugin.

 

May be - to make in .cpp some for get providers name for service reference

[littlesat]

then you also could get an incorrect provider as far I see... This is really rubish... ....

Then it is better to simply assign a picon to a user bouquet list... No double loops required...

[Taapat]

Why do you think that could get an incorrect provider? Channel id is unique.
Of course it is time expensive, therefore I wrote that I do not like this code.
Make in .cpp get some for providers name for service reference would be much better.

And assign a picon to a user bouquet list does not work if in one bouquet (e.g. sports) are channels from different providers.