5 replies to this topic

[Pr2]

Hi,

 

While generating the .po file there is an error caused by the file .../data/skin_display_et8500.xml

 

Can you please have a look at this and fix it.

 

If in the po folder typing:

 

/usr/bin/python xml2po.py ../data/skin_display_et8500.xml
Traceback (most recent call last):
  File "xml2po.py", line 52, in <module>
    parser.parse(arg)
  File "/usr/lib/python2.7/xml/sax/expatreader.py", line 107, in parse
    xmlreader.IncrementalParser.parse(self, source)
  File "/usr/lib/python2.7/xml/sax/xmlreader.py", line 123, in parse
    self.feed(buffer)
  File "/usr/lib/python2.7/xml/sax/expatreader.py", line 210, in feed
    self._parser.Parse(data, isFinal)
  File "/usr/lib/python2.7/xml/sax/expatreader.py", line 304, in start_element
    self._cont_handler.startElement(name, AttributesImpl(attrs))
  File "xml2po.py", line 30, in startElement
    k = str(attrs[x])
UnicodeEncodeError: 'ascii' codec can't encode character u'\xae' in position 0: ordinal not in range(128)

 

Thanks,

 

Pr2

[Pr2]

Hi,

 

Here is one possible solution that makes xml2po.py more robust against such problem.

 

diff --git a/po/xml2po.py b/po/xml2po.py
index 7eeebc2..9b71b89 100755
--- a/po/xml2po.py
+++ b/po/xml2po.py
@@ -27,9 +27,10 @@ class parseXML(ContentHandler, LexicalHandler):
  def startElement(self, name, attrs):
  for x in ["text", "title", "value", "caption", "description"]:
  try:
- k = str(attrs[x])
+ z = attrs[x].encode('utf-8')
+ k = str(z)
  if k.strip() != "" and not self.ishex.match(k):
- attrlist.add((attrs[x], self.last_comment))
+ attrlist.add((k, self.last_comment))
  self.last_comment = None
  except KeyError:
  pass

 

With this change the output is now:

 

/usr/bin/python xml2po.py ../data/skin_display_et8500.xml 

 

#: ../data/skin_display_et8500.xml

msgid "EtPortal"

msgstr ""

 

#: ../data/skin_display_et8500.xml

msgid "®"

msgstr ""

 

 

 

But I just wonder why the ® (u\xae) is detected in the ../data/skin_display_et8500.xml  file.

 

Regards,

 

Pr2

Attached Files

•  xml2po.py.patch   571bytes   0 downloads

Edited by Pr2, 19 August 2015 - 13:37.

[Pr2]

Hi,

 

line 44  in skin_display_et8500.xml

 

<widget source="session.RecordState" render="FixedLabel" text="&#174;" position="334,140" foregroundColor="#ff0000" size="40,46" font="FdLcD;50" halign="left" valign="center" zPosition="22">

 

line 89:

<widget source="parent.RecordState" render="FixedLabel" text="&#174;" position="334,140" foregroundColor="#ff0000" size="50,46" font="FdLcD;40" halign="left" valign="center" zPosition="22">

 

line 285:

<widget source="session.RecordState" render="FixedLabel" text="&#174;" position="600,470" foregroundColor="#ff0000" size="80,80" font="FdLcD;80" halign="center" valign="center" zPosition="1">

 

that generate the problem.

 

Regards,

 

Pr2

[Tech]

So it hangs on the &#174; because it isn't an utf8 symbol?

[mirakels]

no &@174 is not a plain ascii character. Thas is causing the issue.

xml2po.py  patch commited. thansk Pr2.

[Pr2]

Hi,

 

Thanks for the commit but would be nice to review also the skin_display_et8500.xml to perform something better for the record symbol.

et8500 has a full LCD color display (like the VU+ Duo2) so I guess that we can use a .png file for recording instead of using the symbol: ®

 

Pr2