34 replies to this topic

[Taapat]

After the mirakels changes in picload I have problems with png images.
I can see it in my plugin YouTube.
Jpg images are displayed as before, but png images are black.

 screenshot.png   652.82KB   7 downloads
About this report users with mipsel receivers after today's update.
In sh4 receiver is exactly the same problem if using mirakels changes in enigma.
Image examples  and code how they are used in the plugin, you can find in github: https://github.com/T...tree/master/src

 

Users report that this problem is also in other plugins.

Edited by Taapat, 7 September 2015 - 15:08.

[Taapat]

I wanted to add that if I am on the receiver changes the TV picture aspect ratio to 4:3, and the plugin changed this png aspect ratio, then they are displayed.

The problem is when png aspect ratio change does not require.

[littlesat]

Which of Mirakels commit did break these pngs?

[Taapat]

If I one by one with cherry pick add picload commits then problems with png begins after this: https://github.com/O...2d21ef85800f70f

Edited by Taapat, 7 September 2015 - 18:21.

[mirakels]

run enigma in foreground and watch the "[ePicLoad] setPara" messages. show these lines and tell if the png displays correct or not.

(it is quite peculiar that aspect ration influences transparency...)

 

Also view the icons with picture player. I see them all properly in pictplayer.

[Taapat]

I for myself, disabled ePicLoad spam in log, I later enable it and take a look.

 

When I open these images with picture player, the images displayed normally.
But in the picture player I have a problem with these images thumbnails. They are displayed correctly only one, first time. If I choose them again, second time, then the thumbnails is black as in my pugin.

[Taapat]

I enabled log in enigma.
I want to emphasize that I have sh4 receiver and I do not have the original openpli enigma, but I see that I have exactly the same problem, and my png images look exactly the same as in the original.

 

As I wrote earlier problems is with png thumbnails. When the images open then everything is ok. If for displaying used data from Thumbnails folder, then the images are displayed incorrectly.
My youtube plugin for image display used data which are stored in the variable, so it is exactly the same problems as with pictures data from Thumbnails folder.

 

In the log I can see some problems but maybe someone see in it something useful.
Here's the log with my plugin start with incorect images:

[ePicLoad] setPara max-X=100 max-Y=72 aspect_ratio=1.000000 cache=0 resize=1 bg=#00000000 auto_orient=0
[Picload] software decode picture... /usr/lib/enigma2/python/Plugins/Extensions/YouTube/icons/icon.png
[ePicLoad] decode finished... /usr/lib/enigma2/python/Plugins/Extensions/YouTube/icons/icon.png
[getData] ox=100 oy=72 max_x=100 max_y=72 scrx=100 scry=72 xoff=0 yoff=0 xscale=1.000000 yscale=1.000000 aspect=1.000000 bits=8 orientation=1
[ePicLoad] decode thread ... got quit msg
[ePicLoad] setPara max-X=100 max-Y=72 aspect_ratio=1.000000 cache=0 resize=1 bg=#00000000 auto_orient=0
[Picload] software decode picture... /usr/lib/enigma2/python/Plugins/Extensions/YouTube/icons/Search.png
[ePicLoad] setPara max-X=100 max-Y=72 aspect_ratio=1.000000 cache=0 resize=1 bg=#00000000 auto_orient=0
[Picload] software decode picture... /usr/lib/enigma2/python/Plugins/Extensions/YouTube/icons/PubFeeds.png
[ePicLoad] setPara max-X=100 max-Y=72 aspect_ratio=1.000000 cache=0 resize=1 bg=#00000000 auto_orient=0
[Picload] software decode picture... /usr/lib/enigma2/python/Plugins/Extensions/YouTube/icons/MyFeeds.png
[ePicLoad] decode finished... /usr/lib/enigma2/python/Plugins/Extensions/YouTube/icons/Search.png
[getData] ox=100 oy=72 max_x=100 max_y=72 scrx=100 scry=72 xoff=0 yoff=0 xscale=1.000000 yscale=1.000000 aspect=1.000000 bits=8 orientation=1
[ePicLoad] decode thread ... got quit msg
[ePicLoad] decode finished... /usr/lib/enigma2/python/Plugins/Extensions/YouTube/icons/PubFeeds.png
[getData] ox=100 oy=72 max_x=100 max_y=72 scrx=100 scry=72 xoff=0 yoff=0 xscale=1.000000 yscale=1.000000 aspect=1.000000 bits=8 orientation=1
[ePicLoad] decode thread ... got quit msg
[ePicLoad] decode finished... /usr/lib/enigma2/python/Plugins/Extensions/YouTube/icons/MyFeeds.png
[getData] ox=100 oy=72 max_x=100 max_y=72 scrx=100 scry=72 xoff=0 yoff=0 xscale=1.000000 yscale=1.000000 aspect=1.000000 bits=8 orientation=1
[ePicLoad] decode thread ... got quit msg

Here's the log when TV picture set 4:3, my plugin start and images are displayed:

[ePicLoad] setPara max-X=100 max-Y=72 aspect_ratio=0.750000 cache=0 resize=1 bg=#00000000 auto_orient=0
[Picload] software decode picture... /usr/lib/enigma2/python/Plugins/Extensions/YouTube/icons/icon.png
[ePicLoad] decode finished... /usr/lib/enigma2/python/Plugins/Extensions/YouTube/icons/icon.png
[getData] ox=100 oy=72 max_x=100 max_y=72 scrx=100 scry=54 xoff=0 yoff=9 xscale=1.000000 yscale=1.333333 aspect=0.750000 bits=8 orientation=1
[ePicLoad] decode thread ... got quit msg
[ePicLoad] setPara max-X=100 max-Y=72 aspect_ratio=0.750000 cache=0 resize=1 bg=#00000000 auto_orient=0
[Picload] software decode picture... /usr/lib/enigma2/python/Plugins/Extensions/YouTube/icons/Search.png
[ePicLoad] setPara max-X=100 max-Y=72 aspect_ratio=0.750000 cache=0 resize=1 bg=#00000000 auto_orient=0
[Picload] software decode picture... /usr/lib/enigma2/python/Plugins/Extensions/YouTube/icons/PubFeeds.png
[ePicLoad] setPara max-X=100 max-Y=72 aspect_ratio=0.750000 cache=0 resize=1 bg=#00000000 auto_orient=0
[Picload] software decode picture... /usr/lib/enigma2/python/Plugins/Extensions/YouTube/icons/MyFeeds.png
[ePicLoad] decode finished... /usr/lib/enigma2/python/Plugins/Extensions/YouTube/icons/Search.png
[getData] ox=100 oy=72 max_x=100 max_y=72 scrx=100 scry=54 xoff=0 yoff=9 xscale=1.000000 yscale=1.333333 aspect=0.750000 bits=8 orientation=1
[ePicLoad] decode thread ... got quit msg
[ePicLoad] decode finished... /usr/lib/enigma2/python/Plugins/Extensions/YouTube/icons/PubFeeds.png
[getData] ox=100 oy=72 max_x=100 max_y=72 scrx=100 scry=54 xoff=0 yoff=9 xscale=1.000000 yscale=1.333333 aspect=0.750000 bits=8 orientation=1
[ePicLoad] decode thread ... got quit msg
[ePicLoad] decode finished... /usr/lib/enigma2/python/Plugins/Extensions/YouTube/icons/MyFeeds.png
[getData] ox=100 oy=72 max_x=100 max_y=72 scrx=100 scry=54 xoff=0 yoff=9 xscale=1.000000 yscale=1.333333 aspect=0.750000 bits=8 orientation=1
[ePicLoad] decode thread ... got quit msg

Here's the log from picture player when the first time open image to display as a thumbnail. The image is displayed:

[ePicLoad] get Thumbnail... /usr/lib/enigma2/python/Plugins/Extensions/YouTube/icons/HD_videos.png
[ePicLoad] save Thumbnail... /usr/lib/enigma2/python/Plugins/Extensions/YouTube/icons/.Thumbnails/pc_6AFE3F91
[ePicLoad] decode finished... /usr/lib/enigma2/python/Plugins/Extensions/YouTube/icons/HD_videos.png
[getData] ox=260 oy=186 max_x=260 max_y=300 scrx=260 scry=186 xoff=0 yoff=57 xscale=1.000000 yscale=1.000000 aspect=1.000000 bits=8 orientation=1
[gAccel] accelAlloc called with size 0

Here's the log from picture player for the second time you open the image to display as a thumbnail.

The data for the image is taken from Thumbnails folder and are not displayed correctly:

[ePicLoad] get Thumbnail... /usr/lib/enigma2/python/Plugins/Extensions/YouTube/icons/HD_videos.png
[ePicLoad] Cache File found
[Picload] hardware decode picture... /usr/lib/enigma2/python/Plugins/Extensions/YouTube/icons/.Thumbnails/pc_6AFE3F91
(decode_jpeg_noalloc): pre-scaling to width 192 height 144 from width 180 height 129, macro block limit border width = 12, height = 16
....
(blit_decoder_result): blitting result
(decode_jpeg_noalloc): JPEG decode finished
[ePicLoad] decode finished... /usr/lib/enigma2/python/Plugins/Extensions/YouTube/icons/.Thumbnails/pc_6AFE3F91
[getData] ox=260 oy=186 max_x=260 max_y=300 scrx=260 scry=186 xoff=0 yoff=57 xscale=1.000000 yscale=1.000000 aspect=1.000000 bits=24 orientation=1

[Taapat]

My images are 8 bits. I see in the log that the data are displayed as 24 bits.

Maybe it is a problem?

Edited by Taapat, 8 September 2015 - 18:22.

[mirakels]

yes I saw some strange things with resizing tumbnails. But even stranger this code was not changed by my patches.

Anyway, pushed some changes that may help resolve your issues.

[Pr2]

@mirakels,

 

Don't you think interesting to change the text of this new option:

 

Auto EXIF Orientation rotation/flipping

 

To reflect that it is only valid for JPG or forum will get questions/remarks that it doesn"t work.

 

Or have a full comment for this option that describe it clearly (extended description).

 

Thanks,

 

Pr2

[Taapat]

Anyway, pushed some changes that may help resolve your issues.

 

Unfortunately, latest changes currently not fix the png problems.

Edited by Taapat, 9 September 2015 - 10:15.

[Taapat]

Only for information.
My c++ knowledge is very low, but if I in function ePicLoad::getData revert back the code before the changes, the png works as before.

So it looks like the problem is somewhere in getData.

[mirakels]

That seems quite odd. The thumbnail cache data is handled in the thumbnail function itself. Only later on the decoded image data is taken in getData().

Saving thumbnail images in cache is broken for 8-bit png files. I don't quite understand how it could have worked before.

I almost have a fix ready for 8-bit pngs, but the same thing will happen with GIF files.

[mirakels]

@mirakels,

 

Don't you think interesting to change the text of this new option:

 

Auto EXIF Orientation rotation/flipping

 

To reflect that it is only valid for JPG or forum will get questions/remarks that it doesn"t work.

 

Or have a full comment for this option that describe it clearly (extended description).

 

Thanks,

 

Pr2

No, I don't think it is interesting at all

 

The option exactly does what it says it does. But if there is no EXIF data in the image then of coarse there is no orientation data.

EXIF is not entirely only jpeg. It can also be found in PNG files (the imagemagick tools put EXIF data in the png image when converting from jpeg).

However the EXIF reader in enigma2 only supports jpeg. Maybe in the future it learns how to read EXIF data from other filetypes.

 

But extended descritpion might be usefull...

[littlesat]

Is it possible to rotate pictures manually and add/change exif info in à picture once it was changed?

[arn354]

https://github.com/o...gdi/picload.cpp - maybe some Inspiration Can be found there.
It is without EXIF, but at least all png's are shown from png testsuite. 8-bit also was a issue.

[Taapat]

That seems quite odd. The thumbnail cache data is handled in the thumbnail function itself. Only later on the decoded image data is taken in getData().

 

You are right. I will not have checked png thumbnails. They do not work, but I'm not sure whether they worked before.
When changing back getData is displayed png images when data takes from variable.

[mirakels]

don't forget to cleanup your  .Thumbnails directory before retrying. otherewise the old, wrong, versions will still be used.

[XoXo_]

I'm not sure if it is related to this topic, but this problem occurs since 3 or 4 days after update on et9200.

 

1920x1080 skin

 1_0_1_2_14B4_2064_EEEE0000_0_0_0-2.jpg   69.51KB   2 downloads

 

1280x720 skin

 1_0_1_2_14B4_2064_EEEE0000_0_0_0.jpg   112.46KB   2 downloads

[vasilich07]

@mirakels

On my Vu + DUO2, picon weather no longer displayed.
Plugin yahoo_weather.

 

When will it be fixed?