97 replies to this topic

[Dimitrij]

Good approach!

As far as I understand, the new dxIsParentalProtected flag is applied "internally" in the parental setup.

 

What should I consider to support your approach when reading and writing settings in E-Channelizer?

Should the new flag be applied when hiding services 'dxDontshow' or adding services to the blacklist?

Flag  'dxDontshow' hide any service(use lamedb).

 

Flag 'dxIsParentalProtected' only blacklist services parental control.

This flag is automatically applied.

No changes in E-Channelizer is not necessary.

[littlesat]

Previously I thought the dxDontshow flag was not used..... so I used it to hide parental controlled services.....

 

Now we have a saperate flag for it... 

[Dimitrij]

littlesat

Maybe to hide the bouquets  parental control can be used isInvisible?

https://github.com/O.../iservice.h#L47

Edited by Dimitrij, 27 January 2016 - 18:49.

[littlesat]

I would say try it....

[mirakels]

OSD is now completely black. Don't see a thing anymore. Only PIG when pressing MENU or EPG...

[littlesat]

Mmmm... Are you sure it is related???

There are no changes to menu at all....

At this moment I cannot troubleshoot it.... But here I did not had those issues....

Unless this I think the changes to parentalcontrol could be more simple... Only changes to the flag should be enough...

Edited by littlesat, 27 January 2016 - 21:04.

[mirakels]

I have 2 enigma binaries, one from commit 4446778d2c and one from commit 9dd3b6e12b.

The last one does not show OSD, the first one does.

9dd3b6e12b is the pull from Dima's request

 

It could be a setting maybe in enigma settings, but then the defaulf may be wrong?

[littlesat]

Strange as the patch only adds a flaf in the e2 binary... And the same is running here for weeks....

[mirakels]

no it is more than just a flag... its a few commits.

 

but.... I rebooted the box again and now it does seem to work. very strange... but if it works again it works again.

[littlesat]

Strange.... But I reverted some python stuff and added the one from my repo instead....

[Dimitrij]

yep...

https://github.com/O...9191921dca1758d

why??????

1)lib/python/Screens/ParentalControlSetup.py :

a)if not use config.ParentalControl.hideBlacklist.value --> always set config.ParentalControl.hideBlacklist.value disable

b)if config.ParentalControl.hideBlacklist.value enable and user set this config disable --> run unhideBlacklist() for remove flag hidden and update service list

 

2)lib/python/Components/ParentalControl.py:

a)add new def unhideBlacklist()

*) little easier def hideBlacklist()

c)add for def  protectService/unProtectService variable(refresh=False) for update service list if necessary(todo -->add new functions to edit the black list)

 

Please accept my changes.
They not only do not interfere with anyone, but rather to improve the work of the parental contorol.
This is my third attempt.

Edited by Dimitrij, 28 January 2016 - 09:22.

[Dimitrij]

An example of the current bug...

 

Parental control setup:

Protect services - yes

Remember service PIN - newer

Hide parental locked services - yes(this option not visible)

open service list -->press menu --> "add to parental protection"

Service not visible!!!

It should not be!

	def protectService(self, service):
		if not self.blacklist.has_key(service):
			self.serviceMethodWrapper(service, self.addServiceToList, self.blacklist)
			if config.ParentalControl.hideBlacklist.value and not self.sessionPinCached:
				eDVBDB.getInstance().addFlag(eServiceReference(service), 2)

[littlesat]

Please explain less "cryptic"... I really do not understand what you mean.....

 

As far I know there are no wierd gaps...

What you described above... the non visible setting (I did not verify this) should become visible... -or- the specific confit should be set to False...

 

Then there is no "bug..."????

 

 

They not only do not interfere with anyone, but rather to improve the work of the parental contorol.

 

This is a bad argument..... the code should be good and clear....

Edited by littlesat, 28 January 2016 - 10:48.

[Dimitrij]

You just kidding?

Just check out what I wrote.

Edited by Dimitrij, 28 January 2016 - 10:50.

[littlesat]

Parental control setup:

Protect services - yes

Remember service PIN - newer

Hide parental locked services - yes(this option not visible)

open service list -->press menu --> "add to parental protection"

Service not visible!!!

It should not be!

 

->

 

Now I understand at least this part... we should add a check here for the never... of force the config under this condition to False...

I prefer the first...

[littlesat]

Just check out what I wrote.

->I read it multiple times... but I do not understand... sorry...

[littlesat]

[code]

def protectService(self, service):   if not self.blacklist.has_key(service):     self.serviceMethodWrapper(service, self.addServiceToList, self.blacklist) -    if config.ParentalControl.hideBlacklist.value and not self.sessionPinCached: +    if config.ParentalControl.hideBlacklist.value and not self.sessionPinCached and config.ParentalControl.storeservicepin.value != "never":       eDVBDB.getInstance().addFlag(eServiceReference(service), 2)

 

Edited by littlesat, 28 January 2016 - 10:56.

[Dimitrij]

littlesat

Just accept my changes.
 

[Dimitrij]

In my opinion it is ugly

			if config.ParentalControl.servicepinactive.value and config.ParentalControl.storeservicepin.value != "never" and config.ParentalControl.hideBlacklist.value and not self.sessionPinCached:

Check each time configs if they can be a time off in the settings.

+	def disableConfigHideBlacklist(self):
+		if config.ParentalControl.hideBlacklist.value and (not config.ParentalControl.servicepinactive.value or config.ParentalControl.storeservicepin.value == "never"):
+			config.ParentalControl.hideBlacklist.value = False
+			config.ParentalControl.hideBlacklist.save()

So it must be right.
And do not tell me about the readability of the code.

[littlesat]

I think my suggestion is not ugly....

 

You do not want that hidden configs are change for you... so when you toggle something back it stayed as it was.... Autochanges is uggly... (try it you can feel it is not good).... e.g. change something by accident and change it back and then you can re-configure a whole list is not nice at all...

Edited by littlesat, 28 January 2016 - 12:15.