142 replies to this topic

[Dimitrij]

Dimitrij,

 

Maybe while you are at it:

 

the 100% you've implemented is displayed as 1.0 when you open the timer again (not sure this is cosmetic). And worse, it doesn't work. If you set the timer to 100% (meaning title and descriptions MUST be 100% equal), duplicate timers are still being created (even though everything is 100% equal). If you set the timer to 90% instead of 100%, no new timer is created.

When set default 0.8,it works?

[WanWizard]

Yeah, any other value than 100% works. But 100% should work too, I manually recorded a duplicate and compared the meta data, and they are absolutely 100% identical.

[Dimitrij]

Yeah, any other value than 100% works. But 100% should work too, I manually recorded a duplicate and compared the meta data, and they are absolutely 100% identical.

Interestingly, it is my mistake in the code?

Let's see the log?

Edited by Dimitrij, 21 July 2016 - 12:35.

[WanWizard]

I don't know. I have to see what I can reproduce now, I've changed all my timers back to 90% for the time being. I'll try later today.

[WanWizard]

A debug log isn't being created, so I guess I need to restart Enigma for that. Can't do that now, recordings are running.

 

But I can show you the result. I have this autotimer entry:

 <timer name="Arrow" match="Arrow" enabled="yes" location="/media/hdd/movie/Series - Arrow/" avoidDuplicateDescription="3" ratioThresholdDuplicate="1.0" searchType="exact" searchCase="sensitive">
  <serviceref>1:0:1:1656:7E5:2:11A0000:0:0:0:</serviceref> <!-- Sky1 -->
  <serviceref>1:0:1:1290:7EA:2:11A0000:0:0:0:</serviceref> <!-- Sky2 -->
 </timer>

With a ratio of 1.0, it adds these timers:

<timer begin="1469472900" end="1469477700" serviceref="1:0:1:1290:7EA:2:11A0000:0:0:0:" repeated="0" name="Arrow" description="" afterevent="auto" eit="25008" location="/media/hdd/movie/Series - Arrow/" justplay="0" always_zap="0" zap_wakeup="always" rename_repeat="1" conflict_detection="1" descramble="1" record_ecm="0" flags="autotimer">
<timer begin="1469498100" end="1469502900" serviceref="1:0:1:1656:7E5:2:11A0000:0:0:0:" repeated="0" name="Arrow" description="" afterevent="auto" eit="50208" location="/media/hdd/movie/Series - Arrow/" justplay="0" always_zap="0" zap_wakeup="always" rename_repeat="1" conflict_detection="1" descramble="1" record_ecm="0" flags="autotimer">
<timer begin="1469559300" end="1469564100" serviceref="1:0:1:1290:7EA:2:11A0000:0:0:0:" repeated="0" name="Arrow" description="(Season 1 Episode 2/23). [Fantasy]" afterevent="auto" eit="45872" location="/media/hdd/movie/Series - Arrow/" justplay="0" always_zap="0" zap_wakeup="always" rename_repeat="1" conflict_detection="1" descramble="1" record_ecm="0" flags="autotimer">
<timer begin="1469584500" end="1469589300" serviceref="1:0:1:1656:7E5:2:11A0000:0:0:0:" repeated="0" name="Arrow" description="(Season 1 Episode 2/23). [Fantasy]" afterevent="auto" eit="5536" location="/media/hdd/movie/Series - Arrow/" justplay="0" always_zap="0" zap_wakeup="always" rename_repeat="1" conflict_detection="1" descramble="1" record_ecm="0" flags="autotimer">

With a ratio of 0.9, it only adds these timers:

<timer begin="1469472900" end="1469477700" serviceref="1:0:1:1290:7EA:2:11A0000:0:0:0:" repeated="0" name="Arrow" description="" afterevent="auto" eit="25008" location="/media/hdd/movie/Series - Arrow/" justplay="0" always_zap="0" zap_wakeup="always" rename_repeat="1" conflict_detection="1" descramble="1" record_ecm="0" flags="autotimer">
<timer begin="1469559300" end="1469564100" serviceref="1:0:1:1290:7EA:2:11A0000:0:0:0:" repeated="0" name="Arrow" description="(Season 1 Episode 2/23). [Fantasy]" afterevent="auto" eit="45872" location="/media/hdd/movie/Series - Arrow/" justplay="0" always_zap="0" zap_wakeup="always" rename_repeat="1" conflict_detection="1" descramble="1" record_ecm="0" flags="autotimer">

[Dimitrij]

WanWizard

Problem this:

Python 2.7.3 (default, Feb 15 2015, 11:52:13)
[GCC 4.9.1] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> int(1.0)
1
>>> int(0.8)
0
>>> from difflib import SequenceMatcher
>>> name1 = 'test'
>>> name2 = 'test'
>>> sequenceMatcher = SequenceMatcher(" ".__eq__, name1, name2)
>>> ratio = sequenceMatcher.ratio()
>>> ratio
1.0
>>> 1 < 1.0
False
>>> 0.8 < ratio
True
>>> 1.0 < 1.0
False

maybe this?

		ratio_value = force and 0.8 or timer.ratioThresholdDuplicate
		doDebug("[AutoTimer] names ratio %f - %s - %d - %s - %d" % (ratio, name1, len(name1), name2, len(name2)))
		if name1 in name2 or (0.8 < ratio): # this is probably a match
			foundShort = True
			if (force or timer.searchForDuplicateDescription > 0) and shortdesc1 and shortdesc2:
				sequenceMatcher.set_seqs(shortdesc1, shortdesc2)
				ratio = sequenceMatcher.ratio()
				doDebug("[AutoTimer] shortdesc ratio %f - %s - %d - %s - %d" % (ratio, shortdesc1, len(shortdesc1), shortdesc2, len(shortdesc2)))
-				foundShort = shortdesc1 in shortdesc2 or (ratio_value < ratio)
+				foundShort = shortdesc1 in shortdesc2 or ((ratio_value < ratio) or (ratio_value == 1.0 and ratio_value == ratio))
				if foundShort:
					doLog("[AutoTimer] shortdesc ratio %f - %s - %d - %s - %d" % (ratio, shortdesc1, len(shortdesc1), shortdesc2, len(shortdesc2)))
			elif not force and timer.descShortExtEmpty and not shortdesc1 and not shortdesc2 and name1 != name2:
				foundShort = False

			foundExt = True
			# NOTE: only check extended if short description already is a match because otherwise
			# it won't evaluate to True anyway
			if foundShort and (force or timer.searchForDuplicateDescription > 1) and extdesc1 and extdesc2:
				sequenceMatcher.set_seqs(extdesc1, extdesc2)
				ratio = sequenceMatcher.ratio()
				doDebug("[AutoTimer] extdesc ratio %f - %s - %d - %s - %d" % (ratio, extdesc1, len(extdesc1), extdesc2, len(extdesc2)))
-				foundExt = (ratio_value < ratio) or (ratio_value == 1.0 and ratio_value == ratio)
+				foundExt = (ratio_value < ratio) or (ratio_value == 1.0 and ratio_value == ratio)
				if foundExt:
					doLog("[AutoTimer] extdesc ratio %f - %s - %d - %s - %d" % (ratio, extdesc1, len(extdesc1), extdesc2, len(extdesc2)))
			elif not force and timer.descShortExtEmpty and not extdesc1 and not extdesc2 and name1 != name2:
				foundExt = False
			return foundShort and foundExt
		return False

Edited by Dimitrij, 21 July 2016 - 17:38.

[WanWizard]

I'm by no means a python expert, but assuming the ratio_value is a float between 0.0 and 1.0 (both values inclusive, it would probably be solved by using "ratio_value <= ratio" and you don't need this (to me) odd looking solution?

[jeanclaude]

Still looks like multople epg sources...

nope :  conflict1.jpg   58.02KB   8 downloads

 

 conflict2.jpg   69.42KB   6 downloads

 

I only use rytec with 1 source (for benelux).

 

Dimitrij,

I see there are still some issues - I'll update when these are solved. Just send me the new code when ready & we'll test it.

[Dimitrij]

jeanclaude

simple update plugin

[jeanclaude]

ok, updated

I'll keep you updated how things evolve

[jeanclaude]

2 days running after the update - and I'm finding some 'near doubles' again :

 conflict1.jpg   91.22KB   8 downloads

 

"cold case" planned at 10:46 and 10:56 on VIJF

"married with children" planned at 12:36 and 12:47 on VIER

so both recordings 10 minutes shifted on the same channel, and set by autotimer

 

zipped autotimer log :   autotimer.zip   264.09KB   3 downloads

 

[jeanclaude]

ps - "that's 70 show" at 9:46 and 9:51 is probably also a "near double"

[Dimitrij]

This timers use offset E2 and autotimer offset?

[Dimitrij]

And AutoTimer.py this  http://forums.openpl...attach_id=70341 archive is old

need update plugin/image

[Dimitrij]

new AutoTimer.py

[jeanclaude]

new autotimer.py installed & box restarted - we'll see how this goes.

standard settings for autotimer recordings are as follows :

 autotimer 1.jpg   88.16KB   9 downloads

 

start 9 minutes before EPG time, continue 15 minutes after EPG time ends.

[jeanclaude]

a few days later again ........ and NO MORE double or near-double timers in the timerlist !

looks like you cracked the problem, Dimitrij

I'll keep an eye on this for the coming weeks, but it's looking good.

much obliged 

[jeanclaude]

OK, all is NOT well !

I just noticed that there are no more recordings planned after tomorrow !

so I'm not seeing any more (near) doubles because you solved the problem, but because autotimer isn't creating any timers any more .......

 

I see the following at the end of the autotimer logfile :

 

2016-07-26 10:17:06,322 - INFO - [AutoTimer] possible epgmatch Les revenants

2016-07-26 10:17:06,325 - INFO - [AutoTimer] Serviceref 1:0:19:5226:C99:3:EB0000:0:0:0:

2016-07-26 10:17:06,331 - INFO - [AutoTimer] We found a timer based on eit

2016-07-26 10:17:06,334 - INFO - [AutoTimer] Warning, AutoTimer Les revenants messed with a timer which might not belong to it: Les revenants .

2016-07-26 10:17:06,794 - INFO - [AutoTimer] conflict not found for modify timer Les revenants.

2016-07-26 10:17:06,799 - INFO - [AutoTimer] AutoTimer modified timer: Les revenants .

2016-07-26 10:17:07,333 - INFO - [AutoTimer] possible epgmatch Les revenants

2016-07-26 10:17:07,336 - INFO - [AutoTimer] Serviceref 1:0:19:D4:2:10EF:FFFF0000:0:0:0:

2016-07-26 10:17:07,340 - INFO - [AutoTimer] Skipping an event because of check services

2016-07-26 10:17:07,343 - INFO - [AutoTimer] possible epgmatch Les revenants

2016-07-26 10:17:07,345 - INFO - [AutoTimer] Serviceref 1:0:1:260:9:10EF:FFFF0000:0:0:0:

2016-07-26 10:17:07,349 - INFO - [AutoTimer] Skipping an event because of check services

2016-07-26 10:17:07,351 - INFO - [AutoTimer] possible epgmatch Les revenants

2016-07-26 10:17:07,354 - INFO - [AutoTimer] Serviceref 1:0:1:4A3B:805:600:FFFF0000:0:0:0:

2016-07-26 10:17:07,358 - INFO - [AutoTimer] Skipping an event because of check services

2016-07-26 10:17:07,360 - INFO - [AutoTimer] possible epgmatch Les revenants

2016-07-26 10:17:07,362 - INFO - [AutoTimer] Serviceref 1:0:19:4B1A:80F:600:FFFF0000:0:0:0:

2016-07-26 10:17:07,366 - INFO - [AutoTimer] Skipping an event because of check services

2016-07-26 10:17:07,370 - INFO - [AutoTimer] possible epgmatch Les revenants

2016-07-26 10:17:07,373 - INFO - [AutoTimer] Serviceref 1:0:19:5226:C99:3:EB0000:0:0:0:

2016-07-26 10:17:07,379 - INFO - [AutoTimer] We found a timer based on eit

2016-07-26 10:17:07,382 - INFO - [AutoTimer] Warning, AutoTimer Les revenants messed with a timer which might not belong to it: Les revenants .

2016-07-26 10:17:07,850 - INFO - [AutoTimer] conflict not found for modify timer Les revenants.

2016-07-26 10:17:07,855 - INFO - [AutoTimer] AutoTimer modified timer: Les revenants .

2016-07-26 10:17:08,436 - INFO - [AutoTimer] Start reload timers list after search

2016-07-26 13:50:36,413 - INFO - AutoTimer Version: 4.1.2

2016-07-26 13:50:36,435 - INFO - [AutoTimer] parse EPG it is already running, return zero

2016-07-27 13:50:34,482 - INFO - AutoTimer Version: 4.1.2

2016-07-27 13:50:34,493 - INFO - [AutoTimer] parse EPG it is already running, return zero

2016-07-28 13:50:32,526 - INFO - AutoTimer Version: 4.1.2

2016-07-28 13:50:32,540 - INFO - [AutoTimer] parse EPG it is already running, return zero

2016-07-29 13:50:30,565 - INFO - AutoTimer Version: 4.1.2

2016-07-29 13:50:30,576 - INFO - [AutoTimer] parse EPG it is already running, return zero

2016-07-30 13:50:29,600 - INFO - AutoTimer Version: 4.1.2

2016-07-30 13:50:29,613 - INFO - [AutoTimer] parse EPG it is already running, return zero

2016-07-31 00:37:07,279 - INFO - [AutoTimer] No changes in configuration, won't parse

 

look at the dates

 

right now I'm restoring the previous version of the autotimer plugin.

[Dimitrij]

fixed https://github.com/O...7458de12e0f4e70

update plugin/image

 

But,see log:

2016-07-26 13:50:36,413 - INFO - AutoTimer Version: 4.1.2
2016-07-26 13:50:36,435 - INFO - [AutoTimer] parse EPG it is already running, return zero
2016-07-27 13:50:34,482 - INFO - AutoTimer Version: 4.1.2
2016-07-27 13:50:34,493 - INFO - [AutoTimer] parse EPG it is already running, return zero
2016-07-28 13:50:32,526 - INFO - AutoTimer Version: 4.1.2
2016-07-28 13:50:32,540 - INFO - [AutoTimer] parse EPG it is already running, return zero
2016-07-29 13:50:30,565 - INFO - AutoTimer Version: 4.1.2
2016-07-29 13:50:30,576 - INFO - [AutoTimer] parse EPG it is already running, return zero
2016-07-30 13:50:29,600 - INFO - AutoTimer Version: 4.1.2
2016-07-30 13:50:29,613 - INFO - [AutoTimer] parse EPG it is already running, return zero

first run poll 2016-07-26 13:50:36,413 < last run poll 2016-07-30 13:50:29,613

How is this possible?

Edited by Dimitrij, 1 August 2016 - 07:49.

[jeanclaude]

check the dates, Dimitrij, check the dates ..........

update started july 25, and subsequent runs on july 26, 27, 28, 29 & 30 didn't run but returned the error "parse is already running".

so it looks to me that the run of july 25 was in a loop somewhere, blocking the automatic runs which are triggered every 24 hours.

 

ran an update, let's hope things are better now.