55 replies to this topic

[bigmic63]

Hello,

my openpli crashes every time I'm using the menu button in case I've watched someting in mediaportal before.

I'm using the actual openpli, just updated with an Edision Os mini.

Any suggestions about this?

Regards

Michael

Attached Files

•  enigma2_crash_1463297149.log   16.34KB   5 downloads

[Taapat]

Eliminating one GSOD, when config session as it is abducted by a 3rd party plugins, are created other GSOD when plugins simply use this config session.

 

I think that this commit is not a good solution: https://github.com/O...2a1ff02e3eea3b4

Edited by Taapat, 15 May 2016 - 10:07.

[Taapat]

While here really looks like mediaportals replace MediaPlayer functions and therefore create GSOD after littlesat commit.

Edited by Taapat, 15 May 2016 - 10:11.

[littlesat]

Please ask these crazy plugins to solve the issue they induce..... In addition I do not understand how they still get this gsod...

[Taapat]

As I write I think mediaportals replace any MediaPlayer function that uses config.mediaplayer instead of replacing config.mediaplayer.
Now you remove config.mediaplayer and there are GSOD.

 

Now the developer should create a special plugin version for openpli if he really needed functions replace.

[WanWizard]

Functions should not be replaced, that is the cause of all misery.

[Taapat]

Sorry, I just now saw sourcedate=2016-05-10 in crashlog.
This crash is not from the last enigma with littlesat changes.

 

I recommend first update enigma2 to the last.

[littlesat]

Indeed I thought something else.... He needs to correctly upgrade or reflash... That source is not aware of th new config...

This change was the best I could do... When a plugin streals a function due to a type and does not change it is is the only thing you can do without doing any other change try except things...

Edited by littlesat, 15 May 2016 - 12:20.

[Taapat]

Your changes slove GSOD if plugin modifies config.mediaplayer.
But they create GSOD if plugin steals functions or simply use one of config.mediaplayer values without changes.

 

 

I do not know whether such plugin exists, and written only in theory, but it seems to me that removing one error you've implemented several others.

[littlesat]

Your changes slove GSOD if plugin modifies config.mediaplayer.

-->

Whcih plugins are doing this.... As long as this is theory it does not harm... and hopefully these plugins are opensource so it can be adapted.... And note plugins should basically not steal functions. When it does this it aksed for problems....

 

Basically these f#cking closed source splugins should fix their typo crap!!! They should shame depely... And note the OpenATV fix does also not work fully as expected.... think about the moment the configs are saved!!!

[christophecvr]

Yes if config settings are needed for a plugin other then embedded e2 plugin users should make there own config screen in the plugin.

[ian1095]

Just for info.

 

Ive just removed my previous fixes for this crash and added littlesat's to my mediaplayer plugin that were taken from the Pli Github, and all is well.

 

All crashes from the menu button after using the Mediaportal plugin are now fixed.

 

Thank You.

 

Ian.

[bigmic63]

I've just made an update, everything is ok now.

[dhwz]

Basically these f#cking closed source splugins should fix their typo crap!!! They should shame depely... And note the OpenATV fix does also not work fully as expected.... think about the moment the configs are saved!!!

Maybe you should lower your voice first. 

 

1st: I just don't care if our plugin is running on your f#cking crappy image, we are not stealing any config sections (we only use the config values of mediaplayer for setting alternate user agent and thats how it is done on the only two images/hardware brands which are supported).

2nd: The plugin is open source not closed source, but anyway who cares, the users are not even allowed to use it with your f#cking crappy image.

3rd: Respect our LICENSE

Edited by dhwz, 16 May 2016 - 18:47.

[littlesat]

But you steal the mediaplayer config section in your perfect code... That is a simple fact! And this is not required at all to do that this way...  And when it is really required then show me your agent stuff... You should show when you forked the mediaplayer plugin from GPL... 

 

Didn't I not respect your license?

Edited by littlesat, 16 May 2016 - 19:46.

[WanWizard]

Gentlemen, let's keep it civilized please.

 

@dhwz:

 

This issue was reported to us by a DM8000 user, which is perfectly valid within the license. And if the plugin is open source, can you point us to the source repository?

 

@littlesat:

 

Can you explain in more detail what is wrong? Appearently @dhwz doesn't understand the problem you are trying to fix.

[littlesat]

Can you explain in more detail what is wrong?

->

Before I can help here I need to see the sources from the different media player... sounds like they have a feature there we do not have but still could consider to add...

 

But then still it is crasy to (steal of I describe it "softer" as) redefine the mediaplayer config section within this plugin...

Edited by littlesat, 16 May 2016 - 19:53.

[dhwz]

@littlesat

Who said that we forked mediaplayer?

 

@WanWizard

Sure but again this problem is non existent on the supported Images

I sure understand what he is talking about and I've already explained what we do and why we do it. The settings config.mediaplayer.useAlternateUserAgent und config.mediaplayer.alternateUserAgent are modified by our plugin, these values are directly read by E2 even if the mediaplayer not installed on that box. The settings are necessary fore some websites which require an alternate user agent for playback (e.g. Apple website).

 

If the mediaplayer is installed we just modifiy the existing config values, that was never ever a problem.

If the mediaplayer is NOT installed we recreate the config section so E2 can read the values from settings (this also was never a problem on our supported images).

 

From what I understand you now have problem with point 2 (recreation of the config section, which only happens if the mediaplayer is not installed [on our supported images])

 

The problem is PLi itself broke the compatibility when removing the way how useragent is modified, PLi itself broke compatiblity when still using DMMs config.mediaplayer section.

 

So now if the two config setting are not found we recreate the config section on your image but mediaplayer is still installed -> GSOD -> not our fault.

 

And as said I really don't care. 

Edited by dhwz, 16 May 2016 - 20:00.

[littlesat]

Who said that we forked mediaplayer?

-->

Nobody can say it.... because as far I know there are actually no sources.... So you can say anything and we can guess... But it is still a modification on engima2 as the mediaplayer was standard a part of enigma2,,,  Please respect GPL!

 

If the mediaplayer is installed we just modifiy the existing config values, that was never ever a problem.

-->

As far I can see you redefine the complete config section... so all config features we added to the mediaplayer are gone.... But I understand you don't care because we're a crappy image...

Edited by littlesat, 16 May 2016 - 20:37.

[WanWizard]

@dhwz,

 

I understand you don't care. Nice attitude towards your users.

 

@littlesat,

 

he says they only (re)create it when they detect the mediaplayer is not installed. From that I understand that for some reason this happens on OpenPLi, so it might be wise to see how that check works, to make sure we do everything correct?