44 replies to this topic

[Erik Slagter]

${@base_contains("MACHINE_FEATURES", "dreambox", "", "enigma2-plugin-extensions-backupsuite", d)} \

This suggests it's only built for dreamboxes. Even then, if the ARCH isn't correct, it will end up in the "all" feed. A task from somebody to get that right?

[blzr]

actually, this suggests quite opposite -- it's built for all but the dreamboxes

[Erik Slagter]

Yeah, razorsharp as ever   I overlooked the first "". But the other remark remains. Make sure the ARCH of the package is correct.

Edited by Erik Slagter, 17 July 2016 - 08:07.

[blzr]

--- a/meta-openpli/recipes-openpli/enigma2-plugins/enigma2-plugin-extensions-backupsuite.bb
+++ b/meta-openpli/recipes-openpli/enigma2-plugins/enigma2-plugin-extensions-backupsuite.bb
@@ -15,7 +15,7 @@ DEST = "${D}/usr/lib/enigma2/python/Plugins/Extensions/BackupSuite"
 
 PV = "20+git${SRCPV}"
 PKGV = "20+git${GITPKGV}"
-PR = "r0"
+PACKAGE_ARCH = "${MACHINE}"
 
 RDEPENDS_${PN} = "mtd-utils mtd-utils-ubifs ofgwrite"

and to remove plugin from wetek feed also:

--- a/meta-openpli/recipes-openpli/images/openpli-enigma2-feed.bb
+++ b/meta-openpli/recipes-openpli/images/openpli-enigma2-feed.bb
@@ -105,7 +105,7 @@ ENIGMA2_OPTIONAL = " \
        softcams-enigma2-meta \
        packagegroup-openplugins \
        ${@base_contains("MACHINE_FEATURES", "blindscan-dvbs", "enigma2-plugin-systemplugins-satscan" , "", d)} \
-       ${@base_contains("MACHINE_FEATURES", "dreambox", "", "enigma2-plugin-extensions-backupsuite", d)} \
+       ${@bb.utils.contains_any("MACHINE_FEATURES", "dreambox meson6", "", "enigma2-plugin-extensions-backupsuite", d)} \
        dvb-usb-drivers-meta \
        cdtextinfo \
        meta-enigma2-dvdburn \

ok?

(can't create/test patches at the moment...)
 

[Pedro_Newbie]

I was wondering if the removal of -PR = "r0" doesn't this have consequences for the version numbering /sequence concerning the updating of new versions?

[athoik]

The PR = "r0 is the default.

Personally I think making a plugin that works great on a ton of receivers "machine specific" is wrong.

Not to mention that it will increase the size of feeds, build time etc.

[Pedro_Newbie]

The simplest solution could be to change in the recipe the first line:

DESCRIPTION = "Backup Suite"
LICENSE = "GPLv2"

into

DESCRIPTION = "Backup Suite (not for Dreambox or Wetek Play)"
LICENSE = "GPLv2"

Then it is clear to the user it is not for his/hers Dreambox or Wetek Play

Edited by Pedro_Newbie, 17 July 2016 - 20:57.

[blzr]

Personally I think making a plugin that works great on a ton of receivers "machine specific" is wrong.

well, unless it's because of some manufacturer's bug/fault, if some plugin works on some machines and on some does not then it is exactly 'machine specific', isn't it?

Not to mention that it will increase the size of feeds, build time etc.

package(s) weight is ~80KB, and build time increase is negligible (here plugin build takes what, 6? 8s?),
these 'costs' IMHO don't justify leaving this set up wrong... /?/

[athoik]

Well 80 x 10 will get you 800KB or 10 copies!

Why not add a check in plugin startup: if model in (x,y) then no support.

[Lost in Space]

With such arguments that yu don't want box specific code and patches you kicked out the support for DMM boxes ... and now you recommend it to a developer ... great learning curve

Edited by gutemine, 17 July 2016 - 21:28.

[Pedro_Newbie]

Just installing the BackupSuite on a Dreambox seems to let the Dreambox crash even without running it.
Before placing it on Github I had an installation routine which checked if the receiver was supported and if not it wouldn't install.

[Lost in Space]

The easiest way to prevent installation on  Dreamboxes is a simple line in the control file:

 

Conflicts: dreambox-secondstage

 

But as you are getting here competent advice already, I will not interfere any further

Edited by gutemine, 17 July 2016 - 21:34.

[athoik]

Backup Suite is not Enigma2 code but a "backup" plugin made by Pedro_Newbie.

There is no machine specific code, only python (and sh). That plugins desert to be on arch all.

Since his author doesn't support Dreamboxes and Wetek there is nothing wrong to inform users about his choice.

Edited by athoik, 17 July 2016 - 21:36.

[Lost in Space]

It just had some personal amusing value, sorry that I took the opportunity to laugh ... as I still remember the discussion ...

 

And regarding the suggested secondstage conflict, as PLi included the boxname in the secondstage package name to break dependency with dreambox only plugins that have it as a prerequisite in their control file, he would have to include the loaders for all PLi (still available) dreamboxes, but this should be not a big challenge as it is a short list.

Edited by gutemine, 17 July 2016 - 21:41.

[athoik]

And regarding the suggested secondstage conflict, as PLi included the boxname in the secondstage package name to break dependency with dreambox only plugins that have it as a prerequisite in their control file, he would have to include the loaders for all PLi (still available) dreamboxes, but this should be not a big challenge as it is a short list.

LOL ... Now you make laugh... Let's talk another day about breaking dependencies! Sleep tight.

http://git.opendream...ads/dora-stable

[Pedro_Newbie]

The fact that the Dreamboxes are not supported by the BackupSuite is not because I don't like these receivers but pure because of the lack of skills on my behalf. I'm no coder/developer or whatever you would call it but mere a hobbyist which tried to make something which could benefit other users. The last years it grew to what it is now and supporting 50+ models.So it has nothing to do on my behalf with politics or any other reason, just the lack op knowledge and skills.

 

So now I'm going to sleep because the alarm clock does it's thing at 5 AM tomorrow to send me to my daytime job

[Lost in Space]

The amausement stays on my side - because the name of the bb file is not causing package dependency problems:

 

DMM control file of a secondstage package on the dm7020hd

 

Package: dreambox-secondstage
Version: 89-r12.0
Description: Dreambox second stage bootloader
 Dreambox second stage bootloader
Section: base
Priority: required
Maintainer: OE-Core Developers <openembedded-core@lists.openembedded.org>
License: CLOSED
Architecture: dm7020hd
 

 

Your control file from PLi feed:

 

Package: dreambox-secondstage-dm7020hd
Version: 89-r20.0
Description: Dreambox second stage bootloader
 Dreambox second stage bootloader.
Section: base
Priority: required
Maintainer: OE-Core Developers <openembedded-core@lists.openembedded.org>
License: CLOSED
Architecture: dm7020hd
OE: dreambox-secondstage-dm7020hd
Depends: mtd-utils
Source: http://sources.dream...age-dm7020hd-89.

 

So you decided to put the boxname in the Package name instead of using the Architecture as it should be.

 

Wich means everybody putting only secondstage-dreambox in his Depends has .... a problem and now has to build boxspecific packages or remove the Depends ?

 

Which means also great thingsl ike that:

 

opkg update

opkg download dreambox-secondstage-dm7020hd
Downloading http://downloads.pli....0_dm7020hd.ipk.
wget: server returned error: HTTP/1.1 404 Not Found
Collected errors:
 * opkg_download: Failed to download http://downloads.pli...ox-secondstage-dm7020hd_89-r20.0_dm7020hd.ipk

 

But better you all get your sleep

 

PS: There is no real difference in a backup for Dreamboxes or the other boxes, instead that you use the buildimage binary at the end to make a single nfi file out of it or a tar command to create a single tar.xz file. Which is very similar to the ZIP files the other boxmakers are using. But I'm not blaming anybody for not supporting some boxes - as I do the same - just my list is longer

 

gutemine

Edited by gutemine, 17 July 2016 - 23:21.

[Rob van der Does]

But I'm not blaming anybody for not supporting some boxes - as I do the same - just my list is longer

Exactly!


But euuuhhh.... what about your promise several posts ago:

....I will not interfere any further

[Lost in Space]

I simply have a proven track record to ignore good advice - including my own

[arkovda]

Thanks for all your answers.

 

No you can't do anything with this code, it's only to prevent the building of the BackupSuite for the Dreambox models. But apparently something slipped through the filter, what version is on the feed of the Dreambox models?

 

Don't know if I understand you correctly but here is the version of the backupsuite plugin: 20+git105

 

What about Growlee?

Is it the same?

the version of Growlee is: y-git4354+5d3d963-r0.0