25 replies to this topic

[Just Me]

Hey!

 

If I open the Common Interface menu the picture is correct and the settings are shown in the "standard" size:

 1_0_19_283D_3FB_1_C00000_0_0_0-2.jpg   38.81KB   6 downloads

But if I select the Alphacrypt settings menu the picture becomes tiny and you are not able to read the whole settings:

 1_0_19_283D_3FB_1_C00000_0_0_0.jpg   31.93KB   6 downloads

 

Box: Vu+ Duo 2

Image: Latest OpenPLi (all updates installed)

Skin: PLi FullNight HD

Edited by Just Me, 11 September 2016 - 14:50.

[littlesat]

Can you find the screen in the skin and adjust it?

[Just Me]

Sorry, I'm not sure what you mean exactly. What I can say is that I'm not able to adjust a skin, no clue how skins work, what files must be edited and how to edit. 

[littlesat]

It are xml files... /use/share/enigma2/name of skin....

[Just Me]

Thank you. I found a very impressive skin.xml file, the only thing related to CI seems to be this part:

	<!-- Common interface -->

	<screen name="MMIDialog" position="fill">
		<panel name="PigTemplate"/>
		<widget name="title" position="780,105" size="430,35" font="Regular;32" />
		<widget name="subtitle" position="780,145" size="430,35" font="Regular;32" />
		<widget name="entries" position="780,185" size="430,150" itemHeight="35" font="Regular;32" scrollbarMode="showOnDemand" />
		<widget name="bottom" position="780,225" size="430,35" font="Regular;32" />
	</screen>
	<!-- Common interface - selection -->
	<screen name="CiSelection" position="fill" title="Common Interface">
		<panel name="PigTemplate"/>
		<widget name="text" position="780,105" size="1100,35" font="Regular;32" />
		<widget name="entries" position="780,160" size="1100,570" itemHeight="38" font="Regular;28" scrollbarMode="showOnDemand" />
	</screen>

Well, I don't know what to do with this code. Maybe edit the size of the MMIDialog from size="430,35" to ???? No clue. Don't even know that this numbers mean? Pixels? Width and hight? 

 

I'm not sure if I should edit anything if I have no clue what I'm doing. 

[Rob van der Does]

Here's a correct working version of that screen:

    <screen name="MMIDialog" position="fill">
        <panel name="PigTemplate"/>
        <widget name="title" position="780,105" size="900,35" font="Regular;32" />
        <widget name="subtitle" position="780,145" size="900,35" font="Regular;32" />
        <widget name="entries" position="780,185" size="900,385" itemHeight="35" font="Regular;32" scrollbarMode="showOnDemand" />
        <widget name="bottom" position="780,575" size="900,35" font="Regular;32" />
    </screen>

 

[Just Me]

Awesome! Thank you very much      Now the settings screen shows all information. 

[littlesat]

Can you please post the mods here... Thanks for helping!

[Just Me]

Post the mod? Rob von der Does already posted the needed modification to fix the screen. 

[Erik Slagter]

Diff/patch is easier.

[WanWizard]

easier == less work.

 

It saves you from opening the file in the editor, looking for the stuff to replace, paste new stuff in, make sure you don't make mistakes, double check and test, then commit.

 

Compared to "git apply". With the added benefit that this will also log you as the author, instead of the dev committing it.

[littlesat]

And more.... due it requires now copy and past work.... possible failures/mistakes....

 

I'm busy with merging it right now... so don't worry.... First I'm happy I promoted someone to made his own fix...

Edited by littlesat, 12 September 2016 - 14:54.

[WanWizard]

Which is what I wrote...

[littlesat]

FYI: https://github.com/l...71142d6ea4141e1

[Rob van der Does]

easier == less work.
 
It saves you from opening the file in the editor, looking for the stuff to replace, paste new stuff in, make sure you don't make mistakes, double check and test, then commit.

That's only the case when you merge a pullrequest blindfolded.
When you check the request before merging, which is what I find to be the normal and good procedure, the request is even more work.

[littlesat]

Rob,

 

With copy and paste I need to copy and paste it ... (bit of extra work for us)...

When still need to test (not extra work for us)...

When I make a copy and paste mistake I need to debug (could be much of unnecessary extra work for us - as previously the merge requester did it all right - not effective)

Then I have to create a commit (bit of extra work for us)...

 

For us more work and higher risk of mistakes...

 

But from the other side the merge requester needs to learn github and he has the extra work instead...

Edited by littlesat, 12 September 2016 - 15:36.

[Rob van der Does]

Sorry Littlesat, I don't agree for such a minor change: just swapping one screen for another screen isn't worth the effort of making a pullrequest.
If it would be a more complicated change I agree.

[littlesat]

I agree for a small change such as in this example the risks of complications are indeed low.. (but there might still a risk....)

 

But still a small mistake could give unexpected results... So still it is preferable to have clear patches, merge requests -or- a place where you can cherry-pick from... And a merge request directly on our git is the easiest way to go for us... 

Edited by littlesat, 12 September 2016 - 15:53.

[Rob van der Does]

For you, yes, but not for the corrector.
It's your skin, it's your mistake that's being corrected; so instead of always asking for more I would express some gratitude and happiness.
At least that's what I do when I'm being helped

Edited by Rob van der Does, 12 September 2016 - 16:03.

[littlesat]

"Think open-source"

 

As I offer the skin to the community it is basically not my skin anymore... but the communities' skin...

So it is a great attitude when the community helps the community to improve the communities' skin...

As the skin is offered to the community it is not the community helping me. Instead helping me it is the community helping the community...

 

B.t.w. what a discussion... the changes are pushed... File Done...

Edited by littlesat, 12 September 2016 - 16:13.