108 replies to this topic

[littlesat]

Isn't that what Abu said before?

-->

But on other places it comes back as MHz.... But I'm afraid the community makes a mess out of it because "they" missed ConfigFloat... 

 

Not it considered to be changed for ATSC, DVB-T and probably all "gettransponder info" stuff aswell.....

[Huevos]

If using kHz is so wrong why has PLi used it for so many years to enter terrestrial frequencies? Seems like work for work's sake to me, and makes the code behind the scenes more error prone, just for the sake of displaying a decimal point in the user interface.

Edited by Huevos, 11 October 2016 - 08:58.

[littlesat]

Indeed wierd why we did not change this for years.... Alt least for dvb-t and atsc... I'm afraid when this was made, the mistake was made far far away.... And as dvb-c was nicely in MHz, it was just noticed due to these offline frequencies.... Sjips happens....

But as far I can see the required patches are relativaly simple.... When we keep the low level as is... Only atsc I have to change "blindly"....

I do not want to make changes in the transponder tool (there also the drivers do return the frequencies.... Dvb-c in KHz and dvb-t in Hz).... Let's just focus on the ui...

Edited by littlesat, 11 October 2016 - 09:41.

[Abu Baniaz]

I do not want to make changes in the transponder tool... Let's just focus on the ui...

Hopefully fix the crash too.

[littlesat]

Which crash?

[Abu Baniaz]

Which crash?

Documented in post 59. Crashlog also attached.

[littlesat]

Thanks...

 

Sounds like I miss something...

 

Can you please try for me...?

 

line 1486 in ScanSetup.py...

-compare = [1, self.scan_cab.frequency.value*1000, self.scan_cab.symbolrate.value*1000, self.scan_cab.modulation.value, self.scan_cab.fec.value, self.scan_cab.inversion.value, self.scan_cab.system.value]
+compare = [1, self.scan_cab.frequency.value[0]*1000 + self.scan_cab.frequency.value[1], self.scan_cab.symbolrate.value*1000, self.scan_cab.modulation.value, self.scan_cab.fec.value, self.scan_cab.inversion.value, self.scan_cab.system.value]

Edited by littlesat, 11 October 2016 - 10:58.

[Abu Baniaz]

1. Predefined transponder shows up.
2. No crash.
3. user defined still not loading exact frequency

Many thanks.

Attached Files

•  pli predefined.jpg   54.93KB   2 downloads
•  pli user defined.jpg   54.45KB   4 downloads

Edited by Abu Baniaz, 11 October 2016 - 11:09.

[littlesat]

User defined will carch nearer freq from the "list"...???

Sorry currenly I have no box available to test and debug an my cable provider has exact frequencies....

But do youmin short mean when you go from predefined to user frequenties it jumps defaultly to 370.000?

Edited by littlesat, 11 October 2016 - 11:48.

[Abu Baniaz]

normally, when you go to manual scan, user defined, it should autoload the frequency of the channel you are on. it is rounding down the frequency. If channel was on 370.750, it autoloads 370.000. If I was 410.750, it autoloads 410.000

I have transferred the cables.xml file (attached in thread already). I can select exact predefined xxx.750 frequencies (starts from 114.750 to 746.750) I can also manually enter them thanks to your changes.

Sent from my HTC One M9PLUS using Forum Fiend v1.3.3.

[Huevos]

1. Predefined transponder shows up.
2. No crash.
3. user defined still not loading exact frequency

Many thanks.

3) is because no sub-decimal value has been entered here.

https://github.com/O...anSetup.py#L989

[littlesat]

Indeed stupid me... the same issue I had with dab-t thanks

[Huevos]

- defaultCab["frequency"] = frontendData.get("frequency", 0) / 1000
+ defaultCab["frequency"] = frontendData.get("frequency", 0)

- self.scan_cab.frequency = ConfigFloat(default = [defaultCab["frequency"], 0], limits = [(50, 999), (0,999)])
+ self.scan_cab.frequency = ConfigFloat(default = [defaultCab["frequency"]/1000, defaultCab["frequency"]%1000], limits = [(50, 999), (0,999)])

[littlesat]

exactly

[littlesat]

FYI: https://github.com/O...9d4d8061cc19522

 

Nice....now it also fixes an issue when you scan the transponder you currently watching as it adjust to KHz....

 

Next step.... do the same for DVB-T and ATSC...

[athoik]

Why to change DVB-T and ATSC to MHz? We are already using kHz!

 474000.jpg   68.47KB   1 downloads

To be honest it's really strange that we didn't change DVB-C to use kHz and took this strange approach with floats.

[littlesat]

The read the while thread... We want MHz... With decimal point... in fact this is all about that decimal point... for dvb-t we had to do that years ago....

In additin we need to remove all these transponder details.... (When all is auto!)

Edited by littlesat, 11 October 2016 - 16:27.

[athoik]

What's wrong with kHz?

DVB-C doesn't look good in manual scan.

 000.466.jpg   59.27KB   4 downloads

Edited by athoik, 11 October 2016 - 16:31.

[Huevos]

What's wrong with kHz?

DVB-C doesn't look good in manual scan.

000.466.jpg

That is because it is wrong here...

	def createConfig(self, frontendData):
		defaultSat = {
			"orbpos": 192,
			"system": eDVBFrontendParametersSatellite.System_DVB_S,
			"frequency": 11836,
			"inversion": eDVBFrontendParametersSatellite.Inversion_Unknown,
			"symbolrate": 27500,
			"polarization": eDVBFrontendParametersSatellite.Polarisation_Horizontal,
			"fec": eDVBFrontendParametersSatellite.FEC_Auto,
			"fec_s2": eDVBFrontendParametersSatellite.FEC_9_10,
			"modulation": eDVBFrontendParametersSatellite.Modulation_QPSK,
			"pls_mode": eDVBFrontendParametersSatellite.PLS_Root,
			"pls_code": 1 }
		defaultCab = {
			"frequency": 466

[Huevos]

What's wrong with kHz?

Nothing. And when it comes to doing terrestrial using configFloat the code is going to be more difficult.

 

This is just vanity. Just to display a decimal point in the user interface look at the extra complexity needed in the code. And all this just to tell a contributor his code is wrong.

Here's what a mess it brings. if you add DVB-T.

https://github.com/H...379af4611d08fa3

Edited by Huevos, 11 October 2016 - 17:10.