77 replies to this topic

[Erik Slagter]

Also here, take a step back and try to figure why they took this approach, even though you don't agree. Not everything you don't get immediately is always "bad".

[Huevos]

In fact we need isEnabledfor(....) for what it is configured for...

 

and isCompatible(...) for what it can do

 

Naming is important...

You just don't get it.

 

If the tuner is enabled for DVB-S and DVB-T...

 

User wants to scan DVB-T...

 

You cannot have this anymore.

if nim.isEnabled("DVB-S"):
   doSatScan()
elif nim.isEnabled("DVB-T"):
    doTerrestrialScan()

Both of those would return true. Once there is more than one type allocated to a tuner you can't just check the tuner type is capable of doing the task. You need to know that it is the task that the user wanted done.

 

Right now E2 just does a task "because it is possible on the hardware" not because that is what the user wanted to happen.

 

In my ScanSetup patch the code listens to the user input rather than just checking what the hardware is capable of.

 

PLi needs modifying at the very least in all the following files.

    OpenPLi-enigma2-github/lib/python/Components/NimManager.py
    OpenPLi-enigma2-github/lib/python/Components/UsageConfig.py
    OpenPLi-enigma2-github/lib/python/Plugins/SystemPlugins/DiseqcTester/plugin.py
    OpenPLi-enigma2-github/lib/python/Plugins/SystemPlugins/FastScan/plugin.py
    OpenPLi-enigma2-github/lib/python/Plugins/SystemPlugins/PositionerSetup/plugin.py
    OpenPLi-enigma2-github/lib/python/Plugins/SystemPlugins/SatelliteEquipmentControl/plugin.py
    OpenPLi-enigma2-github/lib/python/Plugins/SystemPlugins/Satfinder/plugin.py
    OpenPLi-enigma2-github/lib/python/Screens/Satconfig.py
    OpenPLi-enigma2-github/lib/python/Screens/ScanSetup.py
    OpenPLi-enigma2-github/lib/python/Tools/Transponder.py

That is a huge task. I can't see how you could do such a task in the PLi production environment, how PLi is currently run.

[littlesat]

I really get it.... Look at this simple solution....

 

if nim.isEnabled("DVB-S"):
   doSatScan()
-elif nim.isEnabled("DVB-T"):

+if nim.isEnabled("DVB-T"):
    doTerrestrialScan()

 

And I also get it that to do it properly it is a big impact, with a risk of breaking some (3rd party) plugins aswell....

Edited by littlesat, 22 October 2016 - 16:59.

[Huevos]

Your example shows you dont unnderstand. It is doing the tadk baded on the hardware capability. If the user wants to do a dvb-t scan your code is going to select a satellite scan.

[littlesat]

Nope... my suggestion can do sat + dvb-t scan... each after each other....

 

But this is just a detail.... actually for scanning you should probably set one method....... so in the scan stuff this is a irrelevant.

 

the current NimManger only handles one tuner type with tuner... A lot of elifs needs to be changed to ifs....

[Huevos]

Nope... my suggestion can do sat + dvb-t scan... each after each other....

My idea is to do what the user wants.

 

Nope...  actually for scanning you should probably set one method....... so in the scan stuff this is a irrelevant.

That is exactly what my patch does. But no one in this thread seems interested in the patch apart from Athoik.

[WanWizard]

If I'm correct, this is not a dual tuner, but a combi tuner, so it does DVB-S2, or DVB-T, but not both at the same time?

 

If so, it is then logical do always do both scans?

[Huevos]

If I'm correct, this is not a dual tuner, but a combi tuner, so it does DVB-S2, or DVB-T, but not both at the same time?

 

If so, it is then logical do always do both scans?

Of course it is not logical to do both scans.

 

User wants to scan terrestrial. Why should he be forced to do a satellite scan? How could the code be any more user unfriendly?

[littlesat]

In fact it does Dvb-t/c and dvb-s instantly and indeed not mixed

[littlesat]

In fact it does Dvb-t/c and dvb-s instantly and indeed not mixed. But I was looking further than just scanning... first e2 must understand these tuners correctly...

Edited by littlesat, 22 October 2016 - 18:25.

[athoik]

Actually enigma should undrestand DVB API v5

We are still mixing v3 with v5 that's why we have that mess.

A frontend (/dev/dvb/adapterX/frontentY) that supports delsys properly, returns all supported delivery systems.

So Enigma2 with a tuner that supports S2 and T2 and C modes should be able to give DVB-T options when selecting terrestrial delivery system (T2 or T), should provide DVB-S options when selecting satellite delivery (S2 or S and soon S2X) and so on...

So we need to use properly the delivery systems, and exclude some of them (eg blacklist DVB-C or ATSC and so on).

PS. Also there is no S/T tuner or S/C tuner. Delsys this is what we need to obey.

Edited by athoik, 22 October 2016 - 18:51.

[Huevos]

@Athoik, DVB API V5 or not my patch for ScanSetup is still valid.

 

The methods that needs to be updated to properly reflect DVB API V5 are isCompatible() and canBeCompatible in NimManager. Doing this would correct things everywhere throughout the image that use these methods (including ScanSetup).

 

Can you do something similar to your delivery system patch so these methods work properly? Here is the patch (but with a few multistream fragments mixed in )

https://github.com/H...55033315fd1852c

[Huevos]

PS, don't forget some drivers do not follow DVB API V5 properly (e.g. Solo4K, already reported).

[athoik]

@Huevos, your aproach is not bad. Although I think that UI should display what frontent supports.

If the frontent supports S2/S/T2/T/C/ATSC/ISBT-T/... it should give the user the option to select delivery system.

More or less this is what your patch does.

I think that using the existing field type would be better. UI is a Headache for me, if I had the option to use console (enigma2 --scan dvb-s2 --pos 19 --adapter 0 --frontent 0) for scanning, i would be more than happy

[Huevos]

In my patch if you select "terrestrial" it will show T2 options if the tuner supports them. Same with S and S2.

But that info comes from isCompatible and canBeCompatible so these need to have correct info from delsys (in NimManager).

[Huevos]

File attached.

 

 ScanSetup.patch.zip   17.53KB   10 downloads

[littlesat]

In the background we are busy with Jess... As to make this multimtuner feature in a propper way it also needs changes in Nimmanger and satsetup. As Jess also "beats" the same files It is better tomwait until Jess is finished. The Jess patch also means Unicable stuff will be re-written by scratch, so it will be a big impact. Therefore it is smart to wait to make this properly untill Jess is ready... I hope you understand...

For now you can watch picture from this tuner from different modes... So I suggest we can put this at a bit lower priority...

I have just one question for the design... Do we need to make it possible to use dvb-t and c at once?

Edited by littlesat, 25 October 2016 - 08:23.

[athoik]

I have just one question for the design... Do we need to make it possible to use dvb-t and c at once?

We need to be able to select which modes are enabled. Eg display the modes like checkboxes and check what mode you like to use.

So I say yes, DVB API enumerates delivery systems, lets follow what DVB API supports, but give the option to exclude a delivery system.

PS. In terms of DVB API, we just need to use the proper DTV_DELIVERY_SYSTEM, and we already do.

[Huevos]

I give up. It's like pulling teeth. My patch has nothing to do with the work that is required in NimManager. It is ready to use now and gets the ScanSetup working in a user friendly way. It has zero impact on conventional tuners. Whatever you do in NimManager you will still need my patch or similar in ScanSetup.

Also of course cable and terrestrial can't be both setup one one tuner. It is impossible because they use the same socket on the stb and operate in the same freqency band.

[isteric2005]

News on Multituner.
Please give us a share