77 replies to this topic

[littlesat]

That it is working willnot say it is good developed... First the basics need to be good... And some times this needs mote time than hammering code....

Edited by littlesat, 28 October 2016 - 05:35.

[Huevos]

So you don't like the code. What is wrong with it? Please be specific, not just vague statements about quality.

[littlesat]

The biggest problem here is that currently I have no time to solve it, we try to avoid changew now on nimmanager and satconfig as we're busy with a proper JESS implementation... It is not your code at all... I only think it mit be adapted afterwards.... As you can see due to vacation we also have a lot off other pending merge requests....

[Huevos]

TBH, NimManager/Satconfig is 95% working. Main problem for multituner is it is not possible to know which delivery system nimmanager.nim_slots[n].config_mode corresponds to. i.e. one variable and three types of delivery system. Apart from that, as far as I see it everything else already works.

[littlesat]

Yep config_mode needs to be changed and that also causes trouble with backwards compatebility... This is a real pain and I do not have a real solition yet....

[Huevos]

Yep config_mode needs to be changed and that also causes trouble with backwards compatebility... This is a real pain and I do not have a real solition yet....

Well Athoik had a solution above. Create a blacklist.

 

Only use config_mode if tuner isCompatible, else use the blacklist. This works fine if the satellite tuner is the configured tuner.

 

Otherwise like you say backwards compatibility is a pain, like in the new version of OpenATV.

 

I had to add the following to AutoBouquetsMaker to keep compatibility for both versions.

https://github.com/o...b6a3216b012c283

[littlesat]

Brrrrrrr.... Not the solution I would choose....  The way try/except is used here should already ring the alarm bells...

 

Actually you need at least for each tuner type the tuner does a separate config_mode.... so when you have a multituner and dvb-s is active you need to create a new config_mode for dvb-s or dvb-t... and only then to keep it backwards compatible.... And then arrange that for a multi tuner you always get DVB-S which you can disable or configer via config mode and then have a choice for DVB-T or DVB-C or "nothing" as an additional (new) config_mode setting, which only appears with multituner and adds the required fields... (I still not 100% convinced....)

 

This is a bit how I try to design the multituner NimManager/Satconfig... and the Scan options could adapt to that....

 

(I hope you understand what I mean...)

 

But at this moment we're busy with UNICABLE/JESS so we are avoiding big changes to NimManager.py and/or SatConfig.py...

Edited by littlesat, 29 October 2016 - 13:27.

[Erik Slagter]

I give up. It's like pulling teeth. My patch has nothing to do with the work that is required in NimManager. It is ready to use now and gets the ScanSetup working in a user friendly way. It has zero impact on conventional tuners. Whatever you do in NimManager you will still need my patch or similar in ScanSetup.

Also of course cable and terrestrial can't be both setup one one tuner. It is impossible because they use the same socket on the stb and operate in the same freqency band.

Yes, Littlesat can merge it already it it's a good patch. He can rebase its work afterwards.

[littlesat]

I just merged it... and afterwards I removed 2 by accident induced white spaces...

 

He can rebase its work afterwards. -> I'll do.....

Edited by littlesat, 29 October 2016 - 14:18.

[Huevos]

Brrrrrrr.... Not the solution I would choose....  The way try/except is used here should already ring the alarm bells...

 

Actually you need at least for each tuner type the tuner does a separate config_mode....

Yeah, I know it is crap. I also know if  "config_mode" is missing it will raise an attributeError.

 

I guess I could have used "hasAttribute" instead.

[Huevos]

But, according to pydoc:

 

hasattr(obj, prop) simply calls getattr(obj, prop) and catches exceptions. So, it is just as valid to wrap the attribute access with a try statement and catch AttributeError as it is to use hasattr() beforehand.

 

So is there a better way?

Edited by Huevos, 29 October 2016 - 16:05.

[littlesat]

Yeah, I know it is crap. I also know if  "config_mode" is missing it will raise an attributeError.

->

You should arrange that it is not missing at the first place....

 

But you're getting to the key what the real issue is that should be solved....

Edited by littlesat, 29 October 2016 - 16:49.

[Huevos]

You should arrange that it is not missing at the first place....

 

But you're getting to the key what the real issue is that should be solved....

Littlesat, it is a plugin used by many different images. I'm not in control of their E2, so nothing I can do about "nim.config_mode" existing in some images and not others.

Edited by Huevos, 29 October 2016 - 23:24.

[sergiodi]

Any news ?

[athoik]

Both changes from Huevos they are already included in Enigma2!

Unfortunately there are no new images for Edision, because a new firmware for vtuner break build (same firmware was used by opticombo).

I guess somebody will look on this, fix was provided, but manual fix (cleanup old bitbake) required.

Edited by athoik, 7 November 2016 - 18:23.

[sergiodi]

I sent FTP to box Huevos patch and got great success.
Now in "Manual Scan" it is possible to select by "DVB type" and by "Type of scan" to get everything you want.
Thank Huevos very much

[isteric2005]

And 'possible to have an expected date for the release of the new image with the built-in tuner solution.

[Abu Baniaz]

manual fix (cleanup old bitbake) required.

Hello,
Do we know if this has been actioned?

Many thanks in advance