33 replies to this topic

[littlesat]

It is just a taste... I feel when it is just one line formthe if you do not do the {}.... But meanings and feelings are different......

[johmer]

Sorry but I'm new to this, what does a pull request mean? Will the fix be available the next time i update my box?

 

Thanks.

[christophecvr]

Sorry but I'm new to this, what does a pull request mean? Will the fix be available the next time i update my box?

 

Thanks.

Not yet since last nightly build for dm500hd is not done (according to website) :

http://openpli.org/d...reambox/dm500hd

 

e2 update pushed after last nightly build.

[christophecvr]

It is just a taste... I feel when it is just one line formthe if you do not do the {}.... But meanings and feelings are different......

There are several ways, and many are often very personal.

 

like for example now with a single action if line the one for the params.

if(parms)
{
    parms->getSystem(system);
}

// also ok is

if(parms) parms->getSystem(system);

// or

if(parms)
    parms->getSystem(system);

// or
if(parms) {
    parms->getSystem(system);
}

Personally for a single if line I prefer

if(parms)
    parms->getSystem(system);

or this is also very good

if(parms)
{
    parms->getSystem(system);
}

When You're bussy with modifying a code all ways are ok, but if after one year or someone else review the code the last two ways are easy to read.

But the ways beneed here are very confusing then.

 

personally confusing for me I find them difficult to read after a year or so from own written code or some one else code:

if(parms) parms->getSystem(system);

//or

if(parms){
    parms->getSystem(system);
}

[Domi76]

Hello,

I'm also new in the Forum and not quite sure if I'm at the right place.
I also face the same problem with VU+Duo 2.

Will it be fixed in a next update of the box ?
Thanks for your help and support.

Best regards.
Domi76

[christophecvr]

Hello,

I'm also new in the Forum and not quite sure if I'm at the right place.
I also face the same problem with VU+Duo 2.

Will it be fixed in a next update of the box ?
Thanks for your help and support.

Best regards.
Domi76

according to :

http://openpli.org/d.../vuplus/vuduo2/

 

not yet.

 

As from the moment You see last image is 31/10  or later date yes after update problem will be solved.

Just await the next full nightly ok build.

[christophecvr]

@littlesat

 

Could You also update e2 next-master to have this last patch included ?

 

Thanks.

[Domi76]

Problem fixed on Vu+Duo 2 after today's update.

thanks for the support.

Best regards.

[littlesat]

Merge is not easy... much conflicts...

 

Auto-merging lib/service/servicedvbstream.cpp

CONFLICT (content): Merge conflict in lib/service/servicedvbstream.cpp

Auto-merging lib/service/servicedvbrecord.cpp

CONFLICT (content): Merge conflict in lib/service/servicedvbrecord.cpp

Auto-merging lib/python/Screens/ScanSetup.py

CONFLICT (content): Merge conflict in lib/python/Screens/ScanSetup.py

Auto-merging lib/dvb/scan.cpp

CONFLICT (content): Merge conflict in lib/dvb/scan.cpp

Auto-merging lib/dvb/idvb.h

Auto-merging lib/dvb/dvbtime.cpp

CONFLICT (content): Merge conflict in lib/dvb/dvbtime.cpp

Auto-merging lib/dvb/atsc.h

CONFLICT (add/add): Merge conflict in lib/dvb/atsc.h

Auto-merging lib/dvb/atsc.cpp

CONFLICT (add/add): Merge conflict in lib/dvb/atsc.cpp

Automatic merge failed; fix conflicts and then commit the result.

[littlesat]

Done.... hopefully I corrigated all the merge conflics correctly....

[christophecvr]

Yes indeed that I was afk of. If they start development into the master while in next-master important changes had been done. Development should only be in next-master. Or guess its better to work only with master then. Changes which where only done in next-master will have to be backported to master  with a limitation to gst-1.0 or ...

[johmer]

Do you know when will the build be released for DM500?

 

Its been since the 30th that no new builds were released, usually they were releasing one almost every day.

[WanWizard]

@christophecvr,

 

With OpenPLi-5 we will introduce a new way of developing and a new repo structure, which will solve these issues.

[johmer]

Issue fixed in the last build. Thanks to all those who contributed in finding the root cause and fixing it!