30 replies to this topic

[Taapat]

But its still does not fix the second problem: cat: cant open /sys/block/mmc/device/model : No such file or directory

 

Look at the second part of my commit.

On zgemma does not exist /sys/block/$DEVBASE/device. I did not find any other records in /sys/block/$DEVBASE that may indicate to a model.

Therefore, I added a check or /sys/block/$DEVBASE/device/model exists and if not, assume that with 7-char DEVBASE it's mmc.

[WanWizard]

How come $DEVVASE is "mmc"? It should be "mmcblk0", as it now takes the first 7 first, and checks if that exists in /sys/block, which it should do?

 

And according to your post at https://forums.openp...ed/#entry647457 /sys/block/mmcblk0/device does exist?

[Taapat]

Sorry, /sys/block/$DEVBASE/device existed, does not exist /sys/block/$DEVBASE/device/model:

root@h3:~# ls -la /sys/block/mmcblk0/device/
drwxr-xr-x    3 root     root             0 Jan  1  1970 .
drwxr-xr-x    4 root     root             0 Jan  1  1970 ..
-r--r--r--    1 root     root          4096 Jan  1  1970 cid
-r--r--r--    1 root     root          4096 Jan  1  1970 csd
-r--r--r--    1 root     root          4096 Jan  1  1970 date
lrwxrwxrwx    1 root     root             0 Jan  1  1970 driver -> ../../../../../../bus/mmc/drivers/mmcblk
-r--r--r--    1 root     root          4096 Jan  1  1970 erase_size
-r--r--r--    1 root     root          4096 Jan  1  1970 fwrev
-r--r--r--    1 root     root          4096 Jan  1  1970 hwrev
-r--r--r--    1 root     root          4096 Jan  1  1970 manfid
-r--r--r--    1 root     root          4096 Jan  1  1970 name
-r--r--r--    1 root     root          4096 Jan  1  1970 oemid
drwxr-xr-x    2 root     root             0 Jan  1  1970 power
-r--r--r--    1 root     root          4096 Jan  1  1970 preferred_erase_size
-r--r--r--    1 root     root          4096 Jan  1  1970 scr
-r--r--r--    1 root     root          4096 Jan  1  1970 serial
lrwxrwxrwx    1 root     root             0 Jan  1  1970 subsystem -> ../../../../../../bus/mmc
-r--r--r--    1 root     root          4096 Jan  1  1970 type
-rw-r--r--    1 root     root          4096 Jan  1  1970 uevent

Edited by Taapat, 20 March 2017 - 18:28.

[WanWizard]

Ok.

 

https://github.com/O...9ecd5c9f40c4d3b

[Taapat]

Only DEVBASE can be mmcblk[0-9] not only mmcblk0.
Therefore, I think it is better to use:

if [ ${DEVBASE:0:6} = "mmcblk" ]; then

[WanWizard]

Not sure if that works in shell, I think that is bash, I'll have to check.

 

Having said that, if you have multiple similar block devices, using "mmc" will cause a collision for the mount point.

 

edit: on my laptop it works in shell, but I have no box to test it at the moment

sh-4.3$ DEVBASE=mmcblk0
sh-4.3$ echo ${DEVBASE:0:6}
mmcblk
sh-4.3$ 

Edited by WanWizard, 20 March 2017 - 23:05.

[Taapat]

Before write there I tested this on my box:

root@h3:~# DEVBASE="mmcblk0"
root@h3:~# if [ "$DEVBASE" == "mmcblk0" ]; then echo "EXIST"; fi
EXIST
root@h3:~# if [ ${DEVBASE:0:6} = "mmcblk" ]; then echo "EXIST"; fi
EXIST
root@h3:~# if [ ${DEVBASE:0:6} = "mmcblx" ]; then echo "EXIST"; fi
root@h3:~#

[Taapat]

Having said that, if you have multiple similar block devices, using "mmc" will cause a collision for the mount point.

 

No, if the mount point already exists, it is mounted as /media/$MDEV: https://github.com/O...v-mount.sh#L104

[WanWizard]

I know that, I was just wondering if we shouldn't create "mmc1", "mmc2", etc... instead, since we have the device number.

 

And thanks for confirmation. I've bricked my box, and since it's 600km away from where I am at the moment, I can't test anymore.

 

Just wondering: if this works, why does the rest of the script things like "expr substr $MDEV 1 7", which requires a secondary shell? That could be replaced by ${MDEV:0:7} as well?

[Erik Slagter]

The question is whether the braindead busybox shell understands this bash-ism. I fear not.

[WanWizard]

The code is tested before I've implemented it, so the answer is "yes, it does understand this".