36 replies to this topic

[doglover]

When XMLTVimport cannot find the channels file (rytec.channels.xml.gz and others) it gets into an infinity loop, so it seems.

The import is stuck, and you cannot get out of it.  The only way is to restart enigma2.

An none existing XMLTV file (data file) is fine.  The importer just reports in the log it cannot find the file.  No problem with this.

 

The receiver is not stuck, it is still responsive.

 

Can somebody with knowledge of python take a look at this, and propose a solution?

 

Willy

[WanWizard]

What does it log when this happens?

[Pr2]

I can confirm this, the imported doesn't check the result when trying to open the channels file so if it doesn't exist, it is stuck forever trying to read a non existing file.

[doglover]

What does it log when this happens?

 

Nothing really.  It just ends on a normal entry.  (Can not say exactly what it is - would have to try again to see it exactly)

 

Willy

[doglover]

OK.  It is easy enough to generate the fault.  Made an error in the position of the channels file, and this is wat is shown in the log:

[EPGImport] autostart (0) occured at 1502943486.45
[EPGImport] autostart (0) occured at 1502943486.62
[EPGImport] WakeUpTime now set to -1 (now=1502943486)
[EPGImport] Selected sources: ['AFN']
sourcesDone():  True ['AFN']
[EPGImport] nextImport, source= AFN
[EPGImport] afterDownload /home/Fritz/epg/rytecAFN.gz
[EPGImport] afterChannelDownload None
[EPGImport] Using twisted thread

It stays there forever.

 

Willy

[WanWizard]

Hmm... This looks to be above my paygrade, I have to pass this to MiLo.

[Pr2]

Test in line 216 is wrong in EPGimport.py (if filename:), we saw in log that the filename is "None" so it doesn't enter the test that use the os.path.getsize to check if the file exist.

So the normal process continue even if the file is None. 

So this test must be reviewed to cover the "None" case, the check on the filename is not a valid test.

[WanWizard]

Ok, I can do that.

[WanWizard]

This should do it? https://github.com/O...7a12e80e46ecebe

[Pr2]

Hi,
 
I think (but to be tested) that the "if filename" test is useless, just testing directly with os.path.getsize(filename): will achieve the same result.

Pr2

[WanWizard]

Did you check the commit?

 

I did remove the "if filename" check. I also removed the useless try/except block with the raise statement, as you can pass the exception directly.

 

I do check for None, as I want a different error message for "not present" vs "file empty".

[Pr2]

Hi,

 

Sorry to report it so late, I was waiting for Willy feedback to be sure that the solution was not working.

It starts import but when it reach the wrong condition it no longer read the other files.

 

Pr2

[WanWizard]

Yeah, working on it as I type.

[WanWizard]

Found and fixed the endless loop. Waiting for Willy to confirm.

[doglover]

Will try today.  Fishing out the file from the Github.  Putting it in my receiver and do some testing.

 

Willy

[doglover]

It still hangs.  And yes with the new file from the github.

[EPGImport] nextImport, source= News Channels (xz)
[EPGImport] Downloading: xxxxxxxxxxxxxxxxxxxxxxxx.xz to local path: /tmp/epgimport.xz
[EPGImport] afterDownload /tmp/epgimport.xz
[EPGImport] unlink /tmp/epgimport.xz
[EPGImport] afterChannelDownload None
[EPGImport] Using twisted thread
[XMLTVConverter] Enumerating event information
Unknown channel:  DeutscheWelleDE.de
Unknown channel:  AlArabiya.nws
Unknown channel:  TV5MONDEMaghreb-Orient.fr
Unknown channel:  PCNEChinese.uk
Unknown channel:  SkyNwsArabia.nws
Unknown channel:  TRTInternational
[EPGImport] ### thread is ready ### Events: 13333
[EPGImport] nextImport, source= Erotic (xz)
[EPGImport] Downloading: xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx.xz to local path: /tmp/epgimport.xz
[EPGImport] afterDownload /tmp/epgimport.xz
[EPGImport] unlink /tmp/epgimport.xz
[EPGImport] afterChannelDownload None
[EPGImport] Using twisted thread

The error I made was in the published sources file replacing one xz with an tz

here

<source type="gen_xmltv" channels="rytec.channels.xml.tz">
<description>Erotic (xz)</description>
<url>.....</url>
</source>

(here the exact URL for the channels file is defined via the name and the mappings at front of the sources file.  In this case there is no mapping, so the program will look into /etc/epgimport/ for a file with this name)

The error is not fixed.  It looks like we are looking at the wrong place,  I think.

 

On the other hand.  We know this can happen.  And we know what causes this.  It cannot find a file, and you know in which source you have to look to correct the mistake.

So correct the mistake, restart enigma2 and you are back into business.

It is annoying yes.  But fortunately it will not happen very often, and the receiver is not stuck, only the EPGimport.  And only with an error in the sources file, which users do not normally edit.

 

I propose to leave it for the moment (unless some-one has a bright idea).  We will come across some more info at some point.

 

Willy

 

I did this test on 6.0-rc

Edited by doglover, 22 August 2017 - 08:16.

[doglover]

Forgot the note:  The EPGimport.py from the github with WanWizard's modifications, runs now normally.

 

It fixes something although not this error.

 

Willy

[Abu Baniaz]

Did you use both modified files or just one?

Edited by Abu Baniaz, 22 August 2017 - 08:29.

[doglover]

Just the EPGImport.py file.

The other one is for the expandable source list (treeview) which has nothing to do with this.

 

Just to be safe, I will test that one also.

 

Willy

[doglover]

As expected, no problem.

In the source selection list the children are indented now.

I let you decide if this needs cosmetic modifications (liker bigger spacing between the + and - signs and the text.

 

Willy

Attached Files

•  SourceSelection.jpg   127.42KB   6 downloads