Jump to content


Photo

gpixmap.cpp, horrible bug...

Started by Huevos, 14 Apr 2018 14:24

  • Please log in to reply
66 replies to this topic

#1 Huevos

  • PLi® Contributor
  • 4,644 posts

+161
Excellent

Posted 14 April 2018 - 14:24

gpixmap.cpp horrible bug starting with this commit.
https://github.com/O...05a1b244172a087

Bug shows in many ways, e.g...
All spinner images show at once.
Transparency problems,
Blending problems,
Horizontal noise lines across PNGs,
Noise in transparent areas of the images,

Failure to respect zIndex, etc.

I built OpenPLi develop without this chain of commits and then added them one at a time. Bug shows with the first commit linked above and gets worse as more changes to gpixmap.cpp are added.

Bugs show on various hardware, using OpenPLi develop build (homebuild) on supported boxes, e.g. et8500. Also shows on unofficial OpenPLi, e.g. sf4008, tmnanosem2. And also show on many boxes in other images that have merged these commits, e.g. OpenViX.

Doesn't show on all hardware, but all the boxes with the problem are fixed once these commits are removed.


Edited by Huevos, 14 April 2018 - 14:24.

Re: gpixmap.cpp, horrible bug... #2 WanWizard

  • PLi® Core member
  • 70,359 posts

+1,807
Excellent

Posted 14 April 2018 - 14:31

Isn't there a typo? I think it should be "surface->bpp", not "surface->bypp" ?


Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Ultimate (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)

Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.

Many answers to your question can be found in our new and improved wiki.

Re: gpixmap.cpp, horrible bug... #3 ims

  • PLi® Core member
  • 13,776 posts

+214
Excellent

Posted 14 April 2018 - 14:55

???  I have no problems on 7 different HWs... this patch is 1month old ...


Kdo nic nedělá, nic nezkazí!

Re: gpixmap.cpp, horrible bug... #4 Abu Baniaz

  • PLi® Contributor
  • 2,494 posts

+64
Good

Posted 14 April 2018 - 14:59

The spinners on PLi image are small, so you do not see it easily. Please try with these

Attached Files


Re: gpixmap.cpp, horrible bug... #5 ims

  • PLi® Core member
  • 13,776 posts

+214
Excellent

Posted 14 April 2018 - 15:05

little circles (in cca 3/4 circle) rotating clockwise

 

Edit - I put it to dm800se too (slow box) and cca 15x rotated ...

 
 
 

Edited by ims, 14 April 2018 - 15:08.

Kdo nic nedělá, nic nezkazí!

Re: gpixmap.cpp, horrible bug... #6 littlesat

  • PLi® Core member
  • 57,107 posts

+698
Excellent

Posted 14 April 2018 - 15:06

Mmmm when some boxes have the issue it could also be an issue with drivers..... The acceleration not (correctly) supported???


Edited by littlesat, 14 April 2018 - 15:08.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W

Re: gpixmap.cpp, horrible bug... #7 Huevos

  • PLi® Contributor
  • 4,644 posts

+161
Excellent

Posted 14 April 2018 - 15:07

???  I have no problems on 7 different HWs... this patch is 1month old ...

Yes, it doesn't show on all hardware. I have mainly Vu+ boxes and it doesn't appear on them, but I assure you it is very real.


Re: gpixmap.cpp, horrible bug... #8 Huevos

  • PLi® Contributor
  • 4,644 posts

+161
Excellent

Posted 14 April 2018 - 15:10

Mmmm when some boxes have the issue it could also be an issue with drivers..... The acceleration not (correctly) supported???

Possible but it is broken on several manufacturers. And it wasn't broken before these commits. Also don't forget, these commits are only in the develop branch so only a very limited audience.


Re: gpixmap.cpp, horrible bug... #9 Pr2

  • PLi® Contributor
  • 6,176 posts

+261
Excellent

Posted 14 April 2018 - 15:16

On my Octagon SF4008 some picons looks ugly (not all) in the Graphical EPG but they looks fine in the infobar, can this problem came from this?


NO SUPPORT by PM, it is a forum make your question public so everybody can benefit from the question/answer.
If you think that my answer helps you, you can press the up arrow in bottom right of the answer.

Wanna help with OpenPLi Translation? Please read our Wiki Information for translators

Sat: Hotbird 13.0E, Astra 19.2E, Eutelsat5A 5.0W
VU+ Solo 4K: 2*DVB-S2 + 2*DVB-C/T/T2 (used in DVB-C) & Duo 4K: 2*DVB-S2X + DVB-C (FBC)

AB-Com: PULSe 4K 1*DVB-S2X (+ DVB-C/T/T2)
Edision OS Mio 4K: 1*DVB-S2X + 1*DVB-C/T/T2
 

Re: gpixmap.cpp, horrible bug... #10 littlesat

  • PLi® Core member
  • 57,107 posts

+698
Excellent

Posted 14 April 2018 - 15:17

Could indeed be related... But sounds more that the hardware accelerator for the graphics does not work properly with this type of box....


WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W

Re: gpixmap.cpp, horrible bug... #11 Huevos

  • PLi® Contributor
  • 4,644 posts

+161
Excellent

Posted 14 April 2018 - 15:28

The first commit just does some maths, and that is where the bug starts.


Re: gpixmap.cpp, horrible bug... #12 littlesat

  • PLi® Core member
  • 57,107 posts

+698
Excellent

Posted 14 April 2018 - 16:48

Yep probably using the accerrater earlier

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W

Re: gpixmap.cpp, horrible bug... #13 MiLo

  • PLi® Core member
  • 14,055 posts

+298
Excellent

Posted 14 April 2018 - 18:31

The "accelerator" was always skipped for transparent and alphablending because that never worked properly on any box. Maybe the patch accidentally enabled that again?

I actually seriously doubt there's any point in using the accelerated bitblt, it helps on full-screen stuff, but while composing the effect is negligible. And that was on the old 400 MHz boxes, on the newer ones it's completely pointless anyway to use the old ioctl based bitblt accelerator.

Edited by MiLo, 14 April 2018 - 18:32.

Real musicians never die - they just decompose

Re: gpixmap.cpp, horrible bug... #14 WTE

  • Senior Member
  • 821 posts

+36
Good

Posted 14 April 2018 - 20:02

Gigablue and Xtrend already fix it in the drivers and it seems a lot other boxes had no effect and works fine.

 

It happen so on all Nextv boxes: ET8500/ ET7000/ SF4008
TMnanosem2 is from ITgate? If Itgate has this bug does it happen on the Xsarius boxen?


Edited by WTE, 14 April 2018 - 20:03.

Mut@nt HD51 STB 4K

   :rolleyes:                :rolleyes:

Re: gpixmap.cpp, horrible bug... #15 littlesat

  • PLi® Core member
  • 57,107 posts

+698
Excellent

Posted 14 April 2018 - 22:27

So somehow confirmed it is a driver bug? Sounds we need a feature canacceleraregraphsbugless

Edited by littlesat, 14 April 2018 - 22:28.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W

Re: gpixmap.cpp, horrible bug... #16 arn354

  • Senior Member
  • 146 posts

+12
Neutral

Posted 14 April 2018 - 22:35

we were able to fix in the drivers - yes.
- Fix fb accel blit

Edited by arn354, 14 April 2018 - 22:36.

Re: gpixmap.cpp, horrible bug... #17 Huevos

  • PLi® Contributor
  • 4,644 posts

+161
Excellent

Posted 14 April 2018 - 22:36

Is this denial? Several brands are affected and it didn't exist before these commits. Even if drivers are involved do we need to break the image for owners of those boxes when it worked fine before.


Edited by Huevos, 14 April 2018 - 22:39.

Re: gpixmap.cpp, horrible bug... #18 Huevos

  • PLi® Contributor
  • 4,644 posts

+161
Excellent

Posted 14 April 2018 - 23:21

So somehow confirmed it is a driver bug? Sounds we need a feature canacceleraregraphsbugless

Sounds like a good plan.


Re: gpixmap.cpp, horrible bug... #19 WTE

  • Senior Member
  • 821 posts

+36
Good

Posted 14 April 2018 - 23:29

 

So somehow confirmed it is a driver bug? Sounds we need a feature canacceleraregraphsbugless

Sounds like a good plan.

 

VU+ it's a known driver bug and it's deactivate long time ago.

https://github.com/O...onfigure.ac#L91

 


Mut@nt HD51 STB 4K

   :rolleyes:                :rolleyes:

Re: gpixmap.cpp, horrible bug... #20 littlesat

  • PLi® Core member
  • 57,107 posts

+698
Excellent

Posted 15 April 2018 - 07:06

And vu’s work a round is the way to go.... you should push the problem where it comes from and not change the code itself for some manufacturers who have a bug in the drivers...

Edited by littlesat, 15 April 2018 - 07:08.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W

Back to [EN] Enduser support

17 user(s) are reading this topic

0 members, 17 guests, 0 anonymous users

  1. Forums
  2. → PLi® Support
  3. → [EN] Enduser support