Jump to content


Photo

Should E2 be edited to accomodate plugins?


  • Please log in to reply
45 replies to this topic

Re: Should E2 be edited to accomodate plugins? #21 Rob van der Does

  • Senior Member
  • 7,766 posts

+184
Excellent

Posted 11 June 2018 - 03:30

I am not sure where this reaction comes from.
 
The remark was that if you make something that is tightly integrated with Enigma, or should be tightly integrated with Enigma, don't make it a plugin, but integrate it?
 
That doesn't strike me as something you should become angry about?

Exactly!
I often notice such angriness in Ims's reactions on simple questions. No idea why that's the case.
Anyway: I never intended to offend anyone at all; I was just wondering and hence asked a question.


But now that I am asking: this is (as far as I know) the second time some private repos is being used for stuff that's (more or less) basic stuff for OpenPLi (the other one being Littlesat's skins).
That doesn't strike me as a good idea either; why not use the PLi-repos?

Re: Should E2 be edited to accomodate plugins? #22 Rob van der Does

  • Senior Member
  • 7,766 posts

+184
Excellent

Posted 21 June 2018 - 04:45

As the plugin has been modified, to behave like a real plugin (see https://github.com/i...00b3c85b481c83c  and https://github.com/OpenPLi/enigma2/commit/50bfe625941878272d05f0d461a90c813f51b687) I conclude that my questions were valid (although no answer was given on GITHUB).

 

But: the result is a crash on (up-to-date) PLi 6.2.

 

Attached File  enigma2_crash_1529552558.zip   4.54KB   4 downloads

 

 



Re: Should E2 be edited to accomodate plugins? #23 ims

  • PLi® Core member
  • 13,623 posts

+212
Excellent

Posted 21 June 2018 - 08:37

pears and apples


Kdo nic nedělá, nic nezkazí!

Re: Should E2 be edited to accomodate plugins? #24 Rob van der Does

  • Senior Member
  • 7,766 posts

+184
Excellent

Posted 22 June 2018 - 03:01

No idea what you mean, but the crash is real and makes MovieManager useless.



Re: Should E2 be edited to accomodate plugins? #25 ims

  • PLi® Core member
  • 13,623 posts

+212
Excellent

Posted 22 June 2018 - 07:16

On the other hand, you have saved the e2 code cleanness :D


Kdo nic nedělá, nic nezkazí!

Re: Should E2 be edited to accomodate plugins? #26 Rob van der Does

  • Senior Member
  • 7,766 posts

+184
Excellent

Posted 22 June 2018 - 08:45

I still have no idea what you mean, but the crash is still present and makes MovieManager useless.
Any chance for a fix?

Re: Should E2 be edited to accomodate plugins? #27 littlesat

  • PLi® Core member
  • 56,262 posts

+691
Excellent

Posted 22 June 2018 - 09:06


Traceback (most recent call last):
  File "/usr/lib/enigma2/python/mytest.py", line 208, in processDelay
    callback(*retval)
  File "/usr/lib/enigma2/python/Screens/MovieSelection.py", line 1208, in doneContext
  File "/usr/lib/enigma2/python/Screens/MovieSelection.py", line 2027, in do_moviemanager
  File "/usr/lib/enigma2/python/mytest.py", line 297, in open
    dlg = self.current_dialog = self.instantiateDialog(screen, *arguments, **kwargs)
  File "/usr/lib/enigma2/python/mytest.py", line 240, in instantiateDialog
    return self.doInstantiateDialog(screen, arguments, kwargs, self.desktop)
  File "/usr/lib/enigma2/python/mytest.py", line 257, in doInstantiateDialog
    dlg = screen(self, *arguments, **kwargs)
TypeError: __init__() takes exactly 3 arguments (4 given)

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Should E2 be edited to accomodate plugins? #28 littlesat

  • PLi® Core member
  • 56,262 posts

+691
Excellent

Posted 22 June 2018 - 09:06

Look like we need to give one argument less -or- arrange that the extra argument is accepted -or- arrange the argument is passed in some kind if different way.


WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Should E2 be edited to accomodate plugins? #29 ims

  • PLi® Core member
  • 13,623 posts

+212
Excellent

Posted 22 June 2018 - 09:32

Nothing is needed ... Mister RvdD wants using 6.2 with develop plugin version. He mixes pears with apples, thats all !


Kdo nic nedělá, nic nezkazí!

Re: Should E2 be edited to accomodate plugins? #30 Rob van der Does

  • Senior Member
  • 7,766 posts

+184
Excellent

Posted 22 June 2018 - 09:38

@IMS: Why do you think that?

Mister RvdD is simply using release 6.2 with the MovieManager from the feeds. He hasn't made any modifications himself.
Is anybody really testing this on release?

Re: Should E2 be edited to accomodate plugins? #31 ims

  • PLi® Core member
  • 13,623 posts

+212
Excellent

Posted 22 June 2018 - 09:50

But in feeds is not 1,73 version. In feeds is pinned version from 03/2018 - see .

 

 
 
 


Kdo nic nedělá, nic nezkazí!

Re: Should E2 be edited to accomodate plugins? #32 Rob van der Does

  • Senior Member
  • 7,766 posts

+184
Excellent

Posted 22 June 2018 - 09:52

What can I say more then I already did: release 6.2 + MovieManager from the feeds. Nothing more, nothing less.

Does anybody actually test a release image with the plugin from the feeds?



Re: Should E2 be edited to accomodate plugins? #33 Rob van der Does

  • Senior Member
  • 7,766 posts

+184
Excellent

Posted 22 June 2018 - 10:05

Sorry, but it seems I uploaded the wrong crashlog.

Here's the correct one: Attached File  enigma2_crash_1529658125.zip   4.54KB   2 downloads

 

I'm very sorry about that :(



Re: Should E2 be edited to accomodate plugins? #34 WanWizard

  • PLi® Core member
  • 68,565 posts

+1,737
Excellent

Posted 22 June 2018 - 10:10

Does anybody actually test a release image with the plugin from the feeds?

 

Structurally? No. I wish we had a volunteer for that, but tedious jobs are not high on anybody's agenda it seems.


Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Pro (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)

Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.

Many answers to your question can be found in our new and improved wiki.


Re: Should E2 be edited to accomodate plugins? #35 ims

  • PLi® Core member
  • 13,623 posts

+212
Excellent

Posted 22 June 2018 - 10:17

It is same ... 6.2 version cannot run 1.73 version. MovieManager is from 1.73 standallone plugin. Call it with code in 6.2 is impossible. And as I saw into reporefs.conf for 6.2, in feeds must be version from 03.2018 only. Last version is for develop only...


Kdo nic nedělá, nic nezkazí!

Re: Should E2 be edited to accomodate plugins? #36 Rob van der Does

  • Senior Member
  • 7,766 posts

+184
Excellent

Posted 22 June 2018 - 11:36

It is same ... 6.2 version cannot run 1.73 version. MovieManager is from 1.73 standallone plugin. Call it with code in 6.2 is impossible. And as I saw into reporefs.conf for 6.2, in feeds must be version from 03.2018 only. Last version is for develop only...

I even de-installed the plugin, made sure there were no left-overs, and installed it again from the feeds. Only then I let the crash happen and retrieved the crashlog.

So yes, as I said multiple times now: this is what's on the PLi-6.2 feeds.

Did you actually try it, instead of denying the issue?



Re: Should E2 be edited to accomodate plugins? #37 ims

  • PLi® Core member
  • 13,623 posts

+212
Excellent

Posted 22 June 2018 - 11:43

I do not know how you, but I am still at work ... afternoon I wil try it.


Kdo nic nedělá, nic nezkazí!

Re: Should E2 be edited to accomodate plugins? #38 WanWizard

  • PLi® Core member
  • 68,565 posts

+1,737
Excellent

Posted 22 June 2018 - 11:52

I double checked, the version in the 6.2-release feed is enigma2-plugin-extensions-moviemanager_2.0+git20+30c22dc-r0.0, which is build from commit hash 30c22dc9a148bd0919b230563e91139201113361, which is dated March 10th 2018.

 

If that doesn't work, it is not related to any change in the plugin after that date.


Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Pro (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)

Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.

Many answers to your question can be found in our new and improved wiki.


Re: Should E2 be edited to accomodate plugins? #39 Rob van der Does

  • Senior Member
  • 7,766 posts

+184
Excellent

Posted 22 June 2018 - 12:56

 

It is same ... 6.2 version cannot run 1.73 version. MovieManager is from 1.73 standallone plugin. Call it with code in 6.2 is impossible. And as I saw into reporefs.conf for 6.2, in feeds must be version from 03.2018 only. Last version is for develop only...

I even de-installed the plugin, made sure there were no left-overs, and installed it again from the feeds. Only then I let the crash happen and retrieved the crashlog.

So yes, as I said multiple times now: this is what's on the PLi-6.2 feeds.

Did you actually try it, instead of denying the issue?

 

To be 200% sure I reflashed (online) and auto-restored the box: same crash (on trying to open the plugin)


Edited by Rob van der Does, 22 June 2018 - 13:00.


Re: Should E2 be edited to accomodate plugins? #40 Rob van der Does

  • Senior Member
  • 7,766 posts

+184
Excellent

Posted 22 June 2018 - 13:05

FYI: in ui.py it says 'VERSION = "1.43" ', which would indicate the build date 10-03-2018.




0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users