Jump to content


Photo

nimmanager.somethingConnected() broken logic


  • Please log in to reply
74 replies to this topic

Re: nimmanager.somethingConnected() broken logic #21 Rob van der Does

  • Senior Member
  • 7,766 posts

+184
Excellent

Posted 27 June 2018 - 13:56

To needlessly limit yourself/your box.

Isn't that what peple that use loop through are already doing?

????
Not using an available tuner is a waste of resources. I can't possibly think of any reason not to loo-through if you have more tuners then feeds.

Re: nimmanager.somethingConnected() broken logic #22 Rob van der Does

  • Senior Member
  • 7,766 posts

+184
Excellent

Posted 27 June 2018 - 14:02

Don't get me wrong: of course it's a valid configuration and should be handled as such.
I only can't think of a valid reason to use such a configuration.

Re: nimmanager.somethingConnected() broken logic #23 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 27 June 2018 - 20:21

The code is needed for the combine the combined tuner stuff... sounds like oe-a gives up and allow work-a-round it so manufactures need to adapt threshold is lowered...

Edited by littlesat, 27 June 2018 - 20:23.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: nimmanager.somethingConnected() broken logic #24 Abu Baniaz

  • PLi® Contributor
  • 2,414 posts

+61
Good

Posted 27 June 2018 - 20:44

Code for a tuner configured should check if you have a tuner configured.

Check for an "isconnected" tuner should check if you have a combined tuner.

 

Are you suggesting that Solo2 and other 7356 CPUs can use a unicable LNB like an FBC tuner?


Edited by Abu Baniaz, 27 June 2018 - 20:46.


Re: nimmanager.somethingConnected() broken logic #25 Huevos

  • PLi® Contributor
  • 4,229 posts

+158
Excellent

Posted 27 June 2018 - 22:32

 and self.nim_slots[id].internally_connectable != id - 1

I removed that and combined tuner info still works fine, Here is a screen grab.

 

 

Attached File  grab.jpg   88.58KB   4 downloads

 

 

 



Re: nimmanager.somethingConnected() broken logic #26 Rob van der Does

  • Senior Member
  • 7,766 posts

+184
Excellent

Posted 28 June 2018 - 05:27

The code is needed for the combine the combined tuner stuff... sounds like oe-a gives up and allow work-a-round it so manufactures need to adapt threshold is lowered...

Not sure what you mean here?
The related code is E2-code, and there is no such thing as OE-A E2 (as even the name 'OE-A' suggests).

Re: nimmanager.somethingConnected() broken logic #27 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 28 June 2018 - 06:58

When you remove the code you can loop in software b to a which is not possible for vu.... it is just needed there for the vu ‘maddness’ but is indeed has a side effect on connecting a en disable b something you shouldn’t do... and that is why it is in as when it is not in e2 thinks there is a looo from a to b resukting in not possible to tune and/or black recordings

Edited by littlesat, 28 June 2018 - 07:02.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: nimmanager.somethingConnected() broken logic #28 Rob van der Does

  • Senior Member
  • 7,766 posts

+184
Excellent

Posted 28 June 2018 - 07:08

When you remove the code you can loop in software b to a which is not possible for vu....

VU+ Solo2 can only loop from B to A, not the other way around.

Re: nimmanager.somethingConnected() broken logic #29 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 28 June 2018 - 07:40

I know and that is why it is in...

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: nimmanager.somethingConnected() broken logic #30 Huevos

  • PLi® Contributor
  • 4,229 posts

+158
Excellent

Posted 28 June 2018 - 07:52

I don't understand this vagueness. Please can you provide a specific set of instructions to reproduce the error this code is attempting to cure.

I have removed this code and can't find any problem with the way the box run, neither in normal mode, nor in loopthrough.

Re: nimmanager.somethingConnected() broken logic #31 Rob van der Does

  • Senior Member
  • 7,766 posts

+184
Excellent

Posted 28 June 2018 - 09:21

When you remove the code you can loop in software b to a which is not possible for vu....

VU+ Solo2 can only loop from B to A, not the other way around.

 
 

I know and that is why it is in...

Now I'm lost; what you say is the other way around???

Re: nimmanager.somethingConnected() broken logic #32 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 28 June 2018 - 18:15

connect to a... set in config on b loop to a... should not be possible... as the box can’t do it...

Edited by littlesat, 28 June 2018 - 18:16.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: nimmanager.somethingConnected() broken logic #33 Abu Baniaz

  • PLi® Contributor
  • 2,414 posts

+61
Good

Posted 28 June 2018 - 21:24

As it stands:

 

Attach signal wire to tuner A. Configure tuner A to match what is attached to it. As an example, simple, single, 28.2

No signal wire attached to tuner B. Tuner B configured as "nothing connected".

 

Scanning menus are hidden. It is not possible to scan.

 

Is this situation intended?



Re: nimmanager.somethingConnected() broken logic #34 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 28 June 2018 - 21:48

Yes... you have to connect to B... when you connect A
And enable B as loop through it Will go wrong. When you connect B en enable A as loop through you have an extra tuner... actually Vu seapped A and B (incidentically) which makes this wierd... sounds mad and insain... but I cannot change that...
Actually for these vu boxes connecting only A and disabling tuner B is something you should not do as it limits the box features.... so gettng this situation should be weird... YOU
SIMPLY SHOULD CONNECT B AND LOOP A TO B... AND NOT CONNECT A AND DISABLE B... I Refuse to add a if vu then do something else work a round especially when it also limits the possible feature of the box...a hardware setup you never should do! Swap cable to B, when you like it disable A and issue is solved...

Edited by littlesat, 28 June 2018 - 21:54.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: nimmanager.somethingConnected() broken logic #35 Abu Baniaz

  • PLi® Contributor
  • 2,414 posts

+61
Good

Posted 28 June 2018 - 22:11

Why do you keep mentioning loop through? It is not being used.



Re: nimmanager.somethingConnected() broken logic #36 Huevos

  • PLi® Contributor
  • 4,229 posts

+158
Excellent

Posted 28 June 2018 - 22:24

Why do you keep mentioning loop through? It is not being used.

You have a twin tuner box. You only have one cable. How do you get the most out of that hardware? One cable to the principle tuner and one loopthrough. Any other setup is not getting the maximum from that hardware combo.

 

I don't agree with the above argument but that is the reason.

 

IMO, nimmanager.somethingConnected() should return True if something is connected (which it is). But Littlesat believes otherwise.



Re: nimmanager.somethingConnected() broken logic #37 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 28 June 2018 - 22:41

@Huevos,

 

There is something else behind it... maybe you weren't aware of it... But is seems this something else is solved in a different way... (I cannot find the patch at this moment)... See the comments in the patch...

 

And there were two sides...

 

1. For these boxes and 1 cable you SHOULD connect to B instead of A...

2. Why disable a tuner when you can have 2... even with 1 cable...

 

Which motivated me not to remove this extra check.... In addition the code was induced a year ago... and now results to a side effect for this one special wierd condition which for me signals an 'if box x to y' requirement - which we should not prefer... But I already made this clear...

 

When we discover side effects we can still revert it -or- consider this...

if self.somethingConnected(id) and not (self.nim_slots[id].isFBCLink() or self.getNimConfig(id).configMode.value == "loopthrough"):

 

But it seems this extra check here is not required as you currently cannot setup a loopthrough to a not connected tuner...


WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: nimmanager.somethingConnected() broken logic #38 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 28 June 2018 - 22:42

FYI

https://github.com/O...d497fa01204ee44


Edited by littlesat, 28 June 2018 - 22:43.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: nimmanager.somethingConnected() broken logic #39 littlesat

  • PLi® Core member
  • 56,123 posts

+685
Excellent

Posted 28 June 2018 - 22:47

It seems we indeed can better add the non loopthrough çonfigured check.... It might happen the config is on loopthrough (in the background) while the other tuner is not connected,,,

 

https://github.com/O...d0ed80438863cd1


WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: nimmanager.somethingConnected() broken logic #40 Huevos

  • PLi® Contributor
  • 4,229 posts

+158
Excellent

Posted 28 June 2018 - 23:40

@Huevos,

 

But it seems this extra check here is not required as you currently cannot setup a loopthrough to a not connected tuner...

I don't understand this. You can setup a loopthrough to any tuner. Don't forget external loopthrough.

 

Anyway look at this example.

 

Solo4K.

FBC Root = A-B

FBC LINK = C-H

AVL6222 DVB-S2 = I-J

 

Nimmanager allows us to configure tuner J loopthrough to FBC link tuner H. Obviously this is ridiculous but nimmanager allows it. So why block setups that are really valid?

 

And it also blocks other valid combinations such as SATPOSDEPENDS, tuner J to tuner A.

 

Thanks for the links.




0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users