8 replies to this topic

[mrvica]

some people like VolumeText on the VolumeBar, this can be achieved by an externel render (VolumeText.py) or directly patching /Screens/Volume.py, patch by vali

from Screen import Screen
from Components.VolumeBar import VolumeBar
from Components.Label import Label #NEW LINE

class Volume(Screen):
	def __init__(self, session):
		Screen.__init__(self, session)

		self.volumeBar = VolumeBar()

		self["Volume"] = self.volumeBar
		self["VolumeText"] = Label("") #NEW LINE

	def setValue(self, vol):
		print "setValue", vol
		self.volumeBar.setValue(vol)
		self["VolumeText"].setText(str(vol)) #NEW LINE

now only a widget is needed in your skin.xml, i.e for a fullhd skin, here volume screen without using any pixmaps (!)

<screen name="Volume" position="center,60" size="773,39" title="Volume" backgroundColor="#ff000000" zPosition="10" flags="wfNoBorder">
    <widget name="Volume" position="0,14" size="681,12" foregroundColor="#2397db" backgroundColor="#ff9c00" />
    <widget name="VolumeText" font="Regular;33" transparent="1" foregroundColor="#ff9c00" borderWidth="3" halign="center" position="698,2" size="75,36" />
</screen>

 

[mrvica]

push
no need for a render, doesn´t brake anything, just two more lines to Screens/Volume.py

[littlesat]

Can you offer a merge request?

[ims]

and if some people not like it ? What then ?

Edited by ims, 22 August 2018 - 16:07.

[mrvica]

you get VolumeText if you first activate it in the skin (example above), if not, no any will be shown, it does no harm to anything

[Persian Prince]

Can you offer a merge request?

 

Done: https://github.com/O...igma2/pull/1685

 

[Persian Prince]

This one is with empty lines removed: https://github.com/O...igma2/pull/1686

 

Choose what you want to merge

[Erik Slagter]

PP: if the empty lines where there already, leave them. If they were introduced by your patch, remove them in the patch. I was under the impression we already discussed this.

[mrvica]

ok, it is been since summer in GIT, for FullNightHD would look like this

<screen name="Volume" title="Volume" position="0,330" size="30,360" backgroundColor="transpBlack" zPosition="1" flags="wfNoBorder">
		<widget name="Volume" pixmap="PLi-FullNightHD/infobar/volumeslider.png" position="0,3" size="30,300" orientation="orBottomToTop" transparent="1" zPosition="1"/>
		<ePixmap pixmap="PLi-FullNightHD/infobar/vol_box.png" position="0,333" size="30,24" alphatest="on" zPosition="4"/>
		<widget name="VolumeText" font="Regular;17" backgroundColor="transpBlack" halign="center" position="0,310" size="30,18" />
	</screen>

Attached Files

•  volume1.png   13.6KB   2 downloads
•  volume2.png   21KB   0 downloads