Jump to content


Photo

@ims, MovieManager pull request


  • Please log in to reply
10 replies to this topic

#1 Huevos

  • PLi® Contributor
  • 2,277 posts

+116
Excellent

Posted 21 August 2018 - 16:20

Please accept this pull request else the plugin cannot be used in other builds, e.g. RC. It is just for an unused import that doesn't exist in other builds so causes a BSoD on opening the plugin.

 

https://github.com/i...eManager/pull/5



Re: @ims, MovieManager pull request #2 ims

  • PLi® Core member
  • 11,122 posts

+168
Excellent

Posted 21 August 2018 - 16:29

Weird ... In all our builds it must exists ... btw, for 4.0 and 6.1 this plugin is not determined


Edited by ims, 21 August 2018 - 16:32.

Kdo nic nedělá, nic nezkazí!

Re: @ims, MovieManager pull request #3 Huevos

  • PLi® Contributor
  • 2,277 posts

+116
Excellent

Posted 21 August 2018 - 16:51

The import is not used. If you accept the PR the plugin can be used in builds that do not have this import available.



Re: @ims, MovieManager pull request #4 IanSav

  • PLi® Contributor
  • 720 posts

+26
Good

Posted 21 August 2018 - 22:44

Hi Ims,

 

If the import is not used then it shouldn't be in the import list.  This could cause future issues.  Huevos' pull request has merit.

 

Regards,

Ian.



Re: @ims, MovieManager pull request #5 ims

  • PLi® Core member
  • 11,122 posts

+168
Excellent

Posted 22 August 2018 - 07:40

Fairy tales  :) 

It is not about future issues, IanSav...


Kdo nic nedělá, nic nezkazí!

Re: @ims, MovieManager pull request #6 Rob van der Does

  • Senior Member
  • 7,731 posts

+184
Excellent

Posted 22 August 2018 - 09:30

Correct, it's about current issues.
Thanks for merging.

Re: @ims, MovieManager pull request #7 ims

  • PLi® Core member
  • 11,122 posts

+168
Excellent

Posted 22 August 2018 - 09:32

Correct, it's about current issues.

 

But not under PLi !

 

Next time this measure will be permanent... ;)


Kdo nic nedělá, nic nezkazí!

Re: @ims, MovieManager pull request #8 IanSav

  • PLi® Contributor
  • 720 posts

+26
Good

Posted 22 August 2018 - 11:56

Hi Ims,

 

Fairy tales  :)

It is not about future issues, IanSav...

 

I'm sorry that you feel that this issue is a joke.  Having unused imports in code can result in crashes if the unused import is ever changed, moved or removed.  I have had to fix exactly this sort of issue before.

 

Still, it is your code, if you want to make it fragile it is your choice.

 

Regards,

Ian.



Re: @ims, MovieManager pull request #9 ims

  • PLi® Core member
  • 11,122 posts

+168
Excellent

Posted 22 August 2018 - 12:07

No, Ian, You have not true ... I think you were looking for something, what you did not have to look for. 

Boys done some extra work for me and this "unused" import (making problems for all non PLis images) was my reward for them ...


Kdo nic nedělá, nic nezkazí!

Re: @ims, MovieManager pull request #10 IanSav

  • PLi® Contributor
  • 720 posts

+26
Good

Posted 22 August 2018 - 12:11

Hi Ims,

 

Let's all play nice.  All the Enigma2 teams should be supporting each other and not laying traps.  :)

 

I hope you are noticing how hard I am working to make my code work on as many images as possible.  Coding for OpenPLi is not easy yet I am still trying hard to support it.  We should all be working together to support each other.

 

Regards,

Ian.



Re: @ims, MovieManager pull request #11 Pr2

  • PLi® Contributor
  • 3,606 posts

+153
Excellent

Posted 28 July 2019 - 20:12

Hi,

 

I have created this PR for MovieManager:

 

https://github.com/i...Manager/pull/17

 

Pr2


NO SUPPORT by PM, it is a forum make your question public so everybody can benefit from the question/answer.
If you think that my answer helps you, you can press the up arrow in bottom right of the answer.

Wanna help with OpenPLi Translation? Please read our Wiki Information for translators

Sat: Hotbird 13.0E, Astra 19.2E, Eutelsat5A 5.0W
VU+ Solo 4K: 2*DVB-S2 + 2*DVB-C/T/T2 (used in DVB-C) & Duo 4K: 2*DVB-S2X + DVB-C (FBC)
Edision OS Mio 4K: 1*DVB-S2X + 1*DVB-C/T/T2
 





1 user(s) are reading this topic

0 members, 1 guests, 0 anonymous users