116 replies to this topic

[Rob van der Does]

I ran some 30 more tests: sometimes it goes well, sometimes it goes wrong.

What always goes fine, is the manually started import.

What sometimes goes wrong (around 30% of the trials), is the automated import, both after booting and after E2-restart.

I switched epg.dat location to an internal HDD but that made no difference.

[ims]

Nope... somewhere in E2 (cpp I think) where the epg.dat file is read...

epgcache.cpp ?

[littlesat]

Can be... then there we need to retrieve the config and do not load it...

[littlesat]

Maybe we should consider to do this around line 1281 in epgcache.cpp.... sorry I'm not able to test it right now!

void eEPGCache::thread()
{
  hasStarted();
  nice(4);
- load();
+ if (eConfigManager::getConfigValue("config.usage.remote_fallback_import").find("epg") == std::string::npos)
+ {
+ load();
+ }
  cleanLoop();
  runLoop();
  save();
}

Edited by littlesat, 29 August 2018 - 10:25.

[betacentauri]

No, that won’t work!!!
See here:
https://github.com/O...189ce982d80a5f2

[littlesat]

Indeed because it is in a thread... so we need a global variable that 'catches' it...  m_loadepg ? defined in epgcache.h, value grabbed were the cache is declared and then use the m_loadepg instead...

Edited by littlesat, 29 August 2018 - 12:43.

[Rob van der Does]

Wrong thread....

Edited by Rob van der Does, 29 August 2018 - 16:15.

[Pr2]

Be very careful with this option there is a major bug that make the channel import being active even if Remote Fallback receiver is turned off!

So it replaces all your local favorites with the one of the master, and delete all the local box specific favorites too!

 

Here is my setup screenshot in attachement.

 

 FallbackTunerSetup.jpg   103.76KB   8 downloads

 

A ticket is already created:

https://devtools.ope....org/issues/365

Edited by Pr2, 29 August 2018 - 18:25.

[littlesat]

When the server box is turned off is coverded... nothing Will be overwritten as this situation is recognized

[Pr2]

When the option is totally off, the channels should not be changed in the remote box! This is clearly a bug.

Please read the ticket that I create on devtools.

 

Look at the screenshot and explain me which option is enable on it that says to the remote box to overwrite its local setting and use the one from the server?  All is turned off!

 

Moreover remote box can have capabilities that the server don't have (like multi input stream, or DVB-C or DVB-T) all you do is delete the entries from the lamedb and delete the favorites that are not on the server box, this is totally crazy!

 

This option is now only useful for people that have a remote box without any tuner, we lose the advantages of the former solution where the remote tuner was used when local tuners are not available.

The way this option is done today is dangerous!

 

Pr2

[Pr2]

Here is the patch to fix this bug, please merge.

https://github.com/O...igma2/pull/1708

Tested successfully.

Anyway the whole implementation should be review to ALWAYS take care of this parameter: config.usage.remote_fallback_enabled first before performing any action related to it!

 

This patch will only protect from overwriting the channel list and lamedb when the config.usage.remote_fallback_enabled.value is FALSE.

 

Moreover this must be improved to create a smart import of lamedb (and not a pure overwrite like it does today) same applied for bouquets, imported bouquet should be tagged as remote (perhaps adding the server name at the end of the bouquet name) and leave the local untouched!

There is nothing strange to have local bouquets and remote bouquets on the same device.

 

This option should not be reserved only for people that use a pure remote box without tuner.

The former approach was much more better than the current one.

 

Pr2

[littlesat]

Thanks done... sounds like my mistake...

 

Now we still need to have a patch for the EPG reload...

Edited by littlesat, 30 August 2018 - 10:22.

[littlesat]

FYI: https://github.com/O...df7b676bb1adc05

[ims]

I am affraid, that there it is still finishing after restart GUI with "epg.dat.loading" ... 12MB...

 

Tried:

- remove manualy epg.dat

- restart GUI ... created epg.dat (from local cache, cca 1MB)

- display logo ... epg.dat is removed and is created epg.dat.loading with full EPG from server, but it is not renamed to epg.dat => nothing is loaded

 

Tried remove epg.dat, if is created after start restarting GUI. Is created epg.dat again and imediatelly is removed and is created epg.dat.loading.

[Pr2]

And once again you consider that this option is dedicated only for pure remote boxes without tuner that have local capabilities that are not on the server box (DVB-C, DVB-T, DVB-S2(MIS),...).

 

Please review the design of this implementation to make it smart and friendly with hybrid system, where we want both to use local box capabilities and server box, like this option foreseen at the very beginning.

[littlesat]

???? Let’s wait wat happens tomorrow...

[ims]

???? Let’s wait wat happens tomorrow...

???  tried it today with your fix

[littlesat]

Sorry the .loading I don’t understand...’and that the name does not change... does it mean we need to remove the current epg.dat before loading (can be done in python)? Or does it mean the epg.dat is read before it is loaded?

Edited by littlesat, 2 September 2018 - 18:14.

[ims]

There is created after restart GUI:   epg.dat for cca .5sec, then is removed (will disappear) and then will appear file with name:  epg.dat.loading

Thats all.

If is box rebooted, epg.dat.loading is there too, but in final is epg.dat.loading moved to epg.dat imho.

 

Could not be epg.dat.loading created with download utility as "temp", if there exist in same time epg.dat ?  May be, disable creating epg.dat, when is used import ?

Edited by ims, 2 September 2018 - 20:02.

[Rob van der Does]

Correct: during the epg reading process (after reboot/restart) the name 'epg,dat'  temporarily changes to 'epg.dat.loading'. I assume this also applies to the epg.dat of the serverbox during the epg import of the client box (as on the server box an epg--> save is being carried out).