62 replies to this topic

[Pr2]

Just my two cents:

 

We saw now this

 

Audio PID, codec & lang:      0529(1321) - AC3 - FRA

 

Won't it be better looking to have in the description:

 

Audio PID - codec - lang:

 

So we have the same separator in the description and in the displayed information.

 

Same applied for:

DVB Subtitles PID & lang

Video Codec, size & format

 

Purely cosmetic but better looking and more clear

 

Pr2

 

P.S.: Personnaly I am not hurted by the Lang in uppercase, I feel it also better looking.

Edited by Pr2, 13 December 2018 - 23:18.

[ims]

About 'Audio PID - codec - lang'  ...  it is cosmetic ... it can do any translator, if will want. For me is better 'Audio PID, codec & lang', f.eg.

 

About uppercase of iso693 codes ... codes should be displayed, as are broadcasted, imho. This page should be info for developer in most cases and should save work.

When will be f.eg. problem in language code, you will see it immediatelly. If it will be uppercased, then you cannot see, if provider have there typo or not ... you will see 'ENG' and not 'eng' or 'Eng' or 'eNg' ...

(Some provider is all able  - f.eg. FreeSat broadcasting Slovenian subtitles on History HD with Slovak code more than half year and is not power change it...)

[MCelliotG]

Can someone check this line please?

trackList += [(_("Audio PID%s, codec & lang" % ((" %s") % (i + 1) if self.numberofTracks > 1 and self.showAll else "")), "%04X (%d) - %s - %s" % (to_unsigned(audioPID), audioPID, audioDesc, audioLang), TYPE_TEXT)]

Because "Audio PID%s, codec & lang" is not translatable.
"Audio PID, codec & lang" is translated normally, but once you toggle to multiple pids the translation reverts back to English (source).

Thanks in advance!

 

 

 

Edited by MCelliotG, 16 December 2018 - 01:17.

[jpuigs]

Pr2 asked on https://devtools.ope....org/issues/435 …

 

Is this what you want ?

 

 9.jpg   160.21KB   6 downloads                 9_2.jpg   237.12KB   5 downloads

 

 

[MCelliotG]

When there are multiple pids the string is not translated to another language. Something breaks the translation so it should be checked.

Στάλθηκε από το Redmi Note 5 Pro μου χρησιμοποιώντας Tapatalk

[Pr2]

Pr2 asked on https://devtools.ope....org/issues/435 …

 

Is this what you want ?

 

9.jpg               9_2.jpg

 

Yes indeed that's what I was thinking about. :-)

[jpuigs]

we should ask littlesat&co whether to aply it or not....

[jpuigs]

 

"Audio PID%s, codec & lang" is not translatable.

"Audio PID, codec & lang" is translated normally, but once you toggle to multiple pids the translation reverts back to English (source).

 

I never use translations on all devices, always use english language menus, translations don't like me at all.

But I've switched mine to spanish and French GUI, and I always see "Audio PID, codec & Lang".

I supose po files should be modified, but I don't really know wheter it's possible to do it dinamically, as this label content.

[littlesat]

With %s is also translatable....

[Pr2]

we should ask littlesat&co whether to aply it or not....

 

You can apply it I already contact Littlesat and he approuves the idea, so you can go for it.

[MCelliotG]

I try the latest po file to update the Greek translation as always. The %s string is not translatable in this case, the string is contained in the po normally but when used in action reverts to English.

Pr2 can you check if it gets translated in French?

 

Here's an example in my test translation

Line in el.po
msgid "Audio PID, codec & lang"
msgstr "PID Ήχου, κωδικοποιητής & γλώσσα"

This is translated normally

 

whereas:

msgid "Audio PID%s, codec & lang"
msgstr "PID Ήχου%s, κωδικοποιητής & γλώσσα"

 

Once it contains a number it reverts back to English, although it's correct in the po. Seems like the %s parameter misses something in the code and breaks the translation in this case. All other strings containing %s in the po have no problem at all!

 

[Pr2]

 

 

"Audio PID%s, codec & lang" is not translatable.

"Audio PID, codec & lang" is translated normally, but once you toggle to multiple pids the translation reverts back to English (source).

 

I never use translations on all devices, always use english language menus, translations don't like me at all.

But I've switched mine to spanish and French GUI, and I always see "Audio PID, codec & Lang".

I supose po files should be modified, but I don't really know wheter it's possible to do it dinamically, as this label content.

 

 

French translation are done and working in develop branch, don't worry it is working.

[Pr2]

Hi,

 

https://github.com/O...iceInfo.py#L217

 

I am not a python expert but isn't it a cast mismatch?

 

i is an integer and it is displayed with a %s like if it was a string but it is not. So I think that a str(i) is missing to properly convert it to be displayed.

Or change the %s in %d (if I am not mistaken).

 

Pr2

Edited by Pr2, 16 December 2018 - 12:55.

[MCelliotG]

And the space should not be contained in the %s as well?

                    trackList += [(_("Audio PID %s, codec & lang" % (("%s") % (i + 1) if self.numberofTracks > 1 and self.showAll else "")), "%04X (%d) - %s - %s" % (to_unsigned(audioPID), audioPID, audioDesc, audioLang), TYPE_TEXT)]

 

 

Now, I see the French translation does not work on it either.

 

msgid "Audio PID%s, codec & lang"

msgstr "PID audio %s, codec & lang"

Edited by MCelliotG, 16 December 2018 - 13:16.

[ims]

btw - gettext translating all, what is in _(" ") 

[jpuigs]

I've tried replacing the space with a "-", tried moving or deleting space, etc....  and it always works the same way.

Where is located the "translator" ?

We should see how it works....

[jpuigs]

The language converters may not work fine... when in po files, audio selection and EPG language are defined as follows:

msgid "Audio language selection 1"
msgstr "Selección de idioma de audio 1"
msgid "Audio language selection 2"
msgstr "Selección de idioma de audio 2"
msgid "Audio language selection 3"
msgstr "Selección de idioma de audio 3"
msgid "Audio language selection 4"
msgstr "Selección de idioma de audio 4"
msgid "EPG language selection 1"
msgstr "Selección del idioma EPG 1"
msgid "EPG language selection 2"
msgstr "Selección del idioma EPG 2"

Why aren't they defined in one line, using %d or %s ????

 

[littlesat]

Because they are not defined in a loop in usageconfig... and actually when we di not use standard configscreen and maken a change in cpp and the last ends in None.. we could support endless support languages (except for epg...)

Edited by littlesat, 16 December 2018 - 14:18.

[jpuigs]

You can apply it I already contact Littlesat and he approuves the idea, so you can go for it.

 

 

Merge request done, 

https://github.com/O...igma2/pull/1882

[jpuigs]

I know most of you will find it horrible, but my "perfect" Serviceinfo screen would be like that....

 

 full-serviceinfo.jpg   254.74KB   3 downloads