Posted 10 December 2018 - 18:37
https://github.com/O...f7ae3ad7afe6b6f
What is the point in this commit?
strstr(str1, str2) finds str2 in str1. So the two cases that have been added would have been found by the first case (that was already there).
So this commit does absolutely nothing except add extra code.
Posted 10 December 2018 - 19:00
I'd assume littlesat checked the code before merging it?
Currently in use: VU+ Duo 4K (2xFBC S2), VU+ Solo 4K (1xFBC S2), uClan Usytm 4K Pro (S2+T2), Octagon SF8008 (S2+T2), Zgemma H9.2H (S2+T2)
Due to my bad health, I will not be very active at times and may be slow to respond. I will not read the forum or PM on a regular basis.
Many answers to your question can be found in our new and improved wiki.
Posted 10 December 2018 - 19:30
My point is this...
If the "haystack" is "BCM4506 (internal)" or the "haystack" is "BCM4506", then checking the "needle" "BCM4506" will already return true in both cases. So adding a second "needle" is absolutely pointless because that code will never get to that test.
Would be different if this were an equality test. But it is not. It is an "in" test.
Edited by Huevos, 10 December 2018 - 19:32.
Posted 10 December 2018 - 21:32
0 members, 0 guests, 0 anonymous users
