Jump to content


Photo

Skinning the scroll bar


  • Please log in to reply
17 replies to this topic

#1 Huevos

  • PLi® Contributor
  • 4,247 posts

+158
Excellent

Posted 11 December 2018 - 08:53

https://github.com/O...omment-31625720

 

That commit was added a few days ago so we can skin the scroll bar. But that means we have to skin the scroll bar in every single screen. That is crazy and adds around 500 lines of code to the skin.

 

So, how can we skin the scroll bar once and use those settings globally throughout the whole skin?


Edited by Huevos, 11 December 2018 - 08:55.


Re: Skinning the scroll bar #2 ims

  • PLi® Core member
  • 13,625 posts

+212
Excellent

Posted 11 December 2018 - 09:00

and "scrollbarSliderForegroundColor" parameter has no effect for SelectionList


Kdo nic nedělá, nic nezkazí!

Re: Skinning the scroll bar #3 littlesat

  • PLi® Core member
  • 56,274 posts

+691
Excellent

Posted 11 December 2018 - 10:20


That commit was added a few days ago so we can skin the scroll bar. But that means we have to skin the scroll bar in every single screen. That is crazy and adds around 500 lines of code to the skin.

 

So, how can we skin the scroll bar once and use those settings globally throughout the whole skin?

For > 15 years nobody wants to modify that scrollbar... so there is no real big need to do so... :D...

In addition it is not possible to make a template of a scrollbar and that is actually what needs to be done to do it with less code... 

The thinks in the parameter session are of course general. Of course it could be done that more defaults of the scrollbar are forwarded via the parameter 'session'.


Edited by littlesat, 11 December 2018 - 10:22.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Skinning the scroll bar #4 Dimitrij

  • PLi® Core member
  • 10,023 posts

+338
Excellent

Posted 11 December 2018 - 18:45

and "scrollbarSliderForegroundColor" parameter has no effect for SelectionList

Yes, users complained about this bug.


GigaBlue UHD Quad 4K /Lunix3-4K/Solo 4K


Re: Skinning the scroll bar #5 betacentauri

  • PLi® Core member
  • 7,185 posts

+323
Excellent

Posted 11 December 2018 - 19:01

I'm quite sure that it worked in a Listbox.


Xtrend ET-9200, ET-8000, ET-10000, OpenPliPC on Ubuntu 12.04

Re: Skinning the scroll bar #6 mrvica

  • Senior Member
  • 1,227 posts

+82
Good

Posted 11 December 2018 - 19:30

scrollbar width should be skinnable too, it is just too thick, it is still hard coded
https://github.com/O...elistbox.cpp#L9

Re: Skinning the scroll bar #7 littlesat

  • PLi® Core member
  • 56,274 posts

+691
Excellent

Posted 11 December 2018 - 19:56

That’s the default... nobody yells for more than 15 years about this... so why is it such subject now?

Edited by littlesat, 11 December 2018 - 19:57.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Skinning the scroll bar #8 betacentauri

  • PLi® Core member
  • 7,185 posts

+323
Excellent

Posted 11 December 2018 - 20:10

Littlesat don't ask why. Every user and skinner is different. In most cases default scrollbar is ok for me, but in some cases it's quite nice to be able to change the scrollbar.

Question is whether there is somebody who is able to improve it and has time to do it.

 

I think I'm out. I have no idea what to do. The GUI and skin things are a closed book for me.


Xtrend ET-9200, ET-8000, ET-10000, OpenPliPC on Ubuntu 12.04

Re: Skinning the scroll bar #9 mrvica

  • Senior Member
  • 1,227 posts

+82
Good

Posted 11 December 2018 - 20:28

in FHD skin is scrollwidth ok (20 pixels out of 1920), in HD skin it is quite thick (20 pixels out of 1280), we have nowadays large flat screens and no more CRT TV´s, no need for 20 pixels scrollbar



Re: Skinning the scroll bar #10 Taapat

  • PLi® Core member
  • 2,343 posts

+120
Excellent

Posted 11 December 2018 - 20:34

@mrvica after these changes with the parameter scrollbarWidth you can change the scrollbar width: https://github.com/O...istbox.cpp#L627



Re: Skinning the scroll bar #11 mrvica

  • Senior Member
  • 1,227 posts

+82
Good

Posted 11 December 2018 - 20:56

you mean to put in the skin like this

<parameters>
......................
<parameter name="scrollbarWidth" value="10" />
......................

well I need to recompile the image, do I?

Re: Skinning the scroll bar #12 Taapat

  • PLi® Core member
  • 2,343 posts

+120
Excellent

Posted 11 December 2018 - 21:05

Huevos in the first post point to the commit.

But this is possible only in the  develop branch, whose images are not publicly available.
You need to add scrollbarWidth="10" to the scrollbar parameters:

For example:

<widget source="list" render="Listbox" position="10,10" size="355,300" scrollbarMode="showOnDemand" scrollbarWidth="10">


Re: Skinning the scroll bar #13 littlesat

  • PLi® Core member
  • 56,274 posts

+691
Excellent

Posted 11 December 2018 - 21:29

That was indeed what I meant... with parameter arrange a new default setting... currently for each list it is a parameter....

Edited by littlesat, 11 December 2018 - 21:29.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Skinning the scroll bar #14 Huevos

  • PLi® Contributor
  • 4,247 posts

+158
Excellent

Posted 11 December 2018 - 22:46

 

Huevos in the first post point to the commit.

But this is possible only in the  develop branch, whose images are not publicly available.
You need to add scrollbarWidth="10" to the scrollbar parameters:

For example:

<widget source="list" render="Listbox" position="10,10" size="355,300" scrollbarMode="showOnDemand" scrollbarWidth="10">

No that is changing the scrollbar on a screen by screen basis. That requires changes to hundreds of lines in the skin. To make skinning the scrollbar practical it should be possible to set the parameters in one place in the skin and those settings apply to every scrollbar that is not individually skinned.


Edited by Huevos, 11 December 2018 - 22:49.


Re: Skinning the scroll bar #15 Taapat

  • PLi® Core member
  • 2,343 posts

+120
Excellent

Posted 12 December 2018 - 08:00

No that is changing the scrollbar on a screen by screen basis. That requires changes to hundreds of lines in the skin. To make skinning the scrollbar practical it should be possible to set the parameters in one place in the skin and those settings apply to every scrollbar that is not individually skinned.

 
I only answered mrvica how to set the scrollbar width using the current changes.
I understand your question, as already mentioned, we already had an internal discussion that we should implement a global setup for this, and maybe for all other local parameters.


Edited by Taapat, 12 December 2018 - 08:01.


Re: Skinning the scroll bar #16 Huevos

  • PLi® Contributor
  • 4,247 posts

+158
Excellent

Posted 12 December 2018 - 09:29

Well can we have the same discussion on the public forum so everyone can participate?



Re: Skinning the scroll bar #17 littlesat

  • PLi® Core member
  • 56,274 posts

+691
Excellent

Posted 12 December 2018 - 11:15

Sure...


WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Skinning the scroll bar #18 ims

  • PLi® Core member
  • 13,625 posts

+212
Excellent

Posted 12 December 2018 - 12:06

 

I'm quite sure that it worked in a Listbox.

Should not be in it, that SelectionList(MenuList) using in final eListboxPythonMultiContent ?


Kdo nic nedělá, nic nezkazí!


0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users