Jump to content


Photo

Dead code


  • Please log in to reply
18 replies to this topic

#1 Huevos

  • Senior Member
  • 2,026 posts

+107
Excellent

Posted 5 January 2019 - 03:31

AFAIK this code is dead, unless someone knows better.

https://github.com/O...ig.py#L208-L213
https://github.com/O...Info.py#L65-L66



Re: Dead code #2 littlesat

  • PLi® Core member
  • 46,854 posts

+490
Excellent

Posted 5 January 2019 - 09:54

Why is it dead? Isn’t the config in Userconfig.py? (Where the proc is set)

Edited by littlesat, 5 January 2019 - 09:55.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Dead code #3 athoik

  • PLi® Core member
  • 7,762 posts

+275
Excellent

Posted 5 January 2019 - 10:05

There are no procs anymore, so code is dead, that is what Huevos trying to say.

root@vusolo4k:~# find /proc/stb/frontend/fbc/ | sort
/proc/stb/frontend/fbc/
/proc/stb/frontend/fbc/fcc
/proc/stb/frontend/fbc/fcc_choices

Wavefield T90: 0.8W - 1.9E - 4.8E - 13E - 16E - 19.2E - 23.5E - 26E - 33E - 39E - 42E - 45E on EMP Centauri DiseqC 16/1
Unamed: 13E Quattro - 9E Quattro on IKUSI MS-0916

Re: Dead code #4 Huevos

  • Senior Member
  • 2,026 posts

+107
Excellent

Posted 5 January 2019 - 10:07

It was there for Vu Solo4k and Ultimo4K. I think the /proc is gone and Vu just leaves the sockets powered 24/7/365.



Re: Dead code #5 littlesat

  • PLi® Core member
  • 46,854 posts

+490
Excellent

Posted 5 January 2019 - 10:44

Then vu makes likely a mistake on these boxes... AMD probably this might also clarify the tuning errors I sometimes see on the forum. but there are other boxes that also have the proc as far I know.... is there a reason vu stopped it?

Edited by littlesat, 5 January 2019 - 10:45.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Dead code #6 Erik Slagter

  • PLi® Core member
  • 44,821 posts

+489
Excellent

Posted 5 January 2019 - 10:55

Huevos is right. VU+ discontinued disabling power to FBC tuners when not used and hence the interface was removed.

 

I can only guess for the reasoning behind it, but I think it can't be made working properly, as backed by the large number of complaints about it.


* Wavefrontier T90 with 28E/23E/19E/13E/9E/4.8E/0.8W/5W via SCR switches 2 x 2 x 6 user bands
* Ziggo digital cable TV (FTA)
I don't read PM -> if you have something to ask or to report, do it in the forum so others can benefit. I don't take freelance jobs.
Ik lees geen PM -> als je iets te vragen of te melden hebt, doe het op het forum, zodat anderen er ook wat aan hebben.

Re: Dead code #7 littlesat

  • PLi® Core member
  • 46,854 posts

+490
Excellent

Posted 5 January 2019 - 12:42

Then we whould indeed consider to revert it...


WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Dead code #8 Erik Slagter

  • PLi® Core member
  • 44,821 posts

+489
Excellent

Posted 5 January 2019 - 20:12

We should not consider it, we should simply do it. It's dead code, nothing is using it.

 

I did not add the code, so any volunteer who did?


Edited by Erik Slagter, 5 January 2019 - 20:12.

* Wavefrontier T90 with 28E/23E/19E/13E/9E/4.8E/0.8W/5W via SCR switches 2 x 2 x 6 user bands
* Ziggo digital cable TV (FTA)
I don't read PM -> if you have something to ask or to report, do it in the forum so others can benefit. I don't take freelance jobs.
Ik lees geen PM -> als je iets te vragen of te melden hebt, doe het op het forum, zodat anderen er ook wat aan hebben.

Re: Dead code #9 littlesat

  • PLi® Core member
  • 46,854 posts

+490
Excellent

Posted 5 January 2019 - 20:20

I have to hold on... maybe monday or tuesday I can do it...

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Dead code #10 Abu Baniaz

  • Senior Member
  • 759 posts

+19
Neutral

Posted 5 January 2019 - 22:18

https://github.com/O...igma2/pull/1947

Re: Dead code #11 Erik Slagter

  • PLi® Core member
  • 44,821 posts

+489
Excellent

Posted 6 January 2019 - 10:26

I think this patch is incomplete. It seems to missing the code wher these proc entries are written?


* Wavefrontier T90 with 28E/23E/19E/13E/9E/4.8E/0.8W/5W via SCR switches 2 x 2 x 6 user bands
* Ziggo digital cable TV (FTA)
I don't read PM -> if you have something to ask or to report, do it in the forum so others can benefit. I don't take freelance jobs.
Ik lees geen PM -> als je iets te vragen of te melden hebt, doe het op het forum, zodat anderen er ook wat aan hebben.

Re: Dead code #12 littlesat

  • PLi® Core member
  • 46,854 posts

+490
Excellent

Posted 6 January 2019 - 11:35

Hold on

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Dead code #13 littlesat

  • PLi® Core member
  • 46,854 posts

+490
Excellent

Posted 6 January 2019 - 11:37

Already solved by Hains.... Indeed there was still some more Dead code... ;).... Sounds we need to have new builds as the current loops in GSOD...

 

https://github.com/O...eb914093b40826b


Edited by littlesat, 6 January 2019 - 11:38.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Dead code #14 foxbob

  • Senior Member
  • 244 posts

+9
Neutral

Posted 8 January 2019 - 11:55

File "/usr/lib/enigma2/python/Components/ActionMap.py", line 49, in action
File "/usr/lib/enigma2/python/Screens/Satconfig.py", line 539, in keySave
File "/usr/lib/enigma2/python/Screens/Satconfig.py", line 348, in run
File "/usr/lib/enigma2/python/Screens/Satconfig.py", line 668, in saveAll
KeyError: 'HasForceLNBOn

Re: Dead code #15 Beeker

  • Senior Member
  • 849 posts

+135
Excellent

Posted 8 January 2019 - 12:08

PR.

https://github.com/O...igma2/pull/1954


DM8000.  Wavefrontier T55  13.0|19.2|23.5|28.2 + Ziggo.


Re: Dead code #16 betacentauri

  • PLi® Core member
  • 4,883 posts

+232
Excellent

Posted 8 January 2019 - 12:28

Merged.


Xtrend ET-9200, ET-8000, ET-10000, OpenPliPC on Ubuntu 12.04

Re: Dead code #17 Beeker

  • Senior Member
  • 849 posts

+135
Excellent

Posted 8 January 2019 - 12:37

Thanks.


DM8000.  Wavefrontier T55  13.0|19.2|23.5|28.2 + Ziggo.


Re: Dead code #18 littlesat

  • PLi® Core member
  • 46,854 posts

+490
Excellent

Posted 8 January 2019 - 14:36

Omg

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Dead code #19 foxbob

  • Senior Member
  • 244 posts

+9
Neutral

Posted 8 January 2019 - 14:46

Thanks.






0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users