←  [EN] Enduser support

Forums

»

Dead code

's foto Huevos 5 jan 2019

AFAIK this code is dead, unless someone knows better.

https://github.com/O...ig.py#L208-L213
https://github.com/O...Info.py#L65-L66

Citeren

's foto littlesat 5 jan 2019

Why is it dead? Isn’t the config in Userconfig.py? (Where the proc is set)
Veranderd door littlesat, 5 januari 2019 - 09:55
Citeren

's foto athoik 5 jan 2019

There are no procs anymore, so code is dead, that is what Huevos trying to say.

root@vusolo4k:~# find /proc/stb/frontend/fbc/ | sort
/proc/stb/frontend/fbc/
/proc/stb/frontend/fbc/fcc
/proc/stb/frontend/fbc/fcc_choices
Citeren

's foto Huevos 5 jan 2019

It was there for Vu Solo4k and Ultimo4K. I think the /proc is gone and Vu just leaves the sockets powered 24/7/365.

Citeren

's foto littlesat 5 jan 2019

Then vu makes likely a mistake on these boxes... AMD probably this might also clarify the tuning errors I sometimes see on the forum. but there are other boxes that also have the proc as far I know.... is there a reason vu stopped it?
Veranderd door littlesat, 5 januari 2019 - 10:45
Citeren

's foto Erik Slagter 5 jan 2019

Huevos is right. VU+ discontinued disabling power to FBC tuners when not used and hence the interface was removed.

 

I can only guess for the reasoning behind it, but I think it can't be made working properly, as backed by the large number of complaints about it.

Citeren

's foto littlesat 5 jan 2019

Then we whould indeed consider to revert it...

Citeren

's foto Erik Slagter 5 jan 2019

We should not consider it, we should simply do it. It's dead code, nothing is using it.

 

I did not add the code, so any volunteer who did?


Veranderd door Erik Slagter, 5 januari 2019 - 20:12
Citeren

's foto littlesat 5 jan 2019

I have to hold on... maybe monday or tuesday I can do it...
Citeren

's foto Erik Slagter 6 jan 2019

I think this patch is incomplete. It seems to missing the code wher these proc entries are written?

Citeren

's foto littlesat 6 jan 2019

Hold on
Citeren

's foto littlesat 6 jan 2019

Already solved by Hains.... Indeed there was still some more Dead code... ;).... Sounds we need to have new builds as the current loops in GSOD...

 

https://github.com/O...eb914093b40826b


Veranderd door littlesat, 6 januari 2019 - 11:38
Citeren

's foto foxbob 8 jan 2019

File "/usr/lib/enigma2/python/Components/ActionMap.py", line 49, in action
File "/usr/lib/enigma2/python/Screens/Satconfig.py", line 539, in keySave
File "/usr/lib/enigma2/python/Screens/Satconfig.py", line 348, in run
File "/usr/lib/enigma2/python/Screens/Satconfig.py", line 668, in saveAll
KeyError: 'HasForceLNBOn
Citeren

's foto betacentauri 8 jan 2019

Merged.

Citeren

's foto Beeker 8 jan 2019

Thanks.

Citeren

's foto littlesat 8 jan 2019

Omg
Citeren

's foto foxbob 8 jan 2019

Thanks.

Citeren