116 replies to this topic

[Pr2]

Hi,

Repository:

https://github.com/E...n-FileCommander

is now populated, during fr translation I find out and fix some typo in the source code.

@Pike_Bishop,

Can you please review the de.po accordingly?

https://github.com/p...ileCommander.po

@mrvica,

I have included the fix you refer to.

Thanks,

Pr2

[littlesat]

Sorry I just did a Quality check on this plugin...

 

It seems for example that the plugin uses os.system calls instead of Console().ePopen(). This should be changed as this is 'expensive' and therefore this is not following the OpenPLi's standard.

 

Some of them could also be replaced by os.rename or os.chmod, in addons/key_actions.py it should be done with a callback to self.doRefresh(). The other ones do not need a callback (as there is a break behind it or the last call within the function)

 

As this is an 'expensive bug' I suggest this has to be fixed.

 

https://github.com/p...s.system"&type=

Edited by littlesat, 2 August 2019 - 15:20.

[Pike_Bishop]

 

@Pike_Bishop,

Can you please review the de.po accordingly?

https://github.com/p...ileCommander.po

 

"page not found" - removed ?

 

 

regards

Pike

[Pike_Bishop]

found it, you mean this;

https://raw.githubus...ileCommander.po

i will check, coming soon.

[Pike_Bishop]

Hi Pr2,

 

here the Filecommander.po for de language all ok;

 

 FileCommander.po_for_de_checked.zip   7.61KB   6 downloads

 

 

regards

Pike

 

[Pike_Bishop]

this commit also can build in;

https://github.com/o...8d0dcc3fa8486c8

i have tested last night, and all ok with it.

 

 

regards

Pike

[Pr2]

Hi,

Thanks both changes applied.

Pr2

[littlesat]

And now remove the os.system calls please...

[Frenske]

I will do the Dutch language in a few days.
I guess all I need it the POT?

[Pr2]

The pot file is in the repository. You can just just download it from there.

[Frenske]

I was aware of that but just needed the confirmation that I just needed the POT.

[Pr2]

Yes download the pot create a new translation in PoEdit and select the pot file.

[foxbob]

After https://github.com/E...b67d3f2745a0699

Attached Files

•  1_0_16_70C_12_70_1680000_0_0_0_20190805221253.jpg   106.84KB   1 downloads

[Persian Prince]

Are you sure it's related to my commit?

 

It says you don't have the pyo file: https://github.com/E.../key_actions.py

 

Check your plugin folder and if you don't have this file you can't use the plugin.

[Persian Prince]

The problem is https://github.com/O...ilecommander.bb won't install https://github.com/E...r/plugin/addons folder because it's not defined in https://github.com/E...master/setup.py

[aouamed]

Persian Prince

I have the same problem ... but I add "file addons" to the plugin and it works but copy and paste do not work!

[MCelliotG]

Here's the Greek translation for this plugin, easy task since it was already fully translated for OpenATV...

please merge into Github, the structure over there for this plugin is a bit strange to pull the request directly!

 FileCommander - el.zip   8.88KB   3 downloads

Edited by MCelliotG, 6 August 2019 - 01:16.

[Pr2]

The problem is https://github.com/O...ilecommander.bb won't install https://github.com/E...r/plugin/addons folder because it's not defined in https://github.com/E...master/setup.py

 

I know so I am looking for someone able to properly create the setup.py to include it.

[Pr2]

Here's the Greek translation for this plugin, easy task since it was already fully translated for OpenATV...

please merge into Github, the structure over there for this plugin is a bit strange to pull the request directly!

FileCommander - el.zip

 

Thanks the translation is now pushed.

By the way this plugin as the same structure as other plugin in this repository so there is nothing strange in it.

Edited by Pr2, 6 August 2019 - 19:59.

[Frenske]

I’m still busy with the Dutch translation but to be honest some lines are hard to translate without having actually noticed the whole context as the plugin doesn’t work yet in Develop.