111 replies to this topic

[WanWizard]

Thanks, merged.

[littlesat]

Thanks was my mistake

[Persian Prince]

Thanks was my mistake

 

No worries we all are losing our eyes

 

Thank you for your great new changes.

[FRAP]

the person who does nothing is not mistaken 

[littlesat]

Yes it was indeed big and mutch... another mistake was that I adapt it in our hd ready skins without any complaint

Edited by littlesat, 29 August 2019 - 20:00.

[Pike_Bishop]

Hi,

 

Plugin works very good - thanks guys.

it is also skínned for full-hd but not complete i think, here a picture;

 msg-19795-0-72560700-1572991980.jpg   58.77KB   3 downloads

 

it's the screen in that you can install a *.ipk package

 

testet with PLI-7.2rc from date 05.11.2019

 

 

regards

Pike

Edited by Pike_Bishop, 7 November 2019 - 20:20.

[mrvica]

small improvement cause code already in Picture Player (preinstalled in all E2 images)

--- key_actions_old.py	Wed Sep 02 18:44:32 2020
+++ key_actions_new.py	Sun Sep 06 11:12:52 2020
@@ -708,14 +708,17 @@
 			self.session.openWithCallback(self.onFileActionCB, UnzipMenuScreen, self.SOURCELIST, self.TARGETLIST)
 		elif filetype in IMAGE_EXTENSIONS:
 			if self.SOURCELIST.getSelectionIndex() != 0:
-				self.session.openWithCallback(
-					self.cbShowPicture,
-					ImageViewer,
-					self.SOURCELIST.getFileList(),
-					self.SOURCELIST.getSelectionIndex(),
-					self.SOURCELIST.getCurrentDirectory(),
-					filename
-				)
+				try:                                                                                                                                                                                          
+					from Plugins.Extensions.PicturePlayer import ui                                                                                                                                       
+						self.session.openWithCallback(
+						self.cbShowPicture,
+						ui.Pic_Full_View,
+						self.SOURCELIST.getFileList(),
+						self.SOURCELIST.getSelectionIndex(),
+						self.SOURCELIST.getCurrentDirectory())
+				except Exception, ex:                                                                                                                                                                         
+					print "[File Commander] Pictue Player not installed", str(ex)
+				return
 		elif filetype in (".sh", ".py", ".pyo"):
 			self.run_script(self.SOURCELIST, self.TARGETLIST)
 		elif filetype == ".mvi":
@@ -776,7 +779,12 @@
 			self.show()
 			if os.path.isfile(self.tmp_file):
 				filename = self.tmp_file.split('/')[-1]
-				self.session.open(ImageViewer, [((filename,''),'')],0, self.tmp_file.replace(filename,''), filename)
+				try:                                                                                                                                                                                          
+					from Plugins.Extensions.PicturePlayer import ui                                                                                                                                       
+					self.session.open(ui.Pic_Full_View, [((filename,''),'')],0, self.tmp_file.replace(filename,''), filename)
+				except Exception, ex:                                                                                                                                                                         
+					print "[File Commander] Pictue Player not installed", str(ex)                                                                                                                                                  
+				return	
 			else:
 				self.session.open(MessageBox, _("File not found: %s") %self.tmp_file, type=MessageBox.TYPE_ERROR, simple=True)
 		else:

I tested the first replacement of ImageViewer in def onFileAction, works ok, regarding second replacement in def saveCB, I don´t know how to test it, well it compiles ok, class ImageViewer in type_utils is no longer needed, can be removed, as well def keyYellow, it is now on Info key as part of Pic_Full_View

[mrvica]

while playing movie files with FileCommander you can´t exit with "exit", the messagebox pops up without any effect, you can only exit with "stop" without any confirmition, this diff resolves the problem

--- type_utils.py	Thu Jul 23 14:23:44 2020
+++ type_utils.py	Thu May 06 19:09:08 2021
@@ -46,17 +46,18 @@
 
 	def leavePlayer(self):
 		self.is_closing = True
-		self.close()
+		self.session.openWithCallback(self.leavePlayerConfirmed, MessageBox, _("Exit movie player?"))
 
 	def leavePlayerConfirmed(self, answer):
-		pass
+		if answer:
+			self.close()
 
 	def doEofInternal(self, playing):
 		if not self.execing:
 			return
 		if not playing:
 			return
-		self.leavePlayer()
+		self.close()
 
 	def showMovies(self):
 		self.WithoutStopClose = True

[mrvica]

I made it both py2/py3 compatible, it is not the latest code from here

e2openplugin-FileCommander/plugin at master · E2OpenPlugins/e2openplugin-FileCommander · GitHub

some (private) version between, not extensively tested on py3

 

 

Attached Files

•  FileCommander_py2_py3.zip   76.89KB   10 downloads

[mrvica]

I´ve updated the latest code from here to py3, the plugin is working fine except I get an error on watching inside archive and I don´t know how to fix it, any idea

e2openplugin-FileCommander/plugin at master · E2OpenPlugins/e2openplugin-FileCommander · GitHub

[ArchiverMenuScreen] unpackPopen ('unzip', '-l', '/tmp/wildcard.zip')
Traceback (most recent call last):
  File "/usr/lib/enigma2/python/Plugins/Extensions/FileCommander/addons/unarchiver.py", line 118, in ok
    self.unpackModus(self.selectId)
  File "/usr/lib/enigma2/python/Plugins/Extensions/FileCommander/addons/unzip.py", line 41, in unpackModus
    self.unpackPopen(cmd, UnpackInfoScreen)
  File "/usr/lib/enigma2/python/Plugins/Extensions/FileCommander/addons/unarchiver.py", line 147, in unpackPopen
    output = list(map(str.splitlines, p.communicate()))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: descriptor 'splitlines' for 'str' objects doesn't apply to a 'bytes' object 

adapting this to OpenPLi

enigma2/lib/python/Plugins/Extensions/FileCommander at 7.3 · openatv/enigma2 · GitHub

could be challenging

 

[Trial]

Hi,

Python3 is a lot more strict than Python2 especially when it comes to strings.. I think I remember that Python2 als accepted arrays of byte in string operation whereas Python3 does not. So a parameter must be changed from byte to string.

 

Ralf

[mrvica]

I couldn´t fix the error, I can´t remember the last time I viewed the content of an archive, it is not that important, should be fixed anyway before putting on git, I made small changes, if deleting files choose first No then Yes, avoids accidentally deleting of files and I got rid of InputBox replacing it with VirtualKeyboard, I hope successfully

 

Attached Files

•  FileCommander_git_py3.zip   196.43KB   7 downloads