Jump to content


Photo

Allowing skins to set the frontendInfo colors...


  • Please log in to reply
3 replies to this topic

#1 nautilus7

  • PLi® Contributor
  • 166 posts

+2
Neutral

Posted 10 November 2019 - 13:20

Hi, I am trying to adjust the python code, so skins will be able to set the frontendinfo colors, via a skin parameter. I can't seem to make it work though.

 

My changes are here: https://github.com/n...c4b9cdc58a664ce

 

The hex2str color conversion function is taken from here: https://github.com/O...tEpgInfo.py#L72

 

In my test code, I can't even get the the print calls to work. I get no output from these print functions (in debug level), as if they are not there... Any ideas?


Edited by nautilus7, 10 November 2019 - 13:21.


Re: Allowing skins to set the frontendInfo colors... #2 nautilus7

  • PLi® Contributor
  • 166 posts

+2
Neutral

Posted 21 November 2019 - 19:15

So, is there any enigma2 expert that can explain me why my code does not work?



Re: Allowing skins to set the frontendInfo colors... #3 littlesat

  • PLi® Core member
  • 50,566 posts

+560
Excellent

Posted 21 November 2019 - 20:31

Maybe consider to move the hex color converter somewhere on Tools...
The parsing and removal of attribs is weird. You only meed to remove the atteibs that are parsed and put in a self variabele.

Edited by littlesat, 21 November 2019 - 20:37.

WaveFrontier 28.2E | 23.5E | 19.2E | 16E | 13E | 10/9E | 7E | 5E | 1W | 4/5W | 15W


Re: Allowing skins to set the frontendInfo colors... #4 nautilus7

  • PLi® Contributor
  • 166 posts

+2
Neutral

Posted 23 November 2019 - 03:10

I found the problem. The parseColor was not needed because the colors are already parsed when reading them from the skin parameter.

 

I will send a PR tomorrow with your suggestions.






0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users