49 replies to this topic

[Qu@rk]

 

My first solution was a draft suggestion open for discussion (as we do now).
The appended text markers [EPG] and [Timer] if descriptions are different are not optimal and would have to be changed anyway.

At the moment of timer creation the EPG can be different from the actual EPG a view days later. Happens in Germany all the time.
The user would have all the information he needs.

It would be absolutely no problem to show only both short_descriptions if they were different.
In my opinion the new version is clearer, more logical for the user, to show the timer information and the actual EPG.
It also clearer for the user, because the user always sees that there is information coming from the timer and information coming from the actual EPG (not included in the timer).
The new layout supports the logic, also if the short descriptions are empty, which also happens very often in Germany.

In the former version, altered by Dimitrij, the position of "Conflict detection disabled!" is still wrong, as mentioned many times (and commented).

If you think the former version was better, no problem, just change the markers [Timer] and [EPG] to _("Timer:") and _("EPG:") and put them at the beginning of the descriptions (better Layout).

And change the position of the message "Conflict detection...".

I don't see the discussion. But after update totday I see change. Is that intended ?

 

Yes, that's intended.

[Qu@rk]

 

+

					elif short_description:
-						text = short_description
+						text = _("EPG:") + " " + short_description
+						cur.description = short_description
				if ext_description and ext_description != text:

Good idea.

[Qu@rk]

But could be confusing for the user.

The first time he checks the timer he sees "EPG: description...", the second time he sees the description without "EPG:".

But if he never checks the timer manually the description will never be updated and stays empty.

So a little bit inconsistent I think. But maybe no problem.

[Qu@rk]

					elif short_description:
						text = short_description
+						cur.description = short_description
				if ext_description and ext_description != text:

If you update the cur.description (timer description) anyway the EPG information is not needed.

[Qu@rk]

Pull Request:

Update empty timer description with EPG info

[WanWizard]

Thanks, merged.

[Qu@rk]

Thanks.

[Qu@rk]

OpenPLi/enigma2 update today. But the changes are still not released.

When will these changes become active/released?

Edited by Qu@rk, 28 January 2020 - 15:08.

[littlesat]

In 8.0 or 7.3... it should be in develop but there is no public develop release (you need to build for yourself).

 

In release we only do bugfixes and this is a kind of new feature...

Edited by littlesat, 28 January 2020 - 15:38.

[Qu@rk]

Thank you. It is in develop.

Oh my god. That could take months or even longer. That's ridiculous.

A very comfortable fix like this should be made available to users very much sooner.

 

In my opinion that's a bugfix.