35 replies to this topic

[serdeliuk]

Hello,

 

I am trying to build enigma2 from release-7.2 branch and i have observed that the bb recipe reference the develop version, i am doing something wrong or there it is a mistake in the bb recipe from release-7.2?

 

I am doing this

git clone https://github.com/O...pli-oe-core.git -b release-7.2

cd openpli-oe-core/

make

cat meta-openpli/recipes-openpli/enigma2/enigma2.bb | grep -B3 -i branch

 

PV = "2.7+git${SRCPV}"

PKGV = "2.7+git${GITPKGV}"

 

ENIGMA2_BRANCH ?= "develop"

 

 

Best regards,

 

 

Marc

Edited by serdeliuk, 14 May 2020 - 08:08.

[serdeliuk]

Same issue for enigma2-plugin-systemplugins-serviceapp.bb

   SRC_URI = "git://github.com/mx3L/serviceapp.git;branch=develop"

 

Ah, this is from other repo...

Edited by serdeliuk, 14 May 2020 - 08:39.

[serdeliuk]

It seems that is almost 3 years old and nobody seen this till now

https://github.com/O...gma2/enigma2.bb

[WTE]

Don't know what you mean. The 7.2 uses latest enigma2 rev

 

See here:

https://github.com/O...orefs.conf#L137

[serdeliuk]

Don't know what you mean. The 7.2 uses latest enigma2 rev

 

Well... i expect if i use OpenPli release-7.2 branch the enigma2 to be the same version, right now is develop version compiled instead of release-7.2

 

ENIGMA2_BRANCH ?= "develop"

GITHUB_URI ?= "git://github.com"

SRC_URI = "${GITHUB_URI}/OpenPLi/${BPN}.git;branch=${ENIGMA2_BRANCH}"

Edited by serdeliuk, 14 May 2020 - 09:51.

[WanWizard]

Not in our builds, as we have ENIGMA_BRANCH set correctly.

 

It might be a good thing to see what exactly a homebuild uses, when you use "MACHINE=xxxx make image". I assume nobody noticed because most home builders build a develop image.

[WTE]

 

Don't know what you mean. The 7.2 uses latest enigma2 rev

 

Well... i expect if i use OpenPli release-7.2 branch the enigma2 to be the same version, right now is develop version compiled instead of release-7.2

 

ENIGMA2_BRANCH ?= "develop"

GITHUB_URI ?= "git://github.com"

SRC_URI = "${GITHUB_URI}/OpenPLi/${BPN}.git;branch=${ENIGMA2_BRANCH}"

 

 

The image you build with release 7.2  will have develop branch

https://github.com/O...enigma2.bb#L111

 

I notice before that internal build from original image is using the release7.2 branch. This is however uptodate as well.

Edited by WTE, 14 May 2020 - 09:55.

[WTE]

Not in our builds, as we have ENIGMA_BRANCH set correctly.

 

It might be a good thing to see what exactly a homebuild uses, when you use "MACHINE=xxxx make image". I assume nobody noticed because most home builders build a develop image.

ok I assume you have an local.conf added were you set. Homebuilder mostly want newest stuff in image so for me develop branch

 

ENIGMA2_BRANCH=release-7.2

[WanWizard]

Something more complex, but that is what it boils down to, yes.

 

ok I assume you have an local.conf added were you set. Homebuilder mostly want newest stuff in image so for me develop branch

 

I assume most homebuilders do, but then you will also use the develop branch of our OE, so that is not a problem.

 

It is not advisable to use a develop enigma with a release build, as all sorts of dependencies (for example plugins or webif) might fail. So this needs looking in to.

[serdeliuk]

Not in our builds, as we have ENIGMA_BRANCH set correctly.

 

It might be a good thing to see what exactly a homebuild uses, when you use "MACHINE=xxxx make image". I assume nobody noticed because most home builders build a develop image.

 

I have in my localconf MACHINE=vusolo4k and i use the release-7.2 branch but the enigma was built from develop branch, however the ENIGMA2_BRANCH variable set in enigma2.bb override any other preset, if any.

I have observed this because the enigma2 from develop branch it seems to have issues with timezones at least under release-7.2 tree, but this is another story.

Edited by serdeliuk, 14 May 2020 - 10:12.

[WanWizard]

Ok. So we need to do something about this, I'll have a look.

 

The timezone thing is a typical example of a dependency problem, as handling timezones has changed in develop, but it requires a new tzdata setup which the release OE doesn't have.

[serdeliuk]

In my local.conf i set both MACHINE and BRANCH in case it helps

 

MACHINE = "vusolo4k"

BRANCH = "release-7.2"

[WanWizard]

For the moment, you might want to set ENIGMA2_BRANCH too, to address your issue.

[serdeliuk]

I have replaced ENIGMA2_BRANCH value in enigma2.bb file to solve the issue, i think if i add ENIGMA2_BRANCH in local.conf will be overridden by the value from enigma2.bb

[WanWizard]

No, the =? means "use this if no value is already set".

 

That is why it is there, to make sure there is a default value. I can only assume it is supposed to be updated on release, but whoever came up with it forgot to document it...

 

edit: I've added a note about this to the wiki.

[serdeliuk]

Thanks

[serdeliuk]

edit: I've added a note about this to the wiki.

 

Does it counts if the branch name is "release-7.2" not "7.2-release"?

[WanWizard]

Hmm, did I make a typo?

 

edit: yes, I did, fixed it, thanks.

Edited by WanWizard, 14 May 2020 - 11:29.

[Erik Slagter]

Please report whether this approach works 

[serdeliuk]

I tested, but i am stuck in missing download dependencies, too many lately, nobody test them? Or homebuilds are not so important

However, at some point i added BRANCH variable to local.conf, i can't recall why, probably there should be added this too in cli make image parameters, or ENIGMA2_BRANCH should be modified into BRANCH alone to satisfy all, i will came back with more details after i collect all issues and dig into my memories to see when and why i used BRACH in local.conf

Edited by serdeliuk, 15 May 2020 - 09:25.