27 replies to this topic

[countpierre]

I have building OpenPLi images for many years, but have recently hit a problem.

 

I rebuilt the build environment on my build machine which runs Debian "stretch".

 

I am now getting a compile error when the build gets to enigma2-plugin-systemplugins-servicemp3.

 

The error:

"

../../git/servicemp3/servicemp3.cpp:151:27: error: invalid new-expression of abstract class type 'eServiceMP3'
  ptr = new eServiceMP3(ref);
                                            ^

"

The enigma2 compile and everything to this point works fine.

 

help please.

[countpierre]

Branch release-7.3

[WanWizard]

eServiceMP3 is an external package, we're waiting for the maintainer to fix it.

[countpierre]

Is there anything I can do until it is fixed?

[WanWizard]

Create a bbappend in your meta-local for it, and add a patch in it:

FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
SRC_URI = "git://github.com/mx3L/serviceapp.git;branch=develop file://0001-workaround-missing-servicetap.patch"

The patch:

[build@buildserver3] $ cat 0001-workaround-missing-servicetap.patch 
diff --git a/configure.ac b/configure.ac
index 48e3a11..463bfd6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -57,6 +57,7 @@ AC_LINK_IFELSE(
     SWIG_VOID(RESULT) subServices(ePtr<iSubserviceList> &SWIG_OUTPUT){};
     SWIG_VOID(RESULT) frontendInfo(ePtr<iFrontendInformation> &SWIG_OUTPUT){};
     SWIG_VOID(RESULT) timeshift(ePtr<iTimeshiftService> &SWIG_OUTPUT){};
+    SWIG_VOID(RESULT) tap(ePtr<iTapService> &ptr) { ptr = nullptr; return -1; };
     SWIG_VOID(RESULT) cueSheet(ePtr<iCueSheet> &SWIG_OUTPUT){};
     SWIG_VOID(RESULT) subtitle(ePtr<iSubtitleOutput> &SWIG_OUTPUT){};
     SWIG_VOID(RESULT) audioDelay(ePtr<iAudioDelay> &SWIG_OUTPUT){};
diff --git a/src/serviceapp/serviceapp.h b/src/serviceapp/serviceapp.h
index 7bb0cc6..3fe9986 100644
--- a/src/serviceapp/serviceapp.h
+++ b/src/serviceapp/serviceapp.h
@@ -124,6 +124,7 @@ public:
 	RESULT subServices(ePtr<iSubserviceList> &ptr){ ptr=this; return 0;};
 	RESULT frontendInfo(ePtr<iFrontendInformation> &ptr){ ptr=0; return -1;};
 	RESULT timeshift(ePtr<iTimeshiftService> &ptr){ ptr=0; return -1;};
+	RESULT tap(ePtr<iTapService> &ptr) { ptr = nullptr; return -1; };
 	RESULT cueSheet(ePtr<iCueSheet> &ptr){ ptr=0; return -1;};
 	RESULT subtitle(ePtr<iSubtitleOutput> &ptr){ ptr=this; return 0;};
 	RESULT audioDelay(ePtr<iAudioDelay> &ptr){ ptr=0; return -1;};

[countpierre]

not added .bbappend of these before.

I created a file "enigma2-plugin-systemplugins-servicemp3.bbappend" in the meta-local directory with the following contents,

 

FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
SRC_URI = "git://github.com/mx3L/serviceapp.git;branch=develop file://0001-workaround-missing-servicetap.patch"

 

I then cleaned the bitbake recipe with -ccleanall option and ran it again.

 

Still getting the error in the compile.

 

What am I doing wrong?

[WanWizard]

Created in the wrong place?

 

The default layer.conf defines:

# We have a recipes directory, add to BBFILES
BBFILES += "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend"

so you need to use (for clarity) the same path as in meta-openpli, ./meta-local/recipes-openpli/enigma2/enigma2-plugin-systemplugins-servicemp3.bbappend.

 

[betacentauri]

@WanWizard: User speaks about servicemp3. And you about serviceapp. At least the SRC_URI says that. These are afaik 2 different things.

Mhm, doesn’t dreamboxes use different servicemp3 implementation?

[betacentauri]

Ah, no it was the dvbmediasink in the past

[countpierre]

Created in the wrong place?

 

The default layer.conf defines:

# We have a recipes directory, add to BBFILES
BBFILES += "${LAYERDIR}/recipes-*/*/*.bb ${LAYERDIR}/recipes-*/*/*.bbappend"

so you need to use (for clarity) the same path as in meta-openpli, ./meta-local/recipes-openpli/enigma2/enigma2-plugin-systemplugins-servicemp3.bbappend.

 

Thank you. But see below.

 

@WanWizard: User speaks about servicemp3. And you about serviceapp. At least the SRC_URI says that. These are afaik 2 different things.

Mhm, doesn’t dreamboxes use different servicemp3 implementation?

 

Yes, it is servicemp3. 

[betacentauri]

Did you do a “make update” before starting the build? Are there changes in the build environment so that “make update” complaints?

[WanWizard]

Oops, sorry.

[countpierre]

Did you do a “make update” before starting the build? Are there changes in the build environment so that “make update” complaints?

 

No. make update works fine.

 

serviceapp caused a problem as well but solved with bbappend. Thanks @WanWizard

 

for servicemp3:

I hacked the work directory and added

" RESULT tap(ePtr<iTapService> &ptr) { ptr = nullptr; return -1; };"

to servicemp3.h

 

It now compiles. Is there a way to do this with bbappend?

 

The build is now continuing.

Edited by countpierre, 9 August 2020 - 12:42.

[WanWizard]

Which servicemp3.h is that? If the DM8000 uses a different version, it needs to be fixed in our repo.

[betacentauri]

I think there is only one. But not 100% sure. Maybe wrong SRC_REV in the reporefs file? Can’t check at the moment.

[countpierre]

Which servicemp3.h is that? If the DM8000 uses a different version, it needs to be fixed in our repo.

 

It was located in "./build/tmp/work/dm8000-oe-linux/enigma2-plugin-systemplugins-servicemp3/gitAUTOINC+c7750c5ab3-r0/git/servicemp3$"

 

As I said, a bit of a hack!

Edited by countpierre, 9 August 2020 - 13:03.

[WanWizard]

That looks like the standard one, and I wouldn't know why that doesn't build. Just to be sure, we're talking about the develop branch, right?

[countpierre]

That looks like the standard one, and I wouldn't know why that doesn't build. Just to be sure, we're talking about the develop branch, right?

 

No. release-7.3

[WanWizard]

Ah, that explains.

 

Looks like stuff is getting mixed up somehow, as servicemp3 has been changed in develop due to the phase-out work of streamproxy.

 

Both servicemp3 and serviceapp are pinned on commit hash in the release branch, exactly to avoid these issues.

 

You're building c7750c5ab3, which is the correct version for servicemp3, from before the develop changes. So what is triggering your issue, trying to build a develop Enigma in a release OE?

[countpierre]

Ah, that explains.

 

Looks like stuff is getting mixed up somehow, as servicemp3 has been changed in develop due to the phase-out work of streamproxy.

 

Both servicemp3 and serviceapp are pinned on commit hash in the release branch, exactly to avoid these issues.

 

You're building c7750c5ab3, which is the correct version for servicemp3, from before the develop changes. So what is triggering your issue, trying to build a develop Enigma in a release OE?

 

 

when I build a new environment I always start by doing "MACHINE=dm8000 make image".

 

This checks that everything is good.

 

This is where it fails.

Edited by countpierre, 9 August 2020 - 13:40.