8 replies to this topic

[Persian Prince]

Hello

 

There are some new changes regarding setup/menu which you could see on ViX's git: https://github.com/O...ma2/commits/Dev

 

I was talking to Ian via email for cherry-picking the new changes into Open Vision's git but if PLi accept the changes we could apply them upstream (PLi) then merge would benefit Open Vision as well.

 

According to Ian:

 

The Setup.py changes are part of a bigger set of changes.  There are changes to Setup.py, ConfigList.py, config.py, setup.xml, keymap.xml and SETUP.

 

So is this acceptable by PLi?

 

Regards,

Persian Prince

Edited by Persian Prince, 22 September 2020 - 13:22.

[WanWizard]

Improvements are always good, but I (personally) lack the knowledge to comment on it.

[littlesat]

When you mean the changes to config.py... they look indeed good but I have a lack of time

[IanSav]

Hi,

 

Sorry for the delay in responding as I have been refining and improving the new code in response to widespread testing and usage on OpenViX.

 

I am happy to commit the code and hopefully Persian Prince can assist me in the process.  My main concern is that this is a significant change and effort that I don't want to start if I am faced with objections and resistance along the way.

 

Would you like me to implement this new code onto OpenPLi?

 

Regards,

Ian.

Edited by IanSav, 4 October 2020 - 03:39.

[Dimitrij]

 

Would you like me to implement this new code onto OpenPLi?

Why not?
I'm ready to test.

[littlesat]

Thanks Dimi...

[foxbob]

And I would like to try.

[Persian Prince]

I think if we have a new branch for the new changes it would be better so would you (PLi team) please create a new branch (setup branch for example)?

 

At last you could merge it into develop

Edited by Persian Prince, 4 October 2020 - 12:57.

[IanSav]

Hi,

 

I have already started preparing code and data for OpenPLi.

 

Regards,

Ian.