80 replies to this topic

[littlesat]

Why not add something in the epg zml file in which (main) language it is and only import that file when that language is within the preferred languages? Then no complicated stuff is required at all....

[doglover]

 only import that file when that language is within the preferred languages? Then no complicated stuff is required at all....

OK.  Why don't you program it......

 

The language code in XMLTV:

  <programme start="20210409083500 +0000" stop="20210409091500 +0000" channel="Play7.be">
    <title lang="nl">Dr. Phil</title>
    <sub-title lang="nl">[Praatprogramma]. Aflevering 18005 (S18E18005) (2020)</sub-title>
    <desc lang="nl">Dr. Phil is een Amerikaans praatprogramma . Het programma wordt gepresenteerd door voormalig psycholoog Phillip Calvin McGraw, oftewel Dr Phil. In zijn praatprogramma geeft hij gasten advies over hun problemen of levensstijl. Dankzij zijn jarenlange ervaring als psycholoog heeft Dr Phil voor bijna alle relationele problemen een passend advies en oplossingen.n.</desc>
  </programme>

  <programme start="20210411083500 +0000" stop="20210411111000 +0000" channel="ElevenSports2F.be">
    <title lang="fr">Boston Celtics - Philadelphia 76ers</title>
    <desc lang="fr">Diffusion d'un match de la NBA (National Basketball Association), la prestigieuse ligue américaine de basket-ball. C'est une ligue fermée comportant des équipes de basket-ball des Etats-Unis et du Canada. La première saison de cette ligue a été jouée en 1946.</desc>
  </programme>

  <programme start="20210409090000 +0000" stop="20210409103000 +0000" channel="BoxHits.uk">
    <title lang="en">Women On Top! Most Streamed</title>
    <sub-title lang="en">(E0)</sub-title>
    <desc lang="en">The Spotify Gods have spoken and it's official... these women are at the very top of their game! Join Abbie McCarthy as she counts down the 20 most streamed ladies in pop.</desc>
  </programme>

These codes are as defined in the language code definition. And for instance used by MKVtoolnix the define language setting.
see: http://msdn.microsof...o(v=VS.95).aspx

 

But it si not as straightforward as you assume.

Let's assume that en is not in your preferred language.  Then you will skip almost all music and news channels, because for these channels only English EPG is to be found.

And occasionally I have to grab a schedule from a Polish website (the schedule is in English).  The schedule will be denoted as pl (Polish)

Edited by doglover, 9 April 2021 - 10:00.

[Pr2]

Using language defined in the GUI won't probably solved the question here since you can decide to receive both french and english language so both will be loaded into memory and then which one will be displayed?

Does GMEPG take care of the language code, how does it handle the EPG when there are several languages available for the same service reference?

If it handles it properly no need for filtering in EPGImport just load all the possible languages for a multi-lingual channel using the same reference (but this will fill up the STB memory).

 

But then you should extend the number of preferred languages because 2 is very restrictive.

 

People doesn't have to learn regular expression they can just type the "channel id" name like it appears in the channels.xml but I propose my implementation. This PR is allowing users to have a full control on what is loaded into STB memory.

 

So sad that I ask for help in the development section of OpenPLi where I explain what I was doing and nobody answer me, now that the patch is ready and fully tested you reject it. I would have better invest my time in doing something else.

[doglover]

Congratulations for killing this useful modification.

Yes, I will not be needed by many users, but this is not a reason for not including it.

 

Am i overstepping my credit, when I say I am disappointed.

 

Thanks to Pr2 for trying to make something out of it.

Edited by doglover, 9 April 2021 - 11:01.

[littlesat]

We’re not killing it... we’re trying to get a good lean solution.... before creating a solution. It is a huge issue in the enigma2 community that a lot are creating solutions and finish it before discuss it how to implement it the best and most lean way.

[Pr2]

Come on I start a thread in the develop section about this and nobody react nor help me with my questions.
The solution I propose fulfill the Doglover requirement and is very flexible.
Once it is done you reject it.

Nobody is touching at EPGImport all the major latest improvement are mine.

Si now who will implement it the way you think it should be done?

Edited by Pr2, 9 April 2021 - 13:19.

[littlesat]

Why didn't you tell you plans in that thread where nobody respond so we could allign in forehand... then you can expect some respond earlier and also have discussions and help...

I think the start "wanwizard" suggested might lead to a better approach... Note a normal user will never be able to create such config file!!! At the end it is not required at all as there are already configs for prefered epg language...

And note in the past I also did coding that was not accepted or shooted by other 'devs'... that is part of joining and contributing to an open source community...

In addition for me at this time due to extreme complicated situation at home and my health I'm not able to code anything. I was also a long time hospitalized so I was not able to respnd

Edited by littlesat, 9 April 2021 - 13:42.

[doglover]

Oh yes in the development section.  Where I do not have access.

So you can discuss it at length, not knowing the problem, nor overseeing all the problems you can create with insisting on the language selection.

Come up with something, which does not even solve the problem.

And then saying, this is it .  We are not doing anything more.

 

Sorry, if I am sarcastic.

[littlesat]

I suggest we should give doglover access!!!

[littlesat]

And why is the topic on GitHub closed instead trying and discuss to get it good? At these days it seems nobody can accept arguments anymore?
What wanwizard says indeed it would be helpfully to change the language strings in the xmls to dvb format.... then the ‘standard’ filters can be used....
Note in e2 the third prefered epg language is fixed English as default.... then you have other two definable languages... low and highest prio...

Edited by littlesat, 9 April 2021 - 13:49.

[Pr2]

I close it because the way you want to go is not where I currently implement a working solution it should.be done elsewhere in the code. So I understand that you don't accept the solution requested by Doglover. GitHub is not a chat room.

And by the way you are the first one to not accept other suggestions I am always opened to discussion but then reply on the thread that I create to discuss it before I waste my time.

Edited by Pr2, 9 April 2021 - 13:58.

[doglover]

What wanwizard says indeed it would be helpfully to change the language strings in the xmls to dvb format.

 

 

Oh, yes and do you know what is involved there.

The program for grabbing is following the microsoft rules:  http://msdn.microsof...o(v=VS.95).aspx

 

But knowing your aversion for microsoft, it is probably not good.

And BTW, MKVToolnix also is following these rules.

[WanWizard]

OK.  Why don't you program it......

 

That was the entire point of my remark.

 

It is being programmed at the moment, but instead of utilizing the already existing "lang" attribute in the XML the already existing epgcache functionality to support multiple languages, and the already existing language preference in the GUI, it is now using a regex on an arbitary string in CDATA comments of the channel defintion.

 

The best way to avoid code not being accepted is to discuss the functional requirements and possible solutions first, instead of coding first, and then discuss them later...

[doglover]

Clearly NIH

[doglover]

With your language selection you have only 2 choices plus the default English.

 

I for instance will have a problem:

 

I want nl, fr and de beside en.

Which one do I drop?  Because if I do not define de, no German channel will have EPG.

I think more people have the same problem.

 

Also, and this is for testing only, I need to import all kind of languages.  Do I reset each time the lang atributes of EPG system?

[doglover]

 

OK.  Why don't you program it......

 

That was the entire point of my remark.

 

It is being programmed at the moment, but instead of utilizing the already existing "lang" attribute in the XML the already existing epgcache functionality to support multiple languages, and the already existing language preference in the GUI, it is now using a regex on an arbitary string in CDATA comments of the channel defintion.

 

The best way to avoid code not being accepted is to discuss the functional requirements and possible solutions first, instead of coding first, and then discuss them later...

 

 

Are you not doing exactly what you say you should not do.  First write code and discuss later....

Edited by doglover, 9 April 2021 - 15:26.

[littlesat]

I want nl, fr and de beside en.
Which one do I drop? Because if I do not define de, no German channel will have EPG.

Why do you need 3 languages.... ?
The two languages are preferred languages.... so when you prefer French and Dutch for example and in an EPG source only German availabe it can and will still show it...
Another solution of course and that is more work add prefered languages for epg in e2....

Edited by littlesat, 9 April 2021 - 15:31.

[doglover]

Why do you need 3 languages.... ?

 

 

I want dutch and Flemish channels (so nl)

In Belgium there are also French speaking channels  (Walloon)

And I want the national channels from Germany and the UK.

 

But yes, British speak all languages as long as it is English.  (also Germans speak and understand fluent all languages as long as it is German)

 

Of course if you show it:

 

First choice

 

if that is not available then:

 

Second choice.

 

If that is not available then:

 

Any EPG which is available.  (or provide a way to order them)

 

That would work

Edited by doglover, 9 April 2021 - 15:42.

[littlesat]

You still can set as it is now Dutch and French as default languages.... and all should work.... when you have a channel with only German language as epg availabe it will be shown...

[Pr2]

@wanwizard the filter was not applied to a comment but to a valid XML tag called "channel id". If is not a regex applied to the full line but only to the field it must be applied.

@littlesat,

Feel free to adapt EPGimport, I am wondering if E2 support so well multilingual in the EPG why it was then not yet implemented properly in EPGImport.