59 replies to this topic

[Taapat]

1. Check resolveFilename logic.

Any image in the active skin/icons folder has priority over skin_default/icons folder in enigma2.

 

2. Introducing images in python code you can't specify their sizes in the skin if you want different.

You need in skin put your images with another size.

Maybe I missed something, but in this case I don't see a problem using MultiPixmap change images pointing them in the skin.

[DimitarCC]

1. You are right. Then is not a problem to put them also in data/skin_default/icons.

2. The problem with sizes is easily fixable by using svg instead of png. Svgs can fit to any sizes defined in skin. Multipixmap is also an options indeed.

[Taapat]

Using LoadPixmap in python code, the only way to specify a size is to introduce a new global parameter in the skin instead of simply specifying the size in the skin widget.

Therefore, I'm sure it would be better to use pixmap or pixmaps in a skin widget rather than a hard coded image load in a python.

[DimitarCC]

You are right about LoadPixmap... However not matter what is the original svg size it should be scaled to the size specified in the skin. That is the advantage of vector graphics. I am not really sure how it works in Openpli 8 since i am using various images and i am not really test this on all of them. But i tested in some of them and scaling of svg works just fine.
Isnt it svg scaled by OpenPLi to the size specified in the skin?

[Taapat]

Interesting on which image you test how does svg work?

As far I know svg image support before OpelPli was only on dreambox.

 

I feel like you're missing how svg image scaling works here.

Are you sure that the svg image is rendered without loss of quality at the resolution specified in the skin?

Or is it rendered in svg viewBox size and after scaled?

Edited by Taapat, 5 May 2021 - 20:59.

[DimitarCC]

Well to be honest my main testing and working with svgs is on DreamOS. On the other images i tested this is not exactly stock images but custom modified one. But on dreamos i dont see any quality loss. At least when it is scaled down. I am not really sure what is under the hood in DreamOS, but i think scaling is better when downscale. I dont see any blur or pixelization when scaling so i suppose it is not scaled after it were already rendered at original size 

Generally i use simple menu icons and not too complicated svgs with complex graphics inside but mainly i use larger original size so to have only scale down.

 

Well but it could be something in Dreambox drivers that work with graphics in different way 

Edited by DimitarCC, 5 May 2021 - 21:31.

[MCelliotG]

OpenATV's approach gives a lot of options already, so I'm still concerned if this new coding will affect all skins that work with OpenPLI. Is new skinning required, now that PVRstate.py is obsolete?

[DimitarCC]

It require just add some stuff to the skin. But even if you not add anything the skin will work just will not show pvr states.
Keep in mind this is a proposal still and i am not sure wil it be accepted or not.

[MCelliotG]

That's the issue for skinners though! It will break backwards compatibility this way! I believe any new features which are nice should be introduced as new stuff that can be added optionally without breaking the existing coding in skins! For instance the current coding should be retained as it is and if a skinner wants to add the new stuff it should be a choice!

[littlesat]

I hate that the code depends on the skins and visa versa.... which means indeed when you try op optimize the code that you also need to adapt the skins.... in short this means for the backwards compatibility you only can consider to add the new widget(s) for the graphic icons to the pvrstate instantiate screen..... As some skinners are not willing to adapt or even the creaters became inactive it can indeed be considered to keep the pvrstate.py (unless I personally hate it).

In short it is not easy to make such changes/improvements.

Edited by littlesat, 6 May 2021 - 20:43.

[DimitarCC]

OK...i will make a new merge request that will modify pvrstate screen only and add graphics there. But still i think will be better to keep the images hardcoded....i will think how to use Multipixmap though

[littlesat]

Sorry that this topic is going around in circles.... thanks for your patience and help!!!!!!!

[Taapat]

But still i think will be better to keep the images hardcoded....

 

No, please leave skin elements in skin.

Let the skinner himself choose what and how to use.

Just give them a widget.

[DimitarCC]

Well i did the changes. Check the pull request.

Now the skinners have to add 2 new widgets in PVRState screen or TimeshiftState screen so to be able to display icons for the states. Also the state icons are defined in a MultiPixmap and have to be added in specified order.

Since i kept the PVRState screen if skinner want to show the icons or texts in the Infobar they will have to position and overlay the PVRState screen over the infobar. That is the only option if we want to keep backward compatibility.

[DimitarCC]

P.S. the new widgets for example are:

<widget name="statespeed" foregroundColor="white" halign="left" position="260,960" size="90,45" font="Bold; 40" transparent="1"/> 
<widget name="stateicon"  position="260,960" size="90,45" alphatest="blend" pixmaps="icons/pvr/ff.svg,icons/pvr/rew.svg,icons/pvr/play.svg,icons/pvr/pause.svg"/> 

[Taapat]

My personal thoughts are if you leave the PVRState screen does not mean that you cannot also introduce widgets in the infobar.

If you don't like the PVRState screen you can make it transparent and use widgets in the infobar.

I assume in your skin you can also place the PVRState screen above the infobar, but that would be a bit of a hack solution.

Edited by Taapat, 7 May 2021 - 08:53.

[DimitarCC]

Yup i added the widgets in infobar as well. So as you said if someone doesnt like PVRState screen he can make it transparent with no content and use infobar widget instead.

[MCelliotG]

On OpenATV PVRstate is absolutely customizable with these widgets
statusicon
speed
 
so I see a similar approach. The thing is that PVRstate can either be configured to be seen outside the movie infobar, or inside the movie infobar. I'm not sure if this option is also available on OpenPLI, I only see it inside the infobar. That would be really nice if it could be implemented.
 
An example in my skin
 pvrstate external.jpg   97.95KB   8 downloads

[Taapat]

@DimitarCC Do you test what you offer in PR?

I see that you have added a new folder with pictures but you not added any makefile for them.

If you are not testing then maybe add the images to the existing icons folder and add these files in the icons folder Makefile.am.

[DimitarCC]

@Taapat Well i dont test the build procedure...No. Since i test the code on my box where everything is compiled or recompiled on the fly. I will add it in existing icons folder then.

 

P.S. Done. I hope is fine now.