Jump to content


Photo

IMDB plugin issues

imdb plugin imdb plugin

  • Please log in to reply
9 replies to this topic

#1 scriptmelvin

  • New Member
  • 2 posts

0
Neutral

Posted 1 June 2021 - 01:54

Hi all,

 

I'm running OpenPLi for a week now (on a VU+ Uno 4K SE), overall very content. Very well put together, few bugs.

 

The IMDB plugin has several issues:

  • Use of if re.Match.group('xxx') raises IndexError: no such group when no match.
  • Use of re.Match.group(0) when group(1) is intended.
  • Not able to parse the "new" (black, "mobile friendly") IMDB pages.

I fixed these on my receiver, would you be interested in my contribution? If so, how? diff posted here? ipk posted here? Fork & PR on github?



Re: IMDB plugin issues #2 WanWizard

  • PLi® Core member
  • 58,723 posts

+1,286
Excellent

Posted 1 June 2021 - 02:25

Yes, please, very much so! :)

 

Preferrably via a PR on github, it makes it easy for us to review and merge, and it makes sure you're attributed for your work.


Currently in use: VU+Duo 4K (2xFBC S2), Amiko Viper T2C (T2+fallback), Octagon SF8008 (S2+T2), Zgemma H9.2H (T2+fallback)

Many answers to your question can be found in our new and improved wiki.

Because to health reasons, I will not be active online very often anymore.


Re: IMDB plugin issues #3 Pr2

  • PLi® Contributor
  • 4,793 posts

+198
Excellent

Posted 1 June 2021 - 12:32

You should give a try to TMBD plugin this one properly maintained.


NO SUPPORT by PM, it is a forum make your question public so everybody can benefit from the question/answer.
If you think that my answer helps you, you can press the up arrow in bottom right of the answer.

Wanna help with OpenPLi Translation? Please read our Wiki Information for translators

Sat: Hotbird 13.0E, Astra 19.2E, Eutelsat5A 5.0W
VU+ Solo 4K: 2*DVB-S2 + 2*DVB-C/T/T2 (used in DVB-C) & Duo 4K: 2*DVB-S2X + DVB-C (FBC)
Edision OS Mio 4K: 1*DVB-S2X + 1*DVB-C/T/T2
 


Re: IMDB plugin issues #4 scriptmelvin

  • New Member
  • 2 posts

0
Neutral

Posted 1 June 2021 - 23:26

PR created: #662 (can't link to it apparently).

  • Parsing speed of the new pages is slower, the new "mobile friendly" pages are 3 times the size of the old pages (go figure).
  • IMDb randomly serves either the new page or the old page, with slightly different content. You can tell whether the new page was served by the presence of a period after the status text IMDb Details parsed

Thanks for the tip @Pr2, I'll try it out.



Re: IMDB plugin issues #5 WanWizard

  • PLi® Core member
  • 58,723 posts

+1,286
Excellent

Posted 1 June 2021 - 23:38

Merged.


Currently in use: VU+Duo 4K (2xFBC S2), Amiko Viper T2C (T2+fallback), Octagon SF8008 (S2+T2), Zgemma H9.2H (T2+fallback)

Many answers to your question can be found in our new and improved wiki.

Because to health reasons, I will not be active online very often anymore.


Re: IMDB plugin issues #6 Huevos

  • PLi® Contributor
  • 3,279 posts

+131
Excellent

Posted 2 June 2021 - 07:56

Where is that located.



Re: IMDB plugin issues #7 blzr

  • PLi® Core member
  • 2,203 posts

+113
Excellent

Posted 2 June 2021 - 10:33

https://github.com/O...2b3862feb4109b1


True sarcasm doesn't need green font...

Re: IMDB plugin issues #8 zigzag

  • Senior Member
  • 169 posts

0
Neutral

Posted 19 July 2021 - 18:22

Can i ask if there is any known fix for this plugin please?

For some time now, every request for details from the IMDb plugin result in No details found after the matching entries list.

It has been a helpful plugin and would be nice to get it working again before uninstalling it. TMDB is similar but the great feature

of the IMDb plugin is it includes more features such as the reviews which is a great benefit.



Re: IMDB plugin issues #9 WanWizard

  • PLi® Core member
  • 58,723 posts

+1,286
Excellent

Posted 19 July 2021 - 18:36

Has been fixed in the develop image, with will be part of 8.1-release.


Currently in use: VU+Duo 4K (2xFBC S2), Amiko Viper T2C (T2+fallback), Octagon SF8008 (S2+T2), Zgemma H9.2H (T2+fallback)

Many answers to your question can be found in our new and improved wiki.

Because to health reasons, I will not be active online very often anymore.


Re: IMDB plugin issues #10 zigzag

  • Senior Member
  • 169 posts

0
Neutral

Posted Yesterday, 14:40

Thank you WanWizard for your reply.

We will wait until your 8.1 is released and flash it to be able to use it again.

Thanks again.





0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users