Jump to content


Photo

IMDB plugin issues

imdb plugin imdb plugin

  • Please log in to reply
28 replies to this topic

#1 scriptmelvin

  • Member
  • 24 posts

+1
Neutral

Posted 1 June 2021 - 01:54

Hi all,

 

I'm running OpenPLi for a week now (on a VU+ Uno 4K SE), overall very content. Very well put together, few bugs.

 

The IMDB plugin has several issues:

  • Use of if re.Match.group('xxx') raises IndexError: no such group when no match.
  • Use of re.Match.group(0) when group(1) is intended.
  • Not able to parse the "new" (black, "mobile friendly") IMDB pages.

I fixed these on my receiver, would you be interested in my contribution? If so, how? diff posted here? ipk posted here? Fork & PR on github?


Vu+ Uno 4K SE


Re: IMDB plugin issues #2 WanWizard

  • PLi® Core member
  • 60,096 posts

+1,369
Excellent

Posted 1 June 2021 - 02:25

Yes, please, very much so! :)

 

Preferrably via a PR on github, it makes it easy for us to review and merge, and it makes sure you're attributed for your work.


Currently in use: VU+Duo 4K (2xFBC S2), Amiko Viper T2C (T2+fallback), Octagon SF8008 (S2+T2), Zgemma H9.2H (T2+fallback)

Due to health reasons, I will have periods of inactivity, during which I don't respond to posts or PM.

Many answers to your question can be found in our new and improved wiki.


Re: IMDB plugin issues #3 Pr2

  • PLi® Contributor
  • 5,133 posts

+209
Excellent

Posted 1 June 2021 - 12:32

You should give a try to TMBD plugin this one properly maintained.


NO SUPPORT by PM, it is a forum make your question public so everybody can benefit from the question/answer.
If you think that my answer helps you, you can press the up arrow in bottom right of the answer.

Wanna help with OpenPLi Translation? Please read our Wiki Information for translators

Sat: Hotbird 13.0E, Astra 19.2E, Eutelsat5A 5.0W
VU+ Solo 4K: 2*DVB-S2 + 2*DVB-C/T/T2 (used in DVB-C) & Duo 4K: 2*DVB-S2X + DVB-C (FBC)
Edision OS Mio 4K: 1*DVB-S2X + 1*DVB-C/T/T2
 


Re: IMDB plugin issues #4 scriptmelvin

  • Member
  • 24 posts

+1
Neutral

Posted 1 June 2021 - 23:26

PR created: #662 (can't link to it apparently).

  • Parsing speed of the new pages is slower, the new "mobile friendly" pages are 3 times the size of the old pages (go figure).
  • IMDb randomly serves either the new page or the old page, with slightly different content. You can tell whether the new page was served by the presence of a period after the status text IMDb Details parsed

Thanks for the tip @Pr2, I'll try it out.


Vu+ Uno 4K SE


Re: IMDB plugin issues #5 WanWizard

  • PLi® Core member
  • 60,096 posts

+1,369
Excellent

Posted 1 June 2021 - 23:38

Merged.


Currently in use: VU+Duo 4K (2xFBC S2), Amiko Viper T2C (T2+fallback), Octagon SF8008 (S2+T2), Zgemma H9.2H (T2+fallback)

Due to health reasons, I will have periods of inactivity, during which I don't respond to posts or PM.

Many answers to your question can be found in our new and improved wiki.


Re: IMDB plugin issues #6 Huevos

  • PLi® Contributor
  • 3,340 posts

+132
Excellent

Posted 2 June 2021 - 07:56

Where is that located.



Re: IMDB plugin issues #7 blzr

  • PLi® Core member
  • 2,211 posts

+113
Excellent

Posted 2 June 2021 - 10:33

https://github.com/O...2b3862feb4109b1


True sarcasm doesn't need green font...

Re: IMDB plugin issues #8 zigzag

  • Senior Member
  • 169 posts

0
Neutral

Posted 19 July 2021 - 18:22

Can i ask if there is any known fix for this plugin please?

For some time now, every request for details from the IMDb plugin result in No details found after the matching entries list.

It has been a helpful plugin and would be nice to get it working again before uninstalling it. TMDB is similar but the great feature

of the IMDb plugin is it includes more features such as the reviews which is a great benefit.



Re: IMDB plugin issues #9 WanWizard

  • PLi® Core member
  • 60,096 posts

+1,369
Excellent

Posted 19 July 2021 - 18:36

Has been fixed in the develop image, with will be part of 8.1-release.


Currently in use: VU+Duo 4K (2xFBC S2), Amiko Viper T2C (T2+fallback), Octagon SF8008 (S2+T2), Zgemma H9.2H (T2+fallback)

Due to health reasons, I will have periods of inactivity, during which I don't respond to posts or PM.

Many answers to your question can be found in our new and improved wiki.


Re: IMDB plugin issues #10 zigzag

  • Senior Member
  • 169 posts

0
Neutral

Posted 22 July 2021 - 14:40

Thank you WanWizard for your reply.

We will wait until your 8.1 is released and flash it to be able to use it again.

Thanks again.



Re: IMDB plugin issues #11 scriptmelvin

  • Member
  • 24 posts

+1
Neutral

Posted 15 September 2021 - 19:29

I fixed some more things:

  • Characters in the cast list would be listed double ("John Smith as Jack Jones as Jack Jones")
  • User reviews didn't work
  • The user ratings gauge (the stars) didn't match with the actual rating. Caused by the PLi-FullNightHD skin using different dimensions for the widget than the actual pixmap dimensions. I didn't really fix this, I simply included two enlarged pixmaps (suffixed with _HD) with which the skin works. If you change the pixmap paths (append _HD) in the IMDB Plugin section of skin_plugins.xml of PLi-FullNightHD, the stars gauge will work properly

PR #718


Vu+ Uno 4K SE


Re: IMDB plugin issues #12 WanWizard

  • PLi® Core member
  • 60,096 posts

+1,369
Excellent

Posted 15 September 2021 - 20:44

Merged.


Currently in use: VU+Duo 4K (2xFBC S2), Amiko Viper T2C (T2+fallback), Octagon SF8008 (S2+T2), Zgemma H9.2H (T2+fallback)

Due to health reasons, I will have periods of inactivity, during which I don't respond to posts or PM.

Many answers to your question can be found in our new and improved wiki.


Re: IMDB plugin issues #13 scriptmelvin

  • Member
  • 24 posts

+1
Neutral

Posted 21 September 2021 - 22:32

I forgot to include the extra HD pixmaps in src/Makefile.am :o Done now. PR #722.

Also, the skin_plugins.xml needs to be changed in PLi-FullNightHD to use the extra pixmaps (I have it in my skin_user.xml now). Where can I submit a PR for that? Thanks.


Vu+ Uno 4K SE


Re: IMDB plugin issues #14 WanWizard

  • PLi® Core member
  • 60,096 posts

+1,369
Excellent

Posted 21 September 2021 - 22:54

The default OpenPLi skins can be found here: https://github.com/l...r/share/enigma2


Currently in use: VU+Duo 4K (2xFBC S2), Amiko Viper T2C (T2+fallback), Octagon SF8008 (S2+T2), Zgemma H9.2H (T2+fallback)

Due to health reasons, I will have periods of inactivity, during which I don't respond to posts or PM.

Many answers to your question can be found in our new and improved wiki.


Re: IMDB plugin issues #15 scriptmelvin

  • Member
  • 24 posts

+1
Neutral

Posted 21 September 2021 - 23:04

Thanks @WanWizard. @littlesat: PR #893.


Vu+ Uno 4K SE


Re: IMDB plugin issues #16 scriptmelvin

  • Member
  • 24 posts

+1
Neutral

Posted 27 September 2021 - 13:53

Plugin stopped working. IMDb now requires a trailing slash at the end of the movie details URL (it sends you there with a 308, which downloadWithProgress doesn't follow).

Also put www in the URLs, should save a few redirects.

PR #723


Vu+ Uno 4K SE


Re: IMDB plugin issues #17 WanWizard

  • PLi® Core member
  • 60,096 posts

+1,369
Excellent

Posted 27 September 2021 - 13:57

Merged.


Currently in use: VU+Duo 4K (2xFBC S2), Amiko Viper T2C (T2+fallback), Octagon SF8008 (S2+T2), Zgemma H9.2H (T2+fallback)

Due to health reasons, I will have periods of inactivity, during which I don't respond to posts or PM.

Many answers to your question can be found in our new and improved wiki.


Re: IMDB plugin issues #18 scriptmelvin

  • Member
  • 24 posts

+1
Neutral

Posted 29 September 2021 - 01:35

Still a 308 when only one movie title matched.

Also changed http to https, should save some more redirects.

PR #724


Vu+ Uno 4K SE


Re: IMDB plugin issues #19 WanWizard

  • PLi® Core member
  • 60,096 posts

+1,369
Excellent

Posted 29 September 2021 - 09:32

merged.


Currently in use: VU+Duo 4K (2xFBC S2), Amiko Viper T2C (T2+fallback), Octagon SF8008 (S2+T2), Zgemma H9.2H (T2+fallback)

Due to health reasons, I will have periods of inactivity, during which I don't respond to posts or PM.

Many answers to your question can be found in our new and improved wiki.


Re: IMDB plugin issues #20 scriptmelvin

  • Member
  • 24 posts

+1
Neutral

Posted 6 October 2021 - 22:53

Also, the skin_plugins.xml needs to be changed in PLi-FullNightHD to use the extra pixmaps (I have it in my skin_user.xml now). Where can I submit a PR for that? Thanks.


My PR for PLi-FullNightHD got merged. So in a future update, the stars gauge should work properly.


Vu+ Uno 4K SE




0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users